Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2089390lqe; Tue, 9 Apr 2024 09:12:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUyKYI24TUVM2TyMOWt5mtaOzbOzZg8fhYIpmwUfZuK4eheT/tyXMN7T/snLZwVN8qZDfWMWPGLXlEk0c0t6trTOfKJ7Nb0VZKkWw0gmQ== X-Google-Smtp-Source: AGHT+IGsR/RffAnZL68RMyjjSai5glAXIEG75U3B8RiR8PNMOHun48IRm8e5fyA77JhgWOypSPfo X-Received: by 2002:a17:90b:4009:b0:2a2:da08:67db with SMTP id ie9-20020a17090b400900b002a2da0867dbmr4564614pjb.6.1712679170787; Tue, 09 Apr 2024 09:12:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712679170; cv=pass; d=google.com; s=arc-20160816; b=fDWfd62lz8qSuHKJXJYVB18cVAdjJ35uldabnKBwf3IwxsTTEQSriTx1ixribaQv3f bq1Lp0kROXccpkFwEhxv/SKAZKMqgotfeZ1yVoHxworkN1MknJpg+pDkFCMELqTUkWCv TFAPrYxxhr24zTrl66WB8wb2K2WmmwMjrTTxfaA+l39qATTMxEU2gxvpH0bEwQ1SfZCL dx4XzgYTMJSK/nDmlTzM9bkDVAMsdRpIZixcVYmq2wTURDb4jDeH9HE2DswEZgas553M GHqvvC9feuu+FTRXpjqrvP2VtWnII5oYefHsSVqTF2TapBu/1fOcNJdONdtvSEfEg8Ya +ygg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=iokGLwsqJfb4NxRhk5ow1oSNlqc6dGVX7cO8ljBDKSA=; fh=irFB4/lKYt62lBIBc54/Co0KU27SEWaofK1jC8UHoQE=; b=xdikeYGnFjzgg3/kFA2taZqWE39zhkyEL8H7Zr9pMDupY3p/PDnRAcYYHhmWdeyhQS yYkZq8j8vghfz0im2DerADq3MaMatIw130cE8ERXCgror1dNTesf0n3g4kdydvieXNph O8ArPyigozMXv0OtVl59B1js/t2W/mZkO+KsUVNyKTAX7RzFoo19RpKNTjQgzI4SlTB2 YpHuVKzKVsTItOCHGA6Th98jgaYGOWhHUMub+ZhWaCgpjDYbIT/zz46kFn8XSBGnm3Sg wTwBK/sxncScI6VTCexvrK87YFBxxuSKteYZ3wEHlQcG9+lkKQwY4KEs7Wo0Q5Fdfr/p sMQA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="WoH/D2oG"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-137296-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137296-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id u11-20020a63790b000000b005dcbba892cdsi8717388pgc.327.2024.04.09.09.12.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 09:12:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137296-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="WoH/D2oG"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-137296-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137296-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 734DE282175 for ; Tue, 9 Apr 2024 16:12:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77E2B13D89D; Tue, 9 Apr 2024 16:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WoH/D2oG" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E0513D885 for ; Tue, 9 Apr 2024 16:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712679156; cv=none; b=eJshlrfIRLYlAOQONprFV33Tc3ONkGM3YMCnw/OwPLy+Y4zkA+LVOGoLeIkvhVc+9fPr5YTfJoSaCYMo82wxRJOFVHTP4ODL3mTLKVeHoRfrJ7n8xMdakChPw/NWZFp1lnOFT5Dt0N9Fabmos9/cElhIGJPFZijWiUQctjW2EQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712679156; c=relaxed/simple; bh=iokGLwsqJfb4NxRhk5ow1oSNlqc6dGVX7cO8ljBDKSA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=eSP3MsjJ4euPOHeGiwLatatSU25KFtdTysuwgO6HruslGzWDqc8n1ccrXeI3kJVBxi89aA5KBkQfOXojFKrs32GXWiFfxv/dtEd3CvxU1CmYpIo7NyiYuFHLwpDL3Na1cN04h+QE9eIA1BfmTvXGIB0f3ddhxWgFG+90ccedcPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WoH/D2oG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712679153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iokGLwsqJfb4NxRhk5ow1oSNlqc6dGVX7cO8ljBDKSA=; b=WoH/D2oGLu96Zo9Fcoxmffuaw5W2KJkrvYBuO4L+B0qYxp0P26BHr9z7Tm1xd5nrDUx0c+ W4ZyYVTI9CxKDQseLVoLRACYgxgN5cotdZgR8EMQiYHBoSq10mLQIN2DrnQIH9qIBGOQ5A CQLxB/sTod0y4BAa9HWYgDyFHTgUH/c= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-374-t_zNaTyMPImZj4I4rJbpNQ-1; Tue, 09 Apr 2024 12:12:32 -0400 X-MC-Unique: t_zNaTyMPImZj4I4rJbpNQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-69a011f3069so48631216d6.1 for ; Tue, 09 Apr 2024 09:12:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712679152; x=1713283952; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iokGLwsqJfb4NxRhk5ow1oSNlqc6dGVX7cO8ljBDKSA=; b=eFoMz+N9CF3w0iaYKlHWS0nR3KfD/SDVOOxiRZZ95axtMmPweY12FLht5lQ8DHQlaC oGx4aqTx/E0g5OUaSIjC088QtSNb5gzCi0Ztb+tj/9RjnV7UIn2yXOUBZMFleJs9XnAU 5IqG7CXQY/EEH7HEcHNlSodhIfjW7jAXSp5qFo2I4UiDSqzknHtzmnif5/FbFO/4HNpU 1wdaRSGnJ+jXp4D/E0pJVOsEXgXv3at2O3vDV+SXXiXF9Yhj7trofVvzkVd5zEjRJgqS ltStbNANMZk2ztMuEf8QIMJNmY81imewl0lFPzig+L3EFoBqfDBIpjSMKGNtPlyAudTU N0zg== X-Forwarded-Encrypted: i=1; AJvYcCUVyrmMvnqKxC0phNRgeFROLnrOEB6uCWDGYyyej3BCkQ04xxrrXqV9EnGuvMLzlUKIhDRfPGlW7ftpYkEXCJAEYkiVf/pGw0R4l7Fo X-Gm-Message-State: AOJu0YxcCOfpzCuVKt1dB8wmcg9smq/VECX2J+pWYwGma1kC8m+E1bIL vbIIwelRF69YfRNomGBYZv2yj5CDr5r84cnGo+1+wjno5vQh5VUY4HahNqGOpo8/kY1tGxIgayi HRyNYJJJW4oUFl46uzKlPd5AnmjZik9+i1vyNxc7MfyxZThSIbhZCBhVcLDkeqw== X-Received: by 2002:a05:6214:aa8:b0:69b:f01:6fbb with SMTP id ew8-20020a0562140aa800b0069b0f016fbbmr4689376qvb.22.1712679151778; Tue, 09 Apr 2024 09:12:31 -0700 (PDT) X-Received: by 2002:a05:6214:aa8:b0:69b:f01:6fbb with SMTP id ew8-20020a0562140aa800b0069b0f016fbbmr4689326qvb.22.1712679151462; Tue, 09 Apr 2024 09:12:31 -0700 (PDT) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-141-166.abo.bbox.fr. [213.44.141.166]) by smtp.gmail.com with ESMTPSA id bp9-20020a05621407e900b00699376bcc9fsm4115136qvb.123.2024.04.09.09.12.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 09:12:30 -0700 (PDT) From: Valentin Schneider To: John Stultz , LKML Cc: Juri Lelli , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Youssef Esmat , Mel Gorman , Daniel Bristot de Oliveira , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , K Prateek Nayak , Thomas Gleixner , kernel-team@android.com, Connor O'Brien , John Stultz Subject: Re: [RESEND][PATCH v9 2/7] locking/mutex: Make mutex::wait_lock irq safe In-Reply-To: <20240401234439.834544-3-jstultz@google.com> References: <20240401234439.834544-1-jstultz@google.com> <20240401234439.834544-3-jstultz@google.com> Date: Tue, 09 Apr 2024 18:12:26 +0200 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 01/04/24 16:44, John Stultz wrote: > From: Juri Lelli > > mutex::wait_lock might be nested under rq->lock. > > Make it irq safe then. > > Cc: Joel Fernandes > Cc: Qais Yousef > Cc: Ingo Molnar > Cc: Peter Zijlstra > Cc: Juri Lelli > Cc: Vincent Guittot > Cc: Dietmar Eggemann > Cc: Valentin Schneider > Cc: Steven Rostedt > Cc: Ben Segall > Cc: Zimuzo Ezeozue > Cc: Youssef Esmat > Cc: Mel Gorman > Cc: Daniel Bristot de Oliveira > Cc: Will Deacon > Cc: Waiman Long > Cc: Boqun Feng > Cc: "Paul E. McKenney" > Cc: Metin Kaya > Cc: Xuewen Yan > Cc: K Prateek Nayak > Cc: Thomas Gleixner > Cc: kernel-team@android.com > Tested-by: K Prateek Nayak Reviewed-by: Valentin Schneider > Signed-off-by: Juri Lelli > Signed-off-by: Peter Zijlstra (Intel) > [rebase & fix {un,}lock_wait_lock helpers in ww_mutex.h] > Signed-off-by: Connor O'Brien > Signed-off-by: John Stultz