Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2091263lqe; Tue, 9 Apr 2024 09:15:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVI92Cw7IrCfBU1LjFUbmFTAHyvqsIyEU5vJB7Svf5gL0EsaIUwX41HrFZ902Nu4QyC43CtzrLu+sVmd6tK/BMS6BwvUfkRVJxcvF4IJw== X-Google-Smtp-Source: AGHT+IEmoDsPCfoVvMWUKTzkD66afML36/HDUkEvN/780fFif14Sl39tt8ML/34zFGaReAcsA2kU X-Received: by 2002:a50:d59c:0:b0:568:d19e:7ab0 with SMTP id v28-20020a50d59c000000b00568d19e7ab0mr11374818edi.36.1712679325096; Tue, 09 Apr 2024 09:15:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712679325; cv=pass; d=google.com; s=arc-20160816; b=V0m1w5wGEyfmyqvVGelQTSy77WHeg0BE44ebK0Fa9ws1zSzBMP+yVe45/jN2iAP4iR xy4TtGHP76VSpunNoBq4+jUyNzfTHhv34mFOLsm6kO9HKmVPFEjqcDz4/cePXJwqBNFe ItFKDKbMDj8lTuqMMS9R+dci98s2ELK0TWDSpa3lcPYMSS1CMKji6m8wnbmbhQsT7Rxs lKQ966TdBM5H9SeeyJD/s0k7VPx4xcro0BTnYgLkTcfd2TE4u88+RkvLQslpSJItszQ7 +OVslDKDHxDDpO4AOkBP77lwNa0YlT5oAyyQKSI2GpgUYikfF9iwIkVdrR2vS1NLbjib LU4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=psn6Ri/4HxTIEa5og+2LF06wxFvUe/WNtpM1VRSHt8A=; fh=hViEZJk+dzU8x5g5o0lS9+YaHGExWLGpZap9McQrEb0=; b=eOqAdswslWbHgOlvNyoS0xlrdZp8rSDKY2ZqbEWlVoqQ/GBZp1iMCq2X9EZOxkRm7n JRuKK0yNBWEKPWIAALTWKkWD3MlI6ySDJB+uqyjGOceZW967yp2rDdVFy4doRlltlect RYIov5GbSbaI8Ts3tgGu8sCVDXKiM0hwiDxIgjnmpEIYjzKPstvImHi8rh7Y85UiTBlj +TtTZZZKwIz0RXQRYp9+xvu3sDzxWnC3jOWPg/YIqFlxHZAYcf+wXaXvxG7hKJQ3lQjP 8BP1lzDR2BSA0wVLcNbHYmxa5MKHymB1fl6IVdQVIqUGz3lhxfzE+EeEO+buTuyFtmMO MvBQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="DZEwP/ci"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-137298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id w3-20020a056402268300b0056e1e23fd92si4837569edd.10.2024.04.09.09.15.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 09:15:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="DZEwP/ci"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-137298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CF03A1F22C02 for ; Tue, 9 Apr 2024 16:15:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BAA8713D8BD; Tue, 9 Apr 2024 16:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DZEwP/ci" Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F5E84F883; Tue, 9 Apr 2024 16:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712679312; cv=none; b=d1UXhMEAuBtb9gUspcswAjK909hfmlhKHjUCy1gPGh/IOzuEy6wcdB3nGx3m3NpoyJdZCLm+kzbPPjN87ght+JNCQptMPCRkesiWDpigpsqjTjdRZ8pg0gltFrgni+YdrNvANhuus3OQVXgheRa32cYfe15zBPUn8inXQY13VXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712679312; c=relaxed/simple; bh=GctYHvPeKVpuxt2D+ZotCon7pgUXv3bhxrOGr4ni9qQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dAi81JnvflxMcf/MnFz+CD9qJwUnzFvDOpYkAegr2oW9kNBm6VccgickW2EACRfyOH5ZoISgFzFjYMSoG7j0QPMbMtR0avQwXyRedR4pGLdhhZ657Ma64UVB8kUG7TMsqlcYrxRG/pdp7D+tEvZvbVYcL65GKPgqh+ot04xVrtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DZEwP/ci; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-34560201517so715621f8f.1; Tue, 09 Apr 2024 09:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712679307; x=1713284107; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=psn6Ri/4HxTIEa5og+2LF06wxFvUe/WNtpM1VRSHt8A=; b=DZEwP/ciuAbkYdKNcAidzt8tG70U2YKWnLb9necNhDJTvrLBo0zFf3yeOCb7oPZyr9 pWqN5Yu/ON3k5bZ4eyPCb5m1pzILck1WaYIFr53BoMKusajf9GYqEGXw4ZFXL90OYgGf IDBx2zEB7KYbA9tSegUPDm/gNLRE3OQeyc5DORSNlOgY1FxqsJuJvZohXbUEjVwatiFz LBA+wR0Y2KzMcQjga3WlzTOlF9p1JgfErhD06511jD5jCB8vT7gJ/EDr2OWgVnzK1K15 ZG0nS87DegbNquL6Z59sIxypjMdfTv0LRjSA/Bq7UEWNNVzJhD2B0Z/qQ1u2rK4u+tam MjzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712679307; x=1713284107; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=psn6Ri/4HxTIEa5og+2LF06wxFvUe/WNtpM1VRSHt8A=; b=bJiNczF0/QZWDStZasJL9YcovbG6x4g1QxydTZTPUiWxuaNSrRG/xjwZ6nxEONDrno /EHk7jTg5ZXbFrIhM01U8MuCou0BHUFzYBMpVLE2G20r+ThF5V0Dix34hJ6NwNHLUEft KdpUyPY62E8q3bGcpprmxI8U/84cRsccxRZK0RPJ+xQamZUmS7naw7Rkqz6fk2HF0Xla mMMqxsCTM/0pMP/N+CgjtlWlaS5TXnIuPjMJDzBTq8x/Tc9M2ovjq5l82ECcjTGpHCdf x1JW0H8jSeJNcGCkcHrrDzEuk8Ykvi6qf2qHsSgfG6DOZVmEFASWqFIlZ2kMPhnNaAgx HkTA== X-Forwarded-Encrypted: i=1; AJvYcCWDjfVWSYgKMGUsfrV9IU/7vfOS8JKj3g5ecRLcbJpBiUo4XpsLnppUpgd/djOCwW5E5rEj6y709Qf01F/weP0VnsYwbtCnilavN+9qGSvYW9GnB0Odb1/9xWXZQcP9IHcOb33KirMNRgss53FauAjCO6mUr3rafVzu X-Gm-Message-State: AOJu0Yy9+21339L+7puQrFE6iAmA65iFvVKl03WxRx19qvNhqXLXZJ7q qpCU8I8cHTRV5hska60vWZfbCQaPCvCk3nLzkrDeDq0JpuHWqmC1 X-Received: by 2002:adf:a347:0:b0:346:5051:1c6d with SMTP id d7-20020adfa347000000b0034650511c6dmr84719wrb.5.1712679307221; Tue, 09 Apr 2024 09:15:07 -0700 (PDT) Received: from [10.0.0.4] ([37.170.252.166]) by smtp.gmail.com with ESMTPSA id c18-20020adffb52000000b00346266b612csm1854185wrs.81.2024.04.09.09.15.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 09:15:06 -0700 (PDT) Message-ID: <49344fc4-a524-4c54-b75a-f094adf90353@gmail.com> Date: Tue, 9 Apr 2024 18:15:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] netfilter: x_tables: fix incorrect parameter length before call copy_from_sockptr To: Edward Adam Davis , netdev@vger.kernel.org, edumazet@google.com Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, haoluo@google.com, john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, linux-kernel@vger.kernel.org, martin.lau@linux.dev, sdf@google.com, song@kernel.org, syzkaller-bugs@googlegroups.com, yonghong.song@linux.dev References: Content-Language: en-US From: Eric Dumazet In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/9/24 17:00, Edward Adam Davis wrote: > If len < sizeof(tmp) it will trigger oob, so take the min of them. > > Signed-off-by: Edward Adam Davis > --- > net/ipv4/netfilter/arp_tables.c | 4 ++-- > net/ipv4/netfilter/ip_tables.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Hi Edward Already fixed in net tree https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=0c83842df40f86e529db6842231154772c20edcc Also a followup has been sent today https://lore.kernel.org/netdev/20240409120741.3538135-1-edumazet@google.com/T/#u Thanks.