Received-SPF: pass (google.com: domain of linux-kernel+bounces-137263-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240403161559.19970-1-apais@linux.microsoft.com> <3358869b-db3a-40f3-b02b-4f1b46d5d724@kernel.org>
In-Reply-To: <3358869b-db3a-40f3-b02b-4f1b46d5d724@kernel.org>
From: Allen <allen.lkml@gmail.com>
Date: Tue, 9 Apr 2024 08:48:12 -0700
Message-ID: <CAOMdWS+fq=hW0MpcCKYrJ5tYHBqVDPRu85cfpH215RwJWQz_HQ@mail.gmail.com>
Subject: Re: [PATCH] tty: Convert from tasklet to BH workqueue
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Allen Pais <apais@linux.microsoft.com>, linux-kernel@vger.kernel.org, tj@kernel.org, 
	keescook@chromium.org, gregkh@linuxfoundation.org, richard.genoud@gmail.com, 
	linux-serial@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

> > The only generic interface to execute asynchronously in the BH context is
> > tasklet; however, it's marked deprecated and has some design flaws. To
> > replace tasklets, BH workqueue support was recently added. A BH workqueue
> > behaves similarly to regular workqueues except that the queued work items
> > are executed in the BH context.
> >
> > This patch converts drivers/tty/* from tasklet to BH workqueue.
>
> Quickly looking into the changes, could you also elaborate why not to
> convert most (all?) of them to (non-BH) wq? Or threaded IRQs. Much of
> the code comes from the pre-WQ era.
>

 You are right. The idea I had was to convert every instance of tasklet to
bh workqueues in the kernel. I will send out a v2, which will use
threaded IRQ's.

Thanks.