Received-SPF: pass (google.com: domain of linux-kernel+bounces-137328-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 9 Apr 2024 18:32:41 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Yangtao Li <frank.li@vivo.com>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback
 returning void
Message-ID: <fgmvwuzy34cruggah2z7fau4nnfzopuylsgjs6zzdypp26boya@ekrj5myjef5f>
References: <20230712094014.41787-1-frank.li@vivo.com>
 <20231204115517.zxjgi6ateobjj52d@pengutronix.de>
 <h2sjdrgs7hwmbucr3rxlpusnkpj5tgq2fx27gijtrglr5ffhs6@s63cp4isu4mx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yudkqucvkn2t7jnw"
Content-Disposition: inline
In-Reply-To: <h2sjdrgs7hwmbucr3rxlpusnkpj5tgq2fx27gijtrglr5ffhs6@s63cp4isu4mx>


--yudkqucvkn2t7jnw
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Mar 06, 2024 at 10:33:06PM +0100, Uwe Kleine-K=F6nig wrote:
> On Mon, Dec 04, 2023 at 12:55:17PM +0100, Uwe Kleine-K=F6nig wrote:
> > On Wed, Jul 12, 2023 at 05:40:13PM +0800, Yangtao Li wrote:
> > > The .remove() callback for a platform driver returns an int which mak=
es
> > > many driver authors wrongly assume it's possible to do error handling=
 by
> > > returning an error code. However the value returned is (mostly) ignor=
ed
> > > and this typically results in resource leaks. To improve here there i=
s a
> > > quest to make the remove callback return void. In the first step of t=
his
> > > quest all drivers are converted to .remove_new() which already returns
> > > void.
> > >=20
> > > Trivially convert this driver from always returning zero in the remove
> > > callback to the void returning variant.
> > >=20
> > > Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > > Signed-off-by: Yangtao Li <frank.li@vivo.com>
> >=20
> > Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> >=20
> > Can you pick this up?
>=20
> This patch isn't in next yet. Is this still on someone's radar for
> application? Would be great if this patch made it into the mainline
> during the upcomming merge window.

It didn't made it into the merge window leading to 6.9-rc1. What are
the chances to get it into v6.10-rc1?

I just checked, the patch was submitted when Linus's tree was just after
v6.5-rc1. So it already missed four merge windows without any maintainer
feedback :-\

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--yudkqucvkn2t7jnw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYVbagACgkQj4D7WH0S
/k6KuAf/bT1XmaN2Cba7EVDNiZ//oKiFV0fhRs5/Rr5ue/m8zzAVYdq4vvPluEoT
TxlpEv/dCM2SPexO4qV0WbdGYyiw0LE7eAA1M2I5P0y4GqpUxV935kmzr0Qr47eo
FzpJMCker7SS4DxMH8f9cub97KN79AZycI00s3VmVMkytFy7COBkWbnFOSYfWmdw
KNeEJg6xVc2iblfpjCY25LEAhQn7u+JrnmNZ9DY28OENH+oz4xQjH1O/T+zoLYip
Kul19p3gctyaXhdNYc0HZD7aQX26mEvpD0O7E4pM1Xh8Ps6DI81ppcrsRZFMVgFi
EbiNNMjLiKJWmNsZc3DPZJPma8ydlQ==
=FFjN
-----END PGP SIGNATURE-----

--yudkqucvkn2t7jnw--