Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2106650lqe; Tue, 9 Apr 2024 09:39:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV2c6eomlsiTwrxgmfdKZQkjxyJkFcqUvepU2kCimO/39WB/8b29bWsveQq47WwA36J2uyYxdNi75XK1udnb0Gcd1D2maaXz5aJaU01SQ== X-Google-Smtp-Source: AGHT+IF8afKda/IBW5sOp+6z71pojfC61QdHDrcIO3G61blDhqpun4WF2jP5wT5tRbyjFv9ouKjj X-Received: by 2002:a05:6a20:244f:b0:1a9:11f8:4a8f with SMTP id t15-20020a056a20244f00b001a911f84a8fmr557678pzc.0.1712680741281; Tue, 09 Apr 2024 09:39:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712680741; cv=pass; d=google.com; s=arc-20160816; b=rhqIpdlWOynGE6GaLIXlxPyNMdp5N3zeHitT6rsRobntKl1UyDQVL5RcBMOeK0zxuy 4jFxISjTs2GY7xy1AjU44Y8smc0yXry3GUAuVxKtSmJYlF/pKv5jH+8OVwrgloWOTgCr QkU+0V3HpBuTpsJ+iITOxeNHLnvGxvWOKotPPKrr3S72DZVbW5kc143LEe20c/FuMlY2 pRXjLqo5uRyDryMPxEy97U3nfbqoqYhzWvVqmEHs+aM/YmpxMGTbha90Dhq/Z5C138tt pe23EdNgZ70BWi7Mi7a+LNnTs45xl4foMb9hKLb1AFS5AnbUrBCf9uKhS8Vvq0G5h35a 2EMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=RO/ZWp4a+TbCWiJJVnk1jNMrTa4t5wCjsm2zT6QGFvI=; fh=16nZBzywhjZ9ZG50lncVmQp2BKWrpHBHTmkikhVkR0k=; b=rpTzXcYIyBvTTNHgZ5rXRCYJojxkKINR+DtOubZOmsRbRQc4OtaRCKRSgnxExvxH2Z BEDzxy96i+MU8VlaNg1iD79eTsZI4eEHkCHZ9uVQdeqQjMuKf3X2K5G1R1W58BcDCao2 iVw9YUrZSZ02OlUL5gb1gc0USLxnI5o2sfDqto4SvymMhEKP8ogNH2noCubv0ef6MR6r TwiFBAlawS9FqP8wk11nslUZdKj8tvYS6wmF3yrp2mqPYEp3KhgHD57vqAPAPmx6Qe7S t56KE4euGma/UB9hJ2SV7n+NI2P6delabpN9HLrgt/R6vPuuyWPbnIv93odYnIU6061/ 77CQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uHsfcDCm; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-137242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137242-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id c3-20020a056a00008300b006ea8c975ef0si8578998pfj.398.2024.04.09.09.39.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 09:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uHsfcDCm; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-137242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137242-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 39C56B280D1 for ; Tue, 9 Apr 2024 15:39:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4C3C113D88A; Tue, 9 Apr 2024 15:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uHsfcDCm" Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D10713D625 for ; Tue, 9 Apr 2024 15:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712676956; cv=none; b=Z3vgqRh1IBFQUmf1AsMD0CCT5XB/SBerCPLs91uY6doQbutHUqQd8OuUGIEMk/VhV9YCgCgwBNOPh62oIU1Km3+ddz9frmcjRhjh7iFFhsvpN522/5A6GjAMV9treKDowHvsfNsePBnaSA8IJLw5MQ6tJi8H0XOwhhV4jsXAuJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712676956; c=relaxed/simple; bh=z5AF5xY1j5K4ShCi88r9SGOibb/8QoN3dzNf4V00bdo=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=sl1ip7/8+mbRSTTzaNEhemvAdhsNq5avHGjVFzP9/YFsoGBASSpYKbTcJ5bFNKTowZ5DOGmee9cXpjufL8OHEDAAAATgh93CsW4jHPIpMUT1CyEC6e44VUf900qjn5+U+48usjGrKf9skcXQzetyGDEsNv4q4zTdTKyK+6fcVf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uHsfcDCm; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-416632343d0so17685575e9.0 for ; Tue, 09 Apr 2024 08:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712676953; x=1713281753; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=RO/ZWp4a+TbCWiJJVnk1jNMrTa4t5wCjsm2zT6QGFvI=; b=uHsfcDCmErwWXuaCw+jBvo8ARW1yf0HFm4QkOMqc5tHfP+g72fazGhJfIsUnCt8xpe mp/xRZsIg0mgOZqJhTG8cT7McPXGJ1ukft0WWdaIUS+eWaDA2zXp8vzYYaWFVJ1n4c3f SCKvonjGJfPXnUNxwdImPJFX79k8bQBPCc+4An4JmfWG/NfhIaNniA8hj56CNjbaFfps zd1uD1WICyi/4n/5GXUDYbTz3/piVvk+Bvrj9mW0yKGLaG3FVKLIUKSdcta23cxqKwRN dydlEQziVshhvzTl9Kd5bJ8PPzPHlRyIBKwjcFbpdJ+No1jeRPUwmtUSN+f7b0r6q86a xMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712676953; x=1713281753; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RO/ZWp4a+TbCWiJJVnk1jNMrTa4t5wCjsm2zT6QGFvI=; b=Nj/tj4pwpTKUqX7ZZqSm4E/AOPg9Cpjw6jOxK3ida3llWYbO9XDMsxtPS5lQm2Xuw3 12gy1waEaz0vmLUa/cmcywv//f4d5fxFD+ueD9vynapArIcp4h6pXwzDQMqg1VCGR6XF nBGZUO6O4oYhyIUypZVATTigZr5qEOFOjF5W/nw7aQTce7aSroIwhsljXoslrXp6WckZ K8l6jrefvFIjCvzWMSnXZ/GAIv+/qnL9tRy6Ybt6Mg8aaL+WeppoeWfS2gnbtUrPDtOo GmKFv0coiuHJV8MCWMoA8Sa0J89ADIZVULprH5s+//sfCva5Q0jCk678Pt9gNPWY6gtS iLlg== X-Gm-Message-State: AOJu0YxHFzXfmB0Pp0Pd5Yy0MQYTB20qwPrWQ+uBbKcwnchLmbcYmbS5 DEUZWfZ+s5kVFpqz9T7pNxhI3r+zkNjkIpjJ286JJOduHFiEkKtOxgriAudAgDk= X-Received: by 2002:a5d:4088:0:b0:343:7a53:16cf with SMTP id o8-20020a5d4088000000b003437a5316cfmr65352wrp.41.1712676952870; Tue, 09 Apr 2024 08:35:52 -0700 (PDT) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id s7-20020a5d4ec7000000b0033dd2a7167fsm11760977wrv.29.2024.04.09.08.35.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 08:35:52 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 16:35:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/8] media: qcom: camss: Add new VFE driver for SM8550 From: Bryan O'Donoghue To: Depeng Shao , rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, quic_yon@quicinc.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20240320141136.26827-1-quic_depengs@quicinc.com> <20240320141136.26827-7-quic_depengs@quicinc.com> <18837b02-27af-4d0c-a772-bb7ce787a4c0@linaro.org> Content-Language: en-US In-Reply-To: <18837b02-27af-4d0c-a772-bb7ce787a4c0@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/04/2024 14:39, Bryan O'Donoghue wrote: > 1. Please use 'rdi' not 'n' as the parameter here and Ignore this comment 'n' is the right value here - you've already used 'rdi' in CSID which is the appropriate place 'n' is correct here. --- bod