Received-SPF: pass (google.com: domain of linux-kernel+bounces-137336-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240408151700.1761009-1-festevam@gmail.com> <2024040940-resume-polygraph-5800@gregkh>
In-Reply-To: <2024040940-resume-polygraph-5800@gregkh>
From: Matthias Kaehlcke <mka@chromium.org>
Date: Tue, 9 Apr 2024 09:42:43 -0700
Message-ID: <CAKZ8rEMg8SamD_R46LpA9LAh4WUhH=6zsqjkXS0ABVdPAK9Czw@mail.gmail.com>
Subject: Re: [PATCH] usb: misc: onboard_usb_hub: Disable the USB hub clock on failure
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Fabio Estevam <festevam@gmail.com>, frieder.schrempf@kontron.de, 
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Fabio Estevam <festevam@denx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 9, 2024 at 8:29=E2=80=AFAM Greg KH <gregkh@linuxfoundation.org>=
 wrote:
>
> On Mon, Apr 08, 2024 at 12:17:00PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > In case regulator_bulk_enable() fails, the previously enabled USB hub
> > clock should be disabled.
> >
> > Fix it accordingly.
> >
> > Fixes: 65e62b8a955a ("usb: misc: onboard_usb_hub: Add support for clock=
 input")
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
> > ---
> >  drivers/usb/misc/onboard_usb_dev.c | 6 +++++-
>
> This file is not in the tree for 6.9-rc2, can you please fix this up and
> resend?

The driver has been renamed in usb-next. Shouldn't this patch be based
on usb-next and the backports to stable kernels account for the name
change? v6.9 sits a bit in between, since there is no stable branch
yet. The fix doesn't seem super-critical, I guess it would be ok to
leave v6.9 as is for now and add the fix once there is a stable branch
for it.