Received-SPF: pass (google.com: domain of linux-kernel+bounces-137408-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 9 Apr 2024 18:32:03 +0100
From: Conor Dooley <conor@kernel.org>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: Nikita Shubin <nikita.shubin@maquefel.me>,
	Arnd Bergmann <arnd@arndb.de>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH 0/4] DONOTMERGE: ep93xx-clk from ep93xx device tree
 conversion
Message-ID: <20240409-unselect-denatured-6af8a07dbd9a@spud>
References: <20240408-ep93xx-clk-v1-0-1d0f4c324647@maquefel.me>
 <20240408-friction-mosaic-ba48bc27788d@spud>
 <42f9da044fdc11e2495f6845c061afefa796f7cf.camel@maquefel.me>
 <73fd3f42c2d63467bb1b04888659e829f9e54f52.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="hfWycvtu4zQBs5eK"
Content-Disposition: inline
In-Reply-To: <73fd3f42c2d63467bb1b04888659e829f9e54f52.camel@gmail.com>


--hfWycvtu4zQBs5eK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 09, 2024 at 05:09:35PM +0200, Alexander Sverdlin wrote:
> Hi Nikita,
>=20
> On Tue, 2024-04-09 at 14:48 +0300, Nikita Shubin wrote:
> > On Mon, 2024-04-08 at 18:03 +0100, Conor Dooley wrote:
> > > On Mon, Apr 08, 2024 at 11:09:52AM +0300, Nikita Shubin via B4 Relay
> > > wrote:
> > > > The goal is to recieve ACKs.
> > >=20
> > > I dont see a maintainers entry in -rc1 for the drivers/soc/cirrus
> > > portion. Who is gonna give you an Ack for that portion? If you
> > > intended
> > > maintaining that driver, should you not add a MAINTAINERS entry for
> > > it?
> >=20
> > drivers/soc/cirrus got it's ACK from ep93xx MAINTAINER - Alexander
> > Sverdlin.
> >=20
> > Arnd, Alexander - should we add it now ?
>=20
> seems that we have couple of things to fix:
>=20
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #51:=20
> new file mode 100644
>=20
> WARNING: please write a help paragraph that fully describes the config sy=
mbol
> #60: FILE: drivers/soc/cirrus/Kconfig:5:
> +config EP93XX_SOC
> +	bool "Cirrus EP93xx chips SoC"
> +	select SOC_BUS
> +	select AUXILIARY_BUS
> +	default y if !EP93XX_SOC_COMMON
> +	help
> +	  Support SoC for Cirrus EP93xx chips.
> +
>=20
> total: 0 errors, 2 warnings, 269 lines checked

FWIW, I wouldn't be too worried about meeting the minimum line check for
the Kconfig option that checkpatch requires - but the description here
is not clear what the driver does.=20

--hfWycvtu4zQBs5eK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZhV7kwAKCRB4tDGHoIJi
0sK2AQC8a1isyFTn6fekLdOTJ4w8j4r0IrldzsHLvayDPHqQRwD+IxgI3A8hZ5Iz
7lJYuGUc1y73HVsn2n9d/ZbXPDzCGA8=
=jf+f
-----END PGP SIGNATURE-----

--hfWycvtu4zQBs5eK--