Received-SPF: pass (google.com: domain of linux-kernel+bounces-137370-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <8187c490-b1e1-4c7d-9f7c-590ade4777c4@kernel.dk>
Date: Tue, 9 Apr 2024 11:10:38 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] iov_iter: add copy_to_iter_full()
Content-Language: en-US
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org,
 linux-kernel@vger.kernel.org
References: <20240409152438.77960-1-axboe@kernel.dk>
 <20240409152438.77960-2-axboe@kernel.dk> <20240409170644.GE2118490@ZenIV>
From: Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20240409170644.GE2118490@ZenIV>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/9/24 11:06 AM, Al Viro wrote:
> On Tue, Apr 09, 2024 at 09:22:15AM -0600, Jens Axboe wrote:
>> Add variant of copy_to_iter() that either copies the full amount asked
>> for and return success, or ensures that the iov_iter is back to where
>> it started on failure and returns false.
> 
> FWIW, see git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git #work.iov_iter
> 
> There was an open-coded instance (skb_copy_linear()) that I'd converted to
> that helper in the same commit; I can split it, of course, but I don't
> see much point in that.

No reason to split it, I'll have a dependency regardless. I'll just pull
your branch in, so ignore patch 1 here, 2-4 will remain the same.

-- 
Jens Axboe