Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2148793lqe; Tue, 9 Apr 2024 10:48:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWpY2QYkYJ8puUDj6nmPV1uRFlPpdm7iNckO3enAWpl4vSYwyq6UNEV/G0qoIFYrFWAaGuSnts9xHttFOOyPnQ1tckQRvYL24MBvixG8Q== X-Google-Smtp-Source: AGHT+IGUHgIAFzLKtixPg1I7Kmlm6NsjLUeZgRsgw8ojcWE3tDesbnPTWRBgZWV6yowgRUn/MY// X-Received: by 2002:a05:6512:b93:b0:516:a091:db5e with SMTP id b19-20020a0565120b9300b00516a091db5emr113170lfv.48.1712684911262; Tue, 09 Apr 2024 10:48:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712684911; cv=pass; d=google.com; s=arc-20160816; b=CuC4LJrvZCRjQKfL3VPgU+kRdpAUSeNttILwtw9rW536QeTkUwTIIenlqvBOMfjp0G myGfFdFWmwpO3hlhNc92ba+EWxwOby1lswYgmPTnvyayk6F3NBJV8wXUvr+UIasFRo7P hTtGzkmoCGduhD3iwLVAfZsv/9J6NpS19m6RibMrFlxg6CSJs+VxnXKwsSwzx0DhDKWJ IuvqywlcHZM9wXNXPO7y1vYi6cJcDfHxiSfqGBTCghU5drYsUcCTXq7o21SBpbBx7kWX WPUN2qqKEp3vbmzEeMuCz5jqHUklnqTVX7nUKnLQcTHknpqjJbQsUBSVqZFmJ3mG7sut C9SA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6/BLcu5rNL2R+AoqvUIBNnuK/bYsOxCOBvtkI+r5tLg=; fh=3C/IGn7YFlt83e9qOU4a20yzaIeijwgglyIDnWviaJ8=; b=waQhmAvYgnsqxjcp8W6QhGgI2jynrgJCITJw/OSyQIDpji4uSPUgmtIMH6z4qNVT6R WgWiBz/S5EIJFBmz0tDsWK/+xj4f4V7sdY+HKbpWyeeLWPcdxddiKMtccnOf5CycppmM pK5K7+fkRHzGVa0k0vihcmH95CR+nZ9tk+ptCLndEVxiuD334pQUlZHxrXs18yp5WLsi Iw4OlPnObhl8OFhpe9IOXVMUszE8wFbN7i/mpd7zd/fBanRhahzWN1iXNZHNWCrUec4N TMv0r2xTTC8lLvrKxfTe8yGTGgrEGGtFNRahZ/PvLu4j+4kde7dczl2ykHNuBnm+qgOZ qo+w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E75Csnkx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-137422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id lv23-20020a170906bc9700b00a46bf6e2fa0si4925897ejb.203.2024.04.09.10.48.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 10:48:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E75Csnkx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-137422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C4C9E1F241D3 for ; Tue, 9 Apr 2024 17:48:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B940C156870; Tue, 9 Apr 2024 17:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E75Csnkx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC970156654; Tue, 9 Apr 2024 17:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712684900; cv=none; b=h11J0OPo4WKnpmY/fYk6mxqvnqwq3bPEDb+BC0hDylHoV6gPb4p1JbvYxPuC7Lrp/8yGh1ATsF5dNBFvw2U8JGxG84uyVOMhKNghInjyNXf/zJHEjnScn8/jUE3ajFGzH+lmEUxSUf0GQlspxmfMDfE/gontqsaEFFEtF/tU5bI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712684900; c=relaxed/simple; bh=T1ts7OBezpDX1l3zC/ma8yJQU+ib46TGhv7XGiFfxsw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n7juY0V4DHLQJruXYz1K+aWbIyXaiADbs0kJQAIGUXvJZkfq7QqhRfObDUXZ4S6gESz+zLszEuVwk2z6bOcJtV/zcuMAw9GxW390ju6f5zI5R4jTj+O5Jy62+12QNLYAXHuh40rV+HHcMagpSqu6jcw/iCTvzXYlfn47b1jANLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E75Csnkx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99C5FC433F1; Tue, 9 Apr 2024 17:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712684899; bh=T1ts7OBezpDX1l3zC/ma8yJQU+ib46TGhv7XGiFfxsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E75CsnkxoyKTGMeI3DFPW8gUNblbx8SOICY2Ewjk8kx2VM7HGdJqPbawO6I6uL6yF rw6YpQVkf3KSHGNbGjQ5DupOHzk1IxeRnIGlfQISCTLph3INkoCQuxBwe89fF+SbCS n0iMFIPjIyGH0kHbRVqoM6Zw3ityImCfHpJxph/C5UZb+Yd3Rgk5nIQQEw7sBbVK0c i/jDyEW/CGi2f2txKMAIW+07B6upDwM/11FZmPU3o02ujkxYyZc2z9nl0iPcQeYvMU 1idtnwthACLQCbEZOPl8kph6TrSdDsvlOnmeOWHGJ5nBQq3NxQj7oXqRNaeE2IiYT/ 8fJi4EebacMIA== Date: Tue, 9 Apr 2024 18:48:14 +0100 From: Mark Brown To: Louis Chauvet Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, yen-mei.goh@keysight.com, jeremie.dautheribes@bootlin.com Subject: Re: [PATCH] spi: omap2-mcspi: Ensure that CS is correctly asserted when switching from MULTI mode to SINGLE mode Message-ID: <7a41b650-b135-40cd-bf55-ee4aeea74fe6@sirena.org.uk> References: <20240409-fix-omap2-mcspi-v1-1-f2b881ae196d@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/y6lk1pcp514/q67" Content-Disposition: inline In-Reply-To: <20240409-fix-omap2-mcspi-v1-1-f2b881ae196d@bootlin.com> X-Cookie: I'm also against BODY-SURFING!! --/y6lk1pcp514/q67 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 09, 2024 at 07:25:33PM +0200, Louis Chauvet wrote: > The OMAP2 support features a "multi" mode, where the controller > automatically sets the Chip Select (CS) when necessary. This mode allows > for shorter delays between CS selection and word content, but the CS is > always deasserted at the end. This breaks the build due to updating for modern names, please rebase and resend: /build/stage/linux/drivers/spi/spi-omap2-mcspi.c: In function =E2=80=98omap= 2_mcspi_prepare_message=E2=80=99: /build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1274:17: error: =E2=80=98m= aster=E2=80=99 undeclared (first use in this function) 1274 | master->last_cs =3D -1; | ^~~~~~ /build/stage/linux/drivers/spi/spi-omap2-mcspi.c:1274:17: note: each undecl= ared identifier is reported only once for each function it appears in --/y6lk1pcp514/q67 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYVf10ACgkQJNaLcl1U h9A1Igf/YSzPA9Bx/GW38yBrwUgX9b2IscA1Kc14awzmcWCkn/mmsU3r3VEgF5nE +m5BUKJO8KCdNV2UnCWAyEbVK/YS5YLOohUfvEiI8ubM745yayR58taNl5SqNr1T yUFahLcXtjs/O4s1K0o88qkGwfEv8UaZkVyOPoFTencSMkUEz7k+/pacmZWR8dyY 03TQayRQ3ecIJF0an1hVtvAyIan74VaSNuLZetj1RkwW7RiJXxVFwIoA9plugS0p SSm72iMN584GvGwDb/kvnZNuv4M1PvTpZUKxM7H4Hr2KgIxUy2qWKb629ZHOOSvS 0j3YdrHEayE0BgHtuGmlnHF510laVA== =+E91 -----END PGP SIGNATURE----- --/y6lk1pcp514/q67--