Received-SPF: pass (google.com: domain of linux-kernel+bounces-137400-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240322145406.2613256-1-Frank.Li@nxp.com>
In-Reply-To: <20240322145406.2613256-1-Frank.Li@nxp.com>
From: Rob Herring <robh@kernel.org>
Date: Tue, 9 Apr 2024 12:26:52 -0500
Message-ID: <CAL_JsqLJDhJd_uoL05Z=s3Mc7PRkcJWsQGGjdG0Q0GFp0zA8xw@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] ASoC: dt-bindings: fsl-esai: Convert fsl,esai.txt
 to yaml
To: Frank Li <Frank.Li@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shengjiu Wang <shengjiu.wang@nxp.com>, 
	"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <linux-sound@vger.kernel.org>, 
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>, 
	imx@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 9:54=E2=80=AFAM Frank Li <Frank.Li@nxp.com> wrote:
>
> Convert fsl,esai.txt to yaml. So DTB_CHECK tools can verify dts file abou=
t
> esai part.
>
> clock-names 'spba' is optional according to description. So minItems of
> clocks and clock-names is 3.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>
> Notes:
>     Change from v1 to v2
>     - alphabetical order compatible string according to rob's suggestion
>     - clock description move under 'clock' according to kryszof's suggest=
ion
>     - fix descritpion indent according to rob's suggestion
>
>     Pass dt_binding check
>      make ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- -j8  dt_binding=
_check DT_SCHEMA_FILES=3Dfsl,esai.yaml
>       DTEX    Documentation/devicetree/bindings/sound/fsl,esai.example.dt=
s
>       LINT    Documentation/devicetree/bindings
>       CHKDT   Documentation/devicetree/bindings/processed-schema.json
>       SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>       DTC_CHK Documentation/devicetree/bindings/sound/fsl,esai.example.dt=
b

Did you run dtbs_check too? Probably not arm32 at least (first number
is number of warnings):

    218  esai@2024000: clocks: [[2, 208], [2, 209], [2, 118], [2,
208], [2, 156]] is too long
    218  esai@2024000: clock-names:3: 'spba' was expected
    218  esai@2024000: clock-names:2: 'fsys' was expected
    218  esai@2024000: clock-names:1: 'extal' was expected
    218  esai@2024000: clock-names: ['core', 'mem', 'extal', 'fsys',
'spba'] is too long

Conversions can leave warnings, but any you think should be fixed in
the binding should be fixed in the conversion.

Rob