Received-SPF: pass (google.com: domain of linux-kernel+bounces-137484-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Frank Li <Frank.Li@nxp.com>
To: krzysztof.kozlowski@linaro.org
Cc: Frank.li@nxp.com,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	dmaengine@vger.kernel.org,
	imx@lists.linux.dev,
	krzysztof.kozlowski+dt@linaro.org,
	linux-kernel@vger.kernel.org,
	peng.fan@nxp.com,
	robh@kernel.org,
	vkoul@kernel.org
Subject: [PATCH v3 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property
Date: Tue,  9 Apr 2024 14:54:16 -0400
Message-Id: <20240409185416.2224609-2-Frank.Li@nxp.com>
In-Reply-To: <20240409185416.2224609-1-Frank.Li@nxp.com>
References: <20240409185416.2224609-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?EWERSAPCEi7oPyDXtujqdRBZhvEOPIsWlfFHpjohZP+qb9e8F7l9Xk4X8yh/?=
 =?us-ascii?Q?4suzDOgSfv8766+VWU/o6dTXAu+/MCcM5A9ErArP/FXwQ3zJG0Zi1jjqy6UA?=
 =?us-ascii?Q?0ntAVQJa1zaX3/ctmWcyuCIePMT4/9KLtqr+wTetaOoEoYCE5MG+3fPQgm0D?=
 =?us-ascii?Q?zHQgBUDrrCNDJCTzbbegXcEZTaYfgXURH87LoCkyZUNhs/8z+jtGdUDWVTVg?=
 =?us-ascii?Q?gUXX/KijRFjpitrqKn766kygKHZwHcztn1mPs6VKUXZoan+lDSLWgpJKRXcq?=
 =?us-ascii?Q?jOZyyZAUT/QCuFKpDwiY3SxTkQ9u/jJMgalvU3dQDLfGF9rl58vC6R3awgp+?=
 =?us-ascii?Q?VkudE+kxpq83Y7JmkJ0DU5r3OYUDWk9BQZOqGEqW/YNVZyWRJmkMHUPPGeWF?=
 =?us-ascii?Q?cCNPVCTeuDJkoYPhFPO34FDWOA0KxjJy5FikjOM7cMWD7PZ2BAGnazNK5N07?=
 =?us-ascii?Q?QtT6kHxSdH9+t63n4KANaymo509SNfFmbgzSaVbdhX3+haGhBItQv8qZlJR6?=
 =?us-ascii?Q?z8XTd14JKjb11zkVgWfsfV7KE/XOLYDgViPskdV7won9LF/pFYNH7tECg9Xs?=
 =?us-ascii?Q?tERWY3eNTqEXshUsdgpxboRutm2/frYJ2/7xBxqHZTusjsenenkbDvs9Clmx?=
 =?us-ascii?Q?V2WEuSFPdfEDzoxx3dUOMnHkf8LXD6LCErA22c9uO0p08NmMSQYB3YmMe8mK?=
 =?us-ascii?Q?3UJ49BImEI511NWGCs3Gy4qBc3cIqU9unZVfmnSUA0xQPQc98jafgShZmF4T?=
 =?us-ascii?Q?Te1xUO6cq60N4wmd97zl02dj/64cN2V0uNwDb/rlWGKsSiaUfMkmfUjiCB8K?=
 =?us-ascii?Q?/xURVFpmX+H5NGPMf17kFG2FFgfqIuE2Qc4TI43JBmZ6v8UwsAycOgs6sw52?=
 =?us-ascii?Q?cIz/Dua84MJws7U6OfIAZtXoh8HWLvPI37bLygTiEIPevDVL9QXJcFBg5gz6?=
 =?us-ascii?Q?fXQjIN/twId2o3JdYDXGkkYmTSR3lr60T3TbKCMPLevX6pQDf7BrGRPRnrpu?=
 =?us-ascii?Q?iFZ2tyN0cx7pdTEQheXfU943cLKgUCOz1y2QVDEtTdSjWAoxBhHUBGKPXIqo?=
 =?us-ascii?Q?5jjPyZR6EeC9wUzdwLS2YXSUwQwCPUKbucnkeqgcpUeUquqXC8iKS4p6JNRI?=
 =?us-ascii?Q?ZwxjsmgiLhBh0U4Zrw88VjEqL/9LaJdn2/331fAgZMo3ufivz9VXPEeWN/sE?=
 =?us-ascii?Q?B+bKFJAgZoz6c7P8nmYCQRHQLk751zWMvTssV6qLjm0a30VS0tpicYiiOfJm?=
 =?us-ascii?Q?1BdO7CtuywuY3nEuJh1T6i184c46L5CeoVAgNY+mhu1VDqH8RBQJZMnRnROv?=
 =?us-ascii?Q?2ZfydAs4g988HdlCbq8k/8UMNgK6Jt1zIv/YntCHmp341rt2uaapfhw5kwrp?=
 =?us-ascii?Q?xjtLxNjAhIUOzTCMQxXZZ2EWAmgtj28Ly16g3V49MzTSoSL57VrytQV9BDDI?=
 =?us-ascii?Q?sMu+BgBCh63JFySFHhn2fI4lIHXr1aP2ZS0nQHCohoMrkNLqttAglMKbHxNO?=
 =?us-ascii?Q?cb7LRtr/FvCcA/xX7mGurcKLawdv+eE6uMUbFYG1S0Prv6PFXVhicQo8K8VQ?=
 =?us-ascii?Q?LF2g5ZO9nqlBnroYft4MwstvVtokbZ6QMt+ohjfq?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eaf58f1d-82ef-4fe8-80ba-08dc58c67e03
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 18:54:32.1580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zRYiPMDIHJNg7xjAZZFKPEbo2f+BV0uw3q52+nm+ax593oDWA7gkCi8tu33/VrhbBAw3j4d7CMsE+2GbOAR04w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7673

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
it. EDMA supports each power-domain for each dma channel. So minItems and
maxItems align 'dma-channels'.

Change fsl,imx93-edma3 example to fsl,imx8qm-edma to affect this variants.

Fixed below DTB_CHECK warning:
  dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v2 to v3
    - set 'power-domains' false for other compatitble string
    - change imx93 example to 8qm example to affect this change according to
    Krzysztof Kozlowski's suggestion, choose least channel number edma
    instance to reduce code copy. max channel number is 64.
    
    - Rebase to latest dmaengine/next
    
    Change from v1 to v2
    - using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
    - add power-domains to 'required' when compatible string is fsl,imx8qm-adma
        or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml     | 79 ++++++++++---------
 1 file changed, 40 insertions(+), 39 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
index 657a7d3ebf857..012522612dc96 100644
--- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
@@ -71,6 +71,10 @@ properties:
     minItems: 1
     maxItems: 33
 
+  power-domains:
+    minItems: 1
+    maxItems: 64
+
   big-endian:
     description: |
       If present registers and hardware scatter/gather descriptors of the
@@ -189,7 +193,7 @@ allOf:
   - if:
       properties:
         compatible:
-	  contains:
+          contains:
             enum:
               - fsl,vf610-edma
               - fsl,imx7ulp-edma
@@ -202,6 +206,20 @@ allOf:
       required:
         - clocks
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx8qm-adma
+              - fsl,imx8qm-edma
+    then:
+      required:
+        - power-domains
+    else:
+      properties:
+        power-domains: false
+
 unevaluatedProperties: false
 
 examples:
@@ -257,44 +275,27 @@ examples:
 
   - |
     #include <dt-bindings/interrupt-controller/arm-gic.h>
-    #include <dt-bindings/clock/imx93-clock.h>
+    #include <dt-bindings/firmware/imx/rsrc.h>
 
-    dma-controller@44000000 {
-      compatible = "fsl,imx93-edma3";
-      reg = <0x44000000 0x200000>;
+    dma-controller@5a9f0000 {
+      compatible = "fsl,imx8qm-edma";
+      reg = <0x5a9f0000 0x90000>;
       #dma-cells = <3>;
-      dma-channels = <31>;
-      interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>,
-                   <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
-        clocks = <&clk IMX93_CLK_EDMA1_GATE>;
-        clock-names = "dma";
+      dma-channels = <8>;
+      interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
+                   <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>,
+                   <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH>,
+                   <GIC_SPI 427 IRQ_TYPE_LEVEL_HIGH>,
+                   <GIC_SPI 428 IRQ_TYPE_LEVEL_HIGH>,
+                   <GIC_SPI 429 IRQ_TYPE_LEVEL_HIGH>,
+                   <GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>,
+                   <GIC_SPI 431 IRQ_TYPE_LEVEL_HIGH>;
+      power-domains = <&pd IMX_SC_R_DMA_3_CH0>,
+                      <&pd IMX_SC_R_DMA_3_CH1>,
+                      <&pd IMX_SC_R_DMA_3_CH2>,
+                      <&pd IMX_SC_R_DMA_3_CH3>,
+                      <&pd IMX_SC_R_DMA_3_CH4>,
+                      <&pd IMX_SC_R_DMA_3_CH5>,
+                      <&pd IMX_SC_R_DMA_3_CH6>,
+                      <&pd IMX_SC_R_DMA_3_CH7>;
     };
-- 
2.34.1