Received-SPF: pass (google.com: domain of linux-kernel+bounces-137513-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-379-gabd37849b7-fm-20240408.001-gabd37849
Precedence: bulk
MIME-Version: 1.0
Message-Id: <1f2e1994-408a-41d3-9b0b-a08d9478e8b8@app.fastmail.com>
In-Reply-To: <20240409162521.GB3219862@dev-arch.thelio-3990X>
References: <20240404151713.3493098-1-arnd@kernel.org>
 <20240404151713.3493098-2-arnd@kernel.org>
 <20240409162521.GB3219862@dev-arch.thelio-3990X>
Date: Tue, 09 Apr 2024 20:42:23 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Nathan Chancellor" <nathan@kernel.org>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Masahiro Yamada" <masahiroy@kernel.org>,
 "Nicolas Schier" <nicolas@fjasle.eu>, linux-kbuild@vger.kernel.org,
 linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 1/4] kbuild: turn on -Wextra by default
Content-Type: text/plain

On Tue, Apr 9, 2024, at 18:25, Nathan Chancellor wrote:
> On Thu, Apr 04, 2024 at 05:16:54PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>
> I have not done any LLVM builds with this change but if this is going to
> be in -next for a little bit, we should be able to get any regressions
> handled quickly.
>
> I am in favor of more warnings but I am a little nervous this will make
> compiler upgrades (or tracking their mainline) even more difficult. I do
> not have a feeling for how often warnings are added to -Wall and -Wextra
> so this may be unfounded but the kernel's -Werror use complicates this
> in my opinion. I can engage with the clang folks to try and be given a
> heads up when a warning is going to be added to -Wextra, it would be
> good to have someone do something similar for GCC, so that those
> upgrades do not cause something like this change to be rolled back.

My impression is that most new warnings get added to -Wall rather than
-Wextra anyway. If they are added to -Wextra, it's still easy enough
to turn them off individually unless W=1 is set.

> It is easy enough to back out of this if necessary though, so:
>
> Acked-by: Nathan Chancellor <nathan@kernel.org>

Thanks!

     Arnd