Received-SPF: pass (google.com: domain of linux-kernel+bounces-137629-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 9 Apr 2024 17:09:14 -0400
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	dmaengine@vger.kernel.org, imx@lists.linux.dev,
	krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
	peng.fan@nxp.com, robh@kernel.org, vkoul@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from
 required
Message-ID: <ZhWuetC8bRvDyxgX@lizhi-Precision-Tower-5810>
References: <20240409185416.2224609-1-Frank.Li@nxp.com>
 <b15ad271-037e-4ee3-ad88-e8068d31c8c8@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b15ad271-037e-4ee3-ad88-e8068d31c8c8@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?plDyUr8EggZ3upl7de4T55lnUavc7BY4w+qB0DtQwViduHFFtb5rLuD/Di9n?=
 =?us-ascii?Q?IpEfUSqH3FLqDvauaAnBnDvMDdqWlfzNcAuT0NndafZ/7dm/eFYzdV/9WHek?=
 =?us-ascii?Q?sEZBmAkne6V2Xtz/MxiqqXweOanQgkkU6zLmIO0Oxd64mQii2G7D85AB79KC?=
 =?us-ascii?Q?CoqHfKDxQ2rYoDP/VSaaIAp+ahPX6sXR91/S+KsFYE0VqvAgvKZf6cYsCpGE?=
 =?us-ascii?Q?KBWU3luuWSr55TkMDED4Hvy6+H1/UNHMG3FioLMCFaumnpzIc1zOsV4wH2MO?=
 =?us-ascii?Q?2kApnmMqE8RxSqqS6P9NYW1SNOhUkKP7z1srImgogQ1a4zaULFo96CfdaYu4?=
 =?us-ascii?Q?4pJOwEu0ZlvWqgKsTxn4JrnUWDai+bqVA41Wmh/oXKIZYGcUvXwikOgF7Zk/?=
 =?us-ascii?Q?SiMSV1+jGpNDw/lMKVd/WcmfKhXdvyQQItfNAGWncHD8KOSZk3cr6iDALB30?=
 =?us-ascii?Q?JV8M68VqGu3l+KnQLdUOcTXBvZpnIe/w3EipjYY+OZmGwuEs11xp2NF42VVO?=
 =?us-ascii?Q?dpWHHl6jEiAjGbHbwteX0xovc+XD9WlD5tcRcDfBeL6dFN0fe8o11+ukUSHF?=
 =?us-ascii?Q?mQLQH3MBNLNAA6TRNjMj/bfLVNjJsqD1q+3BF/4t+aUFeNGvgl+/sog8fgby?=
 =?us-ascii?Q?k1x2ImNgmUbHAecjbLotR/gcXf04yzoPFrsQ6u41Tb3r2u6r2BNZopy2mxM3?=
 =?us-ascii?Q?MpMLGnDku6pHN06ZzoQmsuHjllIVhiBpNyLULumS9I5QNnXqL5zXQgNbldB1?=
 =?us-ascii?Q?by6TCyceJvpepOvI7qaLgZO6I1XFKefuRpjCAnmb/Vwlmf+HoEzcy9DZvIrz?=
 =?us-ascii?Q?WKokKQE8wH2wjOFmHfzrfLhof7okDn8R06dIKjUYfNFGCDYXzvn3LGClhFA8?=
 =?us-ascii?Q?/4lc0yy32eY9yC85hY5lYwv1OlIBtlFvvXVaMQ9I7971yR9jkrPiX2q+2P3M?=
 =?us-ascii?Q?+bq/FWzw7japFjSbklTqIT2IPqeYD05+ATsed1j4BJEtsXZ1o8vFGVcoMP/b?=
 =?us-ascii?Q?MjYuDENdpF17vdAHXVYEziZ9P8cbj6YzDMHM38ATOb8+4wHeRkcV5Skn6fri?=
 =?us-ascii?Q?zBhSIAXPkjYFa3IeuNTlYXPwOCYzFTDF1Vb5xqWAT4fGBuCMOZ8j4osNb4lT?=
 =?us-ascii?Q?OIyqQiSGYouXUAfcJBKEHEK3b8kxXgXtGskNTpRNxkN1WNViou5ZleOMyeLm?=
 =?us-ascii?Q?6bIkvIX3lB4pnlqZRyWVEOnzHuEGEofQLEvrcL2RJA/T8eP00qbNxVF39yzg?=
 =?us-ascii?Q?fYkesP0bG0YitYfQ4dH2lGLMmBwGKPNljrJLyLIc/VlfSL/a0XhPyYnHQzSy?=
 =?us-ascii?Q?QDFdYdE9ZOnVLiTScyrlmCCaPPVujW9/g08ka7mf9H8oxpoC7MmraUz5t6BW?=
 =?us-ascii?Q?ZcWV2DKyl6D7VE375Lp7OSdoD5PldnnhWsoHENs3DlpKxROETUX2Mg8/gv/P?=
 =?us-ascii?Q?upKoI1Kt6hGO+TNMRhqzFiEvEN/tdLwA7s11H6Q3Rd1GD9wnAXOnjT7CUMQT?=
 =?us-ascii?Q?FZEK10X+7UrBQMPeLMM5NH11fRGXwK3U58L51NPv9dY3wLBIxGzv/DS5Gw4u?=
 =?us-ascii?Q?v8OcKNwb0seAeE6Pf+g=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe136f2c-050e-492f-4e34-08dc58d953ba
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 21:09:21.6910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Og21lrFMeAEb1w0BkWiiOIw9ganaN91fujG1vDdFfM5bHT5C72nOewyDmZp+TL/7/9nI2/8Bwzto5hpA+2aWtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7674

On Tue, Apr 09, 2024 at 10:02:32PM +0200, Krzysztof Kozlowski wrote:
> On 09/04/2024 20:54, Frank Li wrote:
> > fsl,imx8qm-adma and fsl,imx8qm-edma don't require 'clocks'. Remove it from
> > required and add 'if' block for other compatible string to keep the same
> > restrictions.
> > 
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > 
> > Notes:
> >     Change from v2 to v3
> >       - rebase to dmaengine/next
> 
> This fails...

What's wrong? 

https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/log/?h=next

> 
> > 
> > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > index 825f4715499e5..657a7d3ebf857 100644
> > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> > @@ -82,7 +82,6 @@ required:
> >    - compatible
> >    - reg
> >    - interrupts
> > -  - clocks
> >    - dma-channels
> >  
> >  allOf:
> > @@ -187,6 +186,22 @@ allOf:
> >          "#dma-cells":
> >            const: 3
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +	  contains:
> 
> It does not look like you tested the bindings, at least after quick
> look. Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.

Strange, Test passed

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,edma.yaml
  LINT    Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/dma/fsl,edma.example.dts
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  DTC_CHK Documentation/devicetree/bindings/dma/fsl,edma.example.dtb


> 
> Best regards,
> Krzysztof
>