Received-SPF: pass (google.com: domain of linux-kernel+bounces-137664-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 9 Apr 2024 18:23:33 -0400
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza <jose.souza@intel.com>,
	<gregkh@linuxfoundation.org>
CC: <linux-kernel@vger.kernel.org>, <intel-xe@lists.freedesktop.org>, "Mukesh
 Ojha" <quic_mojha@quicinc.com>, Johannes Berg <johannes@sipsolutions.net>,
	Jonathan Cavitt <jonathan.cavitt@intel.com>
Subject: Re: [PATCH v4 1/2] devcoredump: Add dev_coredump_put()
Message-ID: <ZhW_5Yctai75qvT2@intel.com>
References: <20240409200206.108452-1-jose.souza@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240409200206.108452-1-jose.souza@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?bVqy1OZ51i/BXEZyZXwmn3VSFBjR+V5MQTsb4cRbQGaUpB9JH0xamy350z?=
 =?iso-8859-1?Q?719JzcyQwvoq2N5qdtKR36HF5m4f861yhyBfC9gBr8LV3xGFxoowQGvCNC?=
 =?iso-8859-1?Q?Yk7EoC35GwuYD+32uorSzQ1ukD5oeg7LwkQOXZ+fnt4dhaaaV5ltPiV3xI?=
 =?iso-8859-1?Q?mFsRA24y6JIgOr1BrNAOLIjvuOilDjAyItCyXDhUAegL25s/LIhKnuwxSR?=
 =?iso-8859-1?Q?lT84ITBh+snDzGYoUs2fwG4NHpFRkmjkD6ryJGw4N98woj2oh3tX07Ojbv?=
 =?iso-8859-1?Q?+oLJmgVTaOKNzHTaeZeXg0439XljS+sEiHDofbtIiQQJbnkyKTfGEtgHXi?=
 =?iso-8859-1?Q?db0PI5LdZMPUIASqw1HJuaIjPzCjCs0c8KVPwCuZVffC413Opm9jrzC9pY?=
 =?iso-8859-1?Q?X3H7x5wCtp7OC7swUSxwb6fNWwdwi47vaw2m26dbvVuvbAjHRkLG8SH+nD?=
 =?iso-8859-1?Q?zamsJfYBg/Fpo45W6TdCH4xc4b0aqI5VfGpVgf2hlCuc0lkoLqZkNivCV0?=
 =?iso-8859-1?Q?qrD8JJz65Nbi7GcFTrZRF668BYPemP/CgB+WyJoqCZ9rBFRFgsVnhVjsux?=
 =?iso-8859-1?Q?E03nTCb3WiEjxvqFzbaAlGJlAYwy8hiz02TJQ6UmR6XIirbf8dxpWMdIfP?=
 =?iso-8859-1?Q?zDph227QBR0B8eOD+a2ebndGYn4eX9y9RaRRfgyIYLBcx7+BnM4JfoQJ9S?=
 =?iso-8859-1?Q?opUe2nnZqlWXP5b5So++PKlXfE8gK+EYGs75Fq6zHY7/KJYDdGYDhH7fDK?=
 =?iso-8859-1?Q?8wwehLU3ysAKP1RyqLeyktpyEfc9X6dgI9e0W+dd0AYnXwu9MlUeTXetbi?=
 =?iso-8859-1?Q?q0j4G2MJcKEiRCTB4buugWgH5mQJFOmSooS2jCWOI4LIHZvcwHQYEoIrfC?=
 =?iso-8859-1?Q?gs2SFyskoqkSluJ/QdbKFHUEkREymzbZSNYSx8JD84CAVWazIefOLOlvEJ?=
 =?iso-8859-1?Q?XKRCwcmSUFqzPieC7qSTSepuF76TVLRgh4rMPMLr2FAw5WO9uEUPuFf55Y?=
 =?iso-8859-1?Q?WmriBPA0JXPHY846tRkddTS0FNQK5CMHbAJjVoAEg939nciVdyvhVO3ymZ?=
 =?iso-8859-1?Q?EJXhHn0muMCPveJN6iK6R9Xen+UcJi0JgJwvkRTd2DSw/XHiTYYLq0GjUd?=
 =?iso-8859-1?Q?n0LdP7OUevDDYz6X509QSjx6UXE26C7e1/jwqvPeRdUZ0/UkOcG/dYOuz0?=
 =?iso-8859-1?Q?dDTbXMci+eRV9e1dUaU7EgtrBb5lEsNhm5lxwLJM6DR9q0vKJT910ZD+mK?=
 =?iso-8859-1?Q?TxbjT4LOO9rn7QX3Ho++5wraLx1U/1rTp2I8N83E74Ide+yJdmQlymiqTk?=
 =?iso-8859-1?Q?zHoOTchUdVHTJi9uKPPrDRLYesPLkelFtIYq1qmaoc+e2b0VE6QsOP9bhf?=
 =?iso-8859-1?Q?V8yKc5/OXZCEScz3XZn0thTV5P5745/EeBdqrlx5J4IlHV8FqTFtRcQ76W?=
 =?iso-8859-1?Q?fOpk4UGuca+RIc8WRUouBOjgPs1g+A0R6S8iVfVt3+jJsrFZKvc84maK0Y?=
 =?iso-8859-1?Q?SX6Qjx0eVmS70efWKCr+p1mtXYDiUOG6eayhv3HD7cJPYz73bLQ6VO+S9+?=
 =?iso-8859-1?Q?86MQhNvvcaaiC31YbXUzEdP4mgZVHfQ6e1mWgowrdc2p4yjtQxW6LTRM7h?=
 =?iso-8859-1?Q?uPJavHzJJygk5+8roqEVwK/1DhEqpLNRqcq3r2PI+eE82bmw9cKN2sEw?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f8b344d4-9339-40e9-6c37-08dc58e3b47c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 22:23:39.0051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nKlMdxoO8KIaKKdvRZo0HG6fPeGdeICiTZaGUIGBCfB9azm2ytjqhHyWpTOkNdGHm+pFWk9c0d84HwzLPHRAiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7098
X-OriginatorOrg: intel.com

On Tue, Apr 09, 2024 at 01:02:05PM -0700, Jos? Roberto de Souza wrote:
> It is useful for modules that do not want to keep coredump available
> after its unload.
> Otherwise, the coredump would only be removed after DEVCD_TIMEOUT
> seconds.
> 
> v2:
> - dev_coredump_put() documentation updated (Mukesh)
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Mukesh Ojha <quic_mojha@quicinc.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> Acked-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Signed-off-by: Jos? Roberto de Souza <jose.souza@intel.com>

Greg, can I have you ack to merge this through the drm-next?

> ---
>  drivers/base/devcoredump.c  | 23 +++++++++++++++++++++++
>  include/linux/devcoredump.h |  5 +++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c
> index 7e2d1f0d903a6..82aeb09b3d1b5 100644
> --- a/drivers/base/devcoredump.c
> +++ b/drivers/base/devcoredump.c
> @@ -304,6 +304,29 @@ static ssize_t devcd_read_from_sgtable(char *buffer, loff_t offset,
>  				  offset);
>  }
>  
> +/**
> + * dev_coredump_put - remove device coredump
> + * @dev: the struct device for the crashed device
> + *
> + * dev_coredump_put() removes coredump, if exists, for a given device from
> + * the file system and free its associated data otherwise, does nothing.
> + *
> + * It is useful for modules that do not want to keep coredump
> + * available after its unload.
> + */
> +void dev_coredump_put(struct device *dev)
> +{
> +	struct device *existing;
> +
> +	existing = class_find_device(&devcd_class, NULL, dev,
> +				     devcd_match_failing);
> +	if (existing) {
> +		devcd_free(existing, NULL);
> +		put_device(existing);
> +	}
> +}
> +EXPORT_SYMBOL_GPL(dev_coredump_put);
> +
>  /**
>   * dev_coredumpm - create device coredump with read/free methods
>   * @dev: the struct device for the crashed device
> diff --git a/include/linux/devcoredump.h b/include/linux/devcoredump.h
> index c008169ed2c6f..c8f7eb6cc1915 100644
> --- a/include/linux/devcoredump.h
> +++ b/include/linux/devcoredump.h
> @@ -63,6 +63,8 @@ void dev_coredumpm(struct device *dev, struct module *owner,
>  
>  void dev_coredumpsg(struct device *dev, struct scatterlist *table,
>  		    size_t datalen, gfp_t gfp);
> +
> +void dev_coredump_put(struct device *dev);
>  #else
>  static inline void dev_coredumpv(struct device *dev, void *data,
>  				 size_t datalen, gfp_t gfp)
> @@ -85,6 +87,9 @@ static inline void dev_coredumpsg(struct device *dev, struct scatterlist *table,
>  {
>  	_devcd_free_sgtable(table);
>  }
> +static inline void dev_coredump_put(struct device *dev)
> +{
> +}
>  #endif /* CONFIG_DEV_COREDUMP */
>  
>  #endif /* __DEVCOREDUMP_H */
> -- 
> 2.44.0
>