Received: by 2002:ab2:687:0:b0:1f4:6588:b3a7 with SMTP id s7csp97107lqe; Tue, 9 Apr 2024 16:09:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVTEg5/gFKvFRDJJeXgT1mg0KUh5F8pl2fkeR75n3xo0ZtRoR0nhSxcQ+RmMIBD6RyWuzfuHqO8jx5Hy7Y88/xtFn5f7cc/ltp1w9w/3g== X-Google-Smtp-Source: AGHT+IG/2UjEhnFeQNi8xJ/SmvkJCkhR0owpGczTil/YLIdAXxOGEpqRtuPpPoTU14QZVL9Undsq X-Received: by 2002:a05:6e02:1cac:b0:36a:356d:7765 with SMTP id x12-20020a056e021cac00b0036a356d7765mr1295620ill.3.1712704170296; Tue, 09 Apr 2024 16:09:30 -0700 (PDT) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q14-20020a63e20e000000b005dc4a68d52esi9448413pgh.878.2024.04.09.16.09.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 16:09:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137685-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=eCSlAEXM; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-137685-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137685-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 52F762824C2 for ; Tue, 9 Apr 2024 23:09:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 84BD8158DB1; Tue, 9 Apr 2024 23:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eCSlAEXM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75C13158D95; Tue, 9 Apr 2024 23:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712704162; cv=none; b=TuldzEoBiz31a0NWHijPycLQSm38TVJoNsInpm9DTS1ttS+SU8cu+3F0b/Qklb8/Doi5nRQqhOmU5/ZdT6EBVUDXkkw/srs9MhMZuo5YKcz/MmrueQzQ+D+Zr2FCcAYc2t28jaCKVjiqGtGvFbwKz0pymfW1dURpzWuMl5IVt/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712704162; c=relaxed/simple; bh=44f1BURDVDavtHs5VgCDimxWZS2jWuTMtVWaaTmGnks=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fGW8WDUBUbzXdHdgXsXPNXuQIAEQLnITUEWAr0nwApZqi8jKcmV6nHPmq8q5njhRj0QTHsI3voFksOsBoII5WvREWmzM5lTEmry+u4zdIvkB5b1Rq17/Z/HRomOWClzMl0fyxX7aDnsmmkvgx1L8R/jmvp1icpmK7E9cva2yR9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eCSlAEXM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADDD7C433F1; Tue, 9 Apr 2024 23:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712704162; bh=44f1BURDVDavtHs5VgCDimxWZS2jWuTMtVWaaTmGnks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eCSlAEXMyKvNcSJxudd6yoYMUYQ1HJHm298Ahmq93A2l00Mt63iOwFmxr2YoaLzo2 2Vx1pMf1s+fzRX6MQH8NXMfRrlhB7ITaGx4WrZsorSyfXYLRInSJ5zc7M7Ng0Xlvau hpBWlVcBDLvsaLfU4vm0G/8gSmfRuD/KE9Li9UtNJ/nLNoPkv4xosoWlEXS1SEwVlm GsDlkPQpH8UngBnFA/utF5K2r1YTl9q5GIq6Pc0fWjQx3zV8mWuhT78G8iFTokZ+7+ UUrQe6ZXl2rG07kwq0IG10r3o0HUhoNh/Qtg9ihkc5zoATkEiAFS0/vJsWLw2OlY7f xUiFRqESA56gA== Date: Tue, 9 Apr 2024 16:09:20 -0700 From: Jakub Kicinski To: Sean Christopherson Cc: Kees Cook , Shuah Khan , Nathan Chancellor , linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: kselftest_harness: Print empty string, not empty fmt on PASS/FAIL Message-ID: <20240409160920.3bfe3eeb@kernel.org> In-Reply-To: <20240409224256.1581292-1-seanjc@google.com> References: <20240409224256.1581292-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 9 Apr 2024 15:42:56 -0700 Sean Christopherson wrote: > - ksft_test_result_code(t->exit_code, test_name, > - diagnostic ? "%s" : "", diagnostic); > + ksft_test_result_code(t->exit_code, test_name, "%s", diagnostic); Have you tested that to make sure it doesn't change the output? . warning: ^^ leading question ;)