Received-SPF: pass (google.com: domain of linux-kernel+bounces-137700-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 9 Apr 2024 19:36:50 -0400
From: Eric Biggers <ebiggers@kernel.org>
To: Stefan Kanthak <stefan.kanthak@nexgo.de>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	ardb@kernel.org
Subject: Re: [PATCH 1/2] crypto: x86/sha256-ni - convert to use rounds macros
Message-ID: <20240409233650.GA1609@quark.localdomain>
References: <20240409124216.9261-1-ebiggers@kernel.org>
 <20240409124216.9261-2-ebiggers@kernel.org>
 <C0FA88ECA90F43B1BF9E7849C53440D7@H270>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <C0FA88ECA90F43B1BF9E7849C53440D7@H270>

On Tue, Apr 09, 2024 at 06:52:02PM +0200, Stefan Kanthak wrote:
> "Eric Biggers" <ebiggers@kernel.org> wrote:
> 
> > +.macro do_4rounds i, m0, m1, m2, m3
> > +.if \i < 16
> > +        movdqu  \i*4(DATA_PTR), MSG
> > +        pshufb  SHUF_MASK, MSG
> > +        movdqa  MSG, \m0
> > +.else
> > +        movdqa  \m0, MSG
> > +.endif
> > +        paddd   \i*4(SHA256CONSTANTS), MSG
> 
> To load the round constant independent from and parallel to the previous
> instructions which use \m0 I recommend to change the first lines of the
> do_4rounds macro as follows (this might save 1+ cycle per macro invocation,
> and most obviously 2 lines):
> 
> .macro do_4rounds i, m0, m1, m2, m3
> .if \i < 16
>         movdqu  \i*4(DATA_PTR), \m0
>         pshufb  SHUF_MASK, \m0
> .endif
>         movdqa  \i*4(SHA256CONSTANTS), MSG
>         paddd   \m0, MSG
> ...

Yes, your suggestion looks good.  I don't see any performance difference on
Ice Lake, but it does shorten the source code.  It belongs in a separate patch
though, since this patch isn't meant to change the output.

- Eric