Received-SPF: pass (google.com: domain of linux-kernel+bounces-137733-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e60c4a55-09bb-4bd7-a22c-9ab38bea174c@intel.com>
Date: Tue, 9 Apr 2024 16:51:50 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW
 Ethernet driver
To: Julien Panis <jpanis@baylibre.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Russell King
	<linux@armlinux.org.uk>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann
	<daniel@iogearbox.net>, Jesper Dangaard Brouer <hawk@kernel.org>, "John
 Fastabend" <john.fastabend@gmail.com>, Sumit Semwal
	<sumit.semwal@linaro.org>, =?UTF-8?Q?Christian_K=C3=B6nig?=
	<christian.koenig@amd.com>, Simon Horman <horms@kernel.org>, Andrew Lunn
	<andrew@lunn.ch>, Ratheesh Kannoth <rkannoth@marvell.com>, "Naveen
 Mamindlapalli" <naveenm@marvell.com>
CC: <danishanwar@ti.com>, <yuehaibing@huawei.com>, <rogerq@kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<bpf@vger.kernel.org>, <linux-media@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <linaro-mm-sig@lists.linaro.org>
References: <20240223-am65-cpsw-xdp-basic-v8-0-f3421b58da09@baylibre.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240223-am65-cpsw-xdp-basic-v8-0-f3421b58da09@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUwxS0I5bktPb2ROZTl5UkZyeStZcHZFS3g3SkVOZzlkNHY3UEJEZTcyd01w?=
 =?utf-8?B?QkgvcW16bnZIMVg5NWlucDVqQlFGMDNCaks3c2VNQVBnN295MzVuakgwM0Fi?=
 =?utf-8?B?UStTRG4xTFk4dHpKV3NQV2dPa09JMmFjc1FNWDFoWVhxNDIwaW1lUVJZbUlt?=
 =?utf-8?B?V3hxS3M1UEZsRFROMTZybG5zS21RUDRkd0FubUx1UmkwT3BRZ1VvOUg5NUow?=
 =?utf-8?B?NHR5TlBiZHRNTDVheWE2S2ZMZVdwQytyYXh2cFNrT09LZzN1YkdFMkppVWhR?=
 =?utf-8?B?ZVN1Y0ZQOHp3Nkpsa0hlT1pGQXNVay9TYUFDbTQ3eHVBMXlKMHhLQmNXUWE3?=
 =?utf-8?B?S1hJVlFqR0dMUGRZUjZVd2FEdU4xRXEyc1REcmYvOWxWYVFqSHI1dVlpV3o3?=
 =?utf-8?B?UFRxa2NGamxYZEw3aG1BbFVqb3R3Q1NURkg4T3ZIYWxYcUkzZllkd1JuQUR6?=
 =?utf-8?B?YUY0dldMMWF1VHByRXQwNldpZndGZ2c2anJIQm1ZTFNiRFE4cU9jRmMwaDlm?=
 =?utf-8?B?UjRaTngxYnVDZ04zU0ZMOXBkUHlCWHNZS1haMEhsNk43TVRDdDdwcXJOMnYz?=
 =?utf-8?B?WlVLRURBVHpIWVNYK3hZbEJuRmIvTjRBWlNPZ0N6WnZKeG4vWlp0ZWRzWEly?=
 =?utf-8?B?cXlYa3JmSTFhUkNXOWlOaUNMQWxrRWRSNk5iVjk3RUhPMksyODlqWnIyUUov?=
 =?utf-8?B?WVJLS3dmV2Y1eE91TUt1akJJemVlTEk2d3JUQlFVOCszZG50SWV1cjJUdGxq?=
 =?utf-8?B?OE9KNzVON09ld1VUTjQ1ZUlreTJmcURpOERpRG1mU292dVdsY0RYQldEUE12?=
 =?utf-8?B?R3JDcVVIVHBtUDF0RXRvam83RGxkSU9FQ2xkVnhGRXNqOHd4NmNoQ0E3aDFa?=
 =?utf-8?B?U2hJK0ZYUUVqdU9xdWgxdUFLYUNQQy9hRzNFYUorR09hMHZaTWpGaWdRVTZK?=
 =?utf-8?B?RUplYUZ6d2s2RXg2b21JSm00RXlBbzVxZUFiSm9xTlZFdlNiZDVybVFBQ2Jv?=
 =?utf-8?B?R1dRMkYweGZoUnZ4cXBxNlhXNnAweHpqcWJ2WHQxYmFPb3VkUlBLc3FHQy9a?=
 =?utf-8?B?L2R6aFRpRGJWcjFWbkFGS2pUZW54b2Z1V0VzYkphL05ibEQvVjVySk9XTFEz?=
 =?utf-8?B?SkVWTmdtbmx2STk3V216RXc5bHdXVXRlc2tPakVQN3NxYnoxMFF5VlNpMkUz?=
 =?utf-8?B?T3hzYXZKZU1zZU0wOG1TalFWWkk0djFqandNVUVFYWlaR1hRMm5Kck1IUHg3?=
 =?utf-8?B?YTdhRU5KWXdXMk52MmRBb2J3Q2FMekVkOG5wamVGSXN4bys2Ly9hejZXTGJD?=
 =?utf-8?B?S3dmUU5UOUpZTXNhbWh6UHNjS29QMmtIWjlHMXVqcGIzQ1djdStEYUFqcWdO?=
 =?utf-8?B?UUtZK3NyTUMzWHkvSzNWQWNBcUVDYnIxRDhDM0hMdHZWd0lyZ1o1OVZYOUdJ?=
 =?utf-8?B?b2lnaEJ1WXpvNGE3MVlHZDZydG5OVlIxYjVjRDMzeUZhUFlpdmdpS1haSGRT?=
 =?utf-8?B?Ni80c3NHUTZXUjJESlBTU1doZVFJMlZTNHoza2FmcjVhbFR5MUNLSGFlbmIz?=
 =?utf-8?B?eFhFMmJkWWdWdlI3eitEVTJtZ0hHbENXaVBiTWVlcGNpdWNNc2w2amF5Sjd0?=
 =?utf-8?B?MkE0U25EZndlSCtuNUdRQWxnNUxwMTlqbUpac2RVL1FScGpFaHlLWUw2a3M4?=
 =?utf-8?B?THZLK2F1am02UGNYa3dkZjJDTWpYTUR3Vy9qb2p5cUhIdWZFb2xQbUNyS1ha?=
 =?utf-8?B?T0ZVMXRQTFVVSllhd2Q1Zmc2RFBBWWw0T1hMS3FGd0ZXaEVxMERuWkVNY0pP?=
 =?utf-8?B?TnZmRGUwcjFncURrUVp0OU44SmtrRlNKN2hPaGdpdHF4NFBkUjl0TjNTWWd3?=
 =?utf-8?B?eHlVUDFYZzJGUjV6QXpLWlljYU11VHJma0EvOGRKamxFNk1FQnVESnM4MzdY?=
 =?utf-8?B?UlJkL082aFhmUHdsZTV5TWhKL1NaUFpVRUQ5ZVR1OUk4QXNTQm9zQ1piUFhz?=
 =?utf-8?B?YlkyVDBLdHdXS0MrV1FKVzE2c3N0VU1DdzBYSXdQbmVsZnJqaG1LVDdSaktz?=
 =?utf-8?B?ditKYThJbmdrTkljeE80QmloaHYzd3YzRzFNa1JJRVMvdm5KK1psZDFTQ05W?=
 =?utf-8?B?eGhLTVByWnJSOGtUNy96K2hEcnZ3ZFVULzRZbkNsVStLdWx4d2JNTWVCa0N5?=
 =?utf-8?B?OGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 55cff187-760e-4815-aed3-08dc58f008e1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 23:51:54.4844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jxlrdkJJ7vQsUOzGkYYO2REn4RaH7HO6Qc3W13hHPFw+etu+5am3deqHy4pmZs8P7tq08n6RyGxS+46pJ2LxeydtnzKOUpQqBj1fWnyVf2c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6945
X-OriginatorOrg: intel.com


On 4/8/2024 2:38 AM, Julien Panis wrote:
> This patch adds XDP support to TI AM65 CPSW Ethernet driver.
> 
> The following features are implemented: NETDEV_XDP_ACT_BASIC,
> NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT.
> 
> Zero-copy and non-linear XDP buffer supports are NOT implemented.
> 
> Besides, the page pool memory model is used to get better performance.
> 
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Changes in v8:
> - Fix some warnings reported by patchwork.
> - Link to v7: https://lore.kernel.org/r/20240223-am65-cpsw-xdp-basic-v7-0-c3857c82dadb@baylibre.com
> 
> Changes in v7:
> - Move xdp_do_flush() function call in am65_cpsw_nuss_rx_poll().
> - Link to v6: https://lore.kernel.org/r/20240223-am65-cpsw-xdp-basic-v6-0-212eeff5bd5f@baylibre.com
> 
> Changes in v6:
> - In k3_cppi_*() functions, use const qualifier when the content of
> pool is not modified.
> - Add allow_direct bool parameter to am65_cpsw_alloc_skb() function
> for direct use by page_pool_put_full_page().
> - Link to v5: https://lore.kernel.org/r/20240223-am65-cpsw-xdp-basic-v5-0-bc1739170bc6@baylibre.com
> 
> Changes in v5:
> - In k3_cppi_desc_pool_destroy(), free memory allocated for desc_infos.
> - Link to v4: https://lore.kernel.org/r/20240223-am65-cpsw-xdp-basic-v4-0-2e45e5dec048@baylibre.com
> 
> Changes in v4:
> - Add skb_mark_for_recycle() in am65_cpsw_nuss_rx_packets() function.
> - Specify napi page pool parameter in am65_cpsw_create_xdp_rxqs() function.
> - Add benchmark numbers (with VS without page pool) in the commit description.
> - Add xdp_do_flush() in am65_cpsw_run_xdp() function for XDP_REDIRECT case.
> - Link to v3: https://lore.kernel.org/r/20240223-am65-cpsw-xdp-basic-v3-0-5d944a9d84a0@baylibre.com
> 
> Changes in v3:
> - Fix a potential issue with TX buffer type, which is now set for each buffer.
> - Link to v2: https://lore.kernel.org/r/20240223-am65-cpsw-xdp-basic-v2-0-01c6caacabb6@baylibre.com
> 
> Changes in v2:
> - Use page pool memory model instead of MEM_TYPE_PAGE_ORDER0.
> - In am65_cpsw_alloc_skb(), release reference on the page pool page
> in case of error returned by build_skb().
> - [nit] Cleanup am65_cpsw_nuss_common_open/stop() functions.
> - [nit] Arrange local variables in reverse xmas tree order.
> - Link to v1: https://lore.kernel.org/r/20240223-am65-cpsw-xdp-basic-v1-1-9f0b6cbda310@baylibre.com
> 
> ---
> Julien Panis (3):
>       net: ethernet: ti: Add accessors for struct k3_cppi_desc_pool members
>       net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool
>       net: ethernet: ti: am65-cpsw: Add minimal XDP support
> 
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c    | 569 +++++++++++++++++++++++++---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.h    |  13 +
>  drivers/net/ethernet/ti/k3-cppi-desc-pool.c |  41 ++
>  drivers/net/ethernet/ti/k3-cppi-desc-pool.h |   6 +
>  4 files changed, 578 insertions(+), 51 deletions(-)
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240223-am65-cpsw-xdp-basic-4db828508b48
> 
> Best regards,