Received-SPF: pass (google.com: domain of linux-kernel+bounces-137737-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5dfe587e-b868-4066-8597-63cc3578e928@intel.com>
Date: Tue, 9 Apr 2024 16:56:08 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 1/3] net: make napi_frag_unref reuse
 skb_page_unref
To: Mina Almasry <almasrymina@google.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Ayush Sawal <ayush.sawal@chelsio.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jesper Dangaard Brouer
	<hawk@kernel.org>, Ilias Apalodimas <ilias.apalodimas@linaro.org>, "Steffen
 Klassert" <steffen.klassert@secunet.com>, Herbert Xu
	<herbert@gondor.apana.org.au>, David Ahern <dsahern@kernel.org>, "Boris
 Pismenny" <borisp@nvidia.com>, John Fastabend <john.fastabend@gmail.com>,
	Dragos Tatulea <dtatulea@nvidia.com>
References: <20240408153000.2152844-1-almasrymina@google.com>
 <20240408153000.2152844-2-almasrymina@google.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240408153000.2152844-2-almasrymina@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2t2YWJkaTFQbXhWc1hUK2VvNm5NUmFLQ3g5YVJIU3VOSHp0NnlmaTJiT09J?=
 =?utf-8?B?elA2bDRoQkZUeHlMM3VkU0ZXT2wrY0VkM3dQTUhqTEtFM3B4anIwU2JnT3hl?=
 =?utf-8?B?OHBIK25GVGgrWnVGZTZiUmNvQ2lmSjNNUStyWjliZ1ZrZTZldUw1cVdaeS9S?=
 =?utf-8?B?NkVBeGMvUVloN3dZYldRbEEzZW1OWkI2eVcwQ3NzR1ZHNDdmb09acFhybnpt?=
 =?utf-8?B?bnVCMGRiV3RYc1dPVFY0eWw2eDMwL2hhYUdBcXUzb284OGhTdzcwSmVCQmFK?=
 =?utf-8?B?UkFiMFR2SUFjcGFrMTVzTmFXaWRQT3NPbHRsMEZzK2wyR0xDbU5IY2NNalB5?=
 =?utf-8?B?RHFZWU5vOG8xdVFZeUpiR1JMU2VLRVB0ODIrSXU2c01tNXVncWtqVTZGdFR3?=
 =?utf-8?B?YUJjMmkrMXlybjJEUWxsMWVFdmpMa2hzZ0VJWERteXBiY0dBbkJoL2R5SUJr?=
 =?utf-8?B?MmxRV1grU1FqTyt4VVVCYmErOUpTUlkzcDBQVE5vMkxsVGloRjgrMlJxblpN?=
 =?utf-8?B?dHM5MXFtTUxYQXZ5WGVBWEhyd3E3MEZsTnRyQ2VIeGtkK1BrNGc4ZEhKTmxH?=
 =?utf-8?B?UnluQjVQYS81UkU2WnhqVlNoUXJHOU5neEdEUFJqYmErQWcrZDFvN1h2RWY2?=
 =?utf-8?B?d1g4NllZdEMrdjhCOFdHN3NuRnc1eUVxbXF1bWhYVWh0Z1g3ZDB4c09XekZD?=
 =?utf-8?B?WG9HaWVYT3BCUGliTVQvSm1PcFk1NkdSZ0lQMk15VDMvVC9qZ2NPamlKcitB?=
 =?utf-8?B?azhBWi95dDl1R2VqMkxxTmpWeEFxZmJpYkxLaGIrbDBxK3o4QjRJRXdTOW5s?=
 =?utf-8?B?T1VqOWZhZWJkTHlpMXNYMUpXUXFJNSsvVTFvSmRsajZOTW1XRXE1M3dzTXFS?=
 =?utf-8?B?dDBXTlJ6OG5xa2xIZE05a0taR2FIdUROZUJDSUcxaHpQSHErRjBlZGtuTGtm?=
 =?utf-8?B?RVhWcHpCOW1IY2U5Y2Y4OGtFc0kyM1kxZGVkSGRUbnk2WlFqeVZINE5Bb0Ev?=
 =?utf-8?B?WStXRUJCbkR6RG9IYWd6RlhrYW83cGdvWStZM2l3Ukg4TnVtaC9nK1FOVnpq?=
 =?utf-8?B?RStSblpJcTJBRDcyVWZaRjJ5Q0hSTzJUVFJvRm16bFVOMmNCNE85MVF1VnhW?=
 =?utf-8?B?K01wRng1cFN2YUlGbVZrR3NTZVQ3V0xRNWphUy9iQjNWak9tZUlMdmRYZE9v?=
 =?utf-8?B?R3BYelJEYnRKTU1YRHEwVkJmeVZSTUc2ZE1Oa3hpTkxiOTVuNzR0VktKa202?=
 =?utf-8?B?bjR3aUVwNzhma0p0bWpRYzMvSjF5VjdHT2h1ZXZ4QlcrRUdmeWltNGdZeVlJ?=
 =?utf-8?B?dUJxcUxOL1lWZ2dDRklZSXJCZnhVYlc4M2pYRUM0RXhNakJKM0thV0xwS2Vm?=
 =?utf-8?B?cnhDYlB2TE9MZkhRVi85OHN4TStJYWFTdjhIeW5DNXlWODdyNEpRNjBYcEl2?=
 =?utf-8?B?VHZTNEdtRXJqckNKS1A1bEhZelRMNllYSHJuNmxhUXhqb1pLc1dmaUI0MHln?=
 =?utf-8?B?dUFla1o2eWhxTW0rS05WOWxVZ1FKbEJjWExwVDFsZUFqSDZ1eFptOEsxUnB6?=
 =?utf-8?B?eWc5NGtRYjlrTW1teElGK3BtaFR3WXcvQmRwd21GbVBWWWxXdnhNbmFqRWJ1?=
 =?utf-8?B?VmZFSWFSWHZQQU94MzZsR1JwdTNEeTVkVWxYTjk3ZnlpT2ZYVEY5VHVBZUND?=
 =?utf-8?B?MmlUZVpFRC9kQ0NZS09KQWJscnl0alQrNnZlZWIzZk5GM25rdkRUTTZXd1Zo?=
 =?utf-8?B?MVNsd3ZsVjhoUjhleUVwMVdlUjdOdGU3Znc4YmN2RVdWY3k3OUZlQkxNT1JU?=
 =?utf-8?B?ZlBJZ1BESFpMQ1ZZS2xNZnFaTm9nTE94VEpqSVUyRHhEeC9nbGdJZWlEMlJM?=
 =?utf-8?B?ZFFrMGxmS0wwL01EOGV6OEdqYmc0dGxsNDI0SndCY1I5Zy9sNXZQSjZwK2xx?=
 =?utf-8?B?SE5XWW5SbmxnQi90UlhhcHgwa0RSWlI3YUNjbUQwZXVGdWpLVU1KeWZzTHNs?=
 =?utf-8?B?MGtEc1pMMGJBZ2JtcFUySC9DZGM5Q3VzWE9MaEE5MzVNc2pDVk9ndm5ranYz?=
 =?utf-8?B?Sk9Cdms5UmVrVnprYTZKWEpGeGdScmlZWEJNdU1rdjhLWWNlelBQQm5YT210?=
 =?utf-8?B?QStyQkpCM2VrSENwNndmdEdNa1pyc2haNUdmQWkxRm9tcld0NXEwQXdwYmU2?=
 =?utf-8?B?ZkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba22ee80-d1cd-47da-3b0b-08dc58f0a195
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 23:56:10.7007
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MYjLKAzoXaYI94At+8D72cpMs2y8HVrXCc+Nzpju/bwHF3TyJ9TmsOe7Vol0MicJRKztvg72aPySlytvDknpjWpishu5JdpWant9O2mJgow=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6945
X-OriginatorOrg: intel.com


On 4/8/2024 8:29 AM, Mina Almasry wrote:
> The implementations of these 2 functions are almost identical. Remove
> the implementation of napi_frag_unref, and make it a call into
> skb_page_unref so we don't duplicate the implementation.
> 
> Signed-off-by: Mina Almasry <almasrymina@google.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>