Received-SPF: pass (google.com: domain of linux-kernel+bounces-137740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <c4976cb1-ef18-42f5-acbe-0c053bc4b141@intel.com>
Date: Tue, 9 Apr 2024 16:58:52 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 3/3] net: remove napi_frag_unref
To: Mina Almasry <almasrymina@google.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Ayush Sawal <ayush.sawal@chelsio.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jesper Dangaard Brouer
	<hawk@kernel.org>, Ilias Apalodimas <ilias.apalodimas@linaro.org>, "Steffen
 Klassert" <steffen.klassert@secunet.com>, Herbert Xu
	<herbert@gondor.apana.org.au>, David Ahern <dsahern@kernel.org>, "Boris
 Pismenny" <borisp@nvidia.com>, John Fastabend <john.fastabend@gmail.com>,
	Dragos Tatulea <dtatulea@nvidia.com>
References: <20240408153000.2152844-1-almasrymina@google.com>
 <20240408153000.2152844-4-almasrymina@google.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240408153000.2152844-4-almasrymina@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ak4zN0tTaGpib3djQzdjbDg0ZTE4MysxWGxtRjNoeHFhMXkxSmpDbGdVL2pj?=
 =?utf-8?B?N2hFcTYwV3BQYUZ0bXVjb3VuL0UwTkoyeDRRYXNiMHVUdVZIMitmc0dDTk9w?=
 =?utf-8?B?eHpSNHM2RFBScmFPWEVUTUYrS1BRM1B3SGJLK3hmVlEzYnpKTVhLeXdXNUJZ?=
 =?utf-8?B?VXkwbmxHK0FJSHNETUlJRFRpK2VadTFOTFQ1bmhXTW1OeG9PZEhMRzcrOXhI?=
 =?utf-8?B?U1NrSU8rK1F4N2xRcVRaUUdadC9hcGErMFk4dmc4OUpIbmNhREtuKy9leFRC?=
 =?utf-8?B?L3N4WVk4aDhQK0lHYTBkYm5udXZvaVJJcGN3ZkFLa1lVaVg5bjgwem0yc2du?=
 =?utf-8?B?bnFNdDBDek5DdHJiODFRL3VIejJjSUJSd1hGUlpwRHkybm5ENnZVcXZBNmtE?=
 =?utf-8?B?d2ovMWZpTFdoWTFtTzZkNThsZGs2M2tQWUk3N2FmMWxrZ21pMi9RR2s3Q2Q2?=
 =?utf-8?B?SVh0QlEyMUxNQ0JsRGN1anlFNThiNHJjYk1UYVdvQkhOdHlpb3BQSitTV0hD?=
 =?utf-8?B?TnQ2Y3BsOXdkdkE0R3dSWHRWaWhpZkt6amZONW5CSXFWNEt4VmpzNC9pKysz?=
 =?utf-8?B?SmdNWTluLzVaVDZKZWVrMDBlVXcrdjRGSkNvZEtPSnZOUk4rVGZ3R2ZMWDdi?=
 =?utf-8?B?MDRwdEVHYUFoMzhmd0sxQ0VsWGEyMFB4dE1ZbXV3bEh2NDJEYXRuVk9PcGl4?=
 =?utf-8?B?VzJHd0ZnUjQwdTh4U3F5bXREVnRRREQ0dEpYazdubGl5RmVnWDZubkMvSTh5?=
 =?utf-8?B?RHBFQ2lDUGgwZFNiZzB0Vnk2UnRTb0VtSHB1MGFpdEF2VjJmTk5sN2xTdzA4?=
 =?utf-8?B?UFVWK1c2dnhSZGtXZnF4ZEdBODhkc3hxRzdQbVVZR1REbE56ZHZLRXpsL3Zj?=
 =?utf-8?B?cWVDWE5mR2owN1pHQjZha2hIVW02YXJqT0d1Z200TEhpQ2tBN1E0WXNBMXpx?=
 =?utf-8?B?MHIrKzQ0SUxCVVVVSUt6UXRJUHB6NlNYVHk0cUsxNnljMWJQM3VGUnZDbk5P?=
 =?utf-8?B?QVU0RjFhY0Y3K2dUdU4vbWwvOWxzSmhXT2ZTU213cWsvNU5UMWxzaU5yN3Bo?=
 =?utf-8?B?YW1zcmdFSHYwSEJhL1RtREdtUjZOaGxHT2hFN3h5OFlUQ1VwRXl1S3RCNUlG?=
 =?utf-8?B?NXVmdVpBOVhQV29mbDV4SXh4cDVib29lUVFOUC9ycUpnbnNwbHlybkhaenNR?=
 =?utf-8?B?U3EycEhDOHB1ZTVGMFcyZUhubzNtVkdUUm0yc3QyNWw0UzNzYXpHZDVSNFRi?=
 =?utf-8?B?WCthR0JRZFA1bmQ4Z3c5Y2lnOFE5QzJYUFpvZGtTL2xkNFg2TkJvdTFVb3Jr?=
 =?utf-8?B?aGVZY1hsdVNEUUlVMzBYZ1E0Tzh6QVlkV1N0UExENlpkM05vZTE1SEw5Q3Vs?=
 =?utf-8?B?emZtTU9INCtaa0ZBYmROOFl1TW9ETVVQNm9QdjZwRUtVODB0QndRWCtCZzc3?=
 =?utf-8?B?L2NYelhQbWdaZk5PYzVkNUo5S204WWpIbVc0cllIQjErV0hWV3NuR2F3dWUz?=
 =?utf-8?B?Y0cvYU5SL25xQ2dJU2VDOE5DeStrRUVXR2VlMDhwb1RoMmhKRUxhVzNMS0h2?=
 =?utf-8?B?Rkp3WUJOcHZDSnllc1pJZzNxb2lFNTVsejZENHdxRzY2TVdxeFBDYjZuSmJT?=
 =?utf-8?B?QkcrczhvYXpTdUthanBHMHZxc21tREJ3dUJYeEFQcE50ZkRDSVU3V3pjUWla?=
 =?utf-8?B?YitSa2t0SUlnK1o5SVp3Sm1xYU96a1B0M2hHY1pIRDZ4Z1FnL0ZmbTZ6QWlG?=
 =?utf-8?B?MzRqeUx1SFZOeXVqekk3OWNIRWRtZ1lEUGV2cFZPL092ek5UajBrV3JpVkJh?=
 =?utf-8?B?cU4wcVBkNy9Ua2RZaUhnc2I5TmJYenBsU3lwTGJqU2Z6TzE4ZWhibFlHb1V2?=
 =?utf-8?B?TWNIeDJVQkptZVY2UjdIT3pjcktZNmFhQTBaYTFUeFJIQ0Iyeis4OVV3MEov?=
 =?utf-8?B?c2x5YTI4Mmhvd0tGQkFsd1d6c2tHWlFBMUxzaCtUVm5vaHJlMXZQR0QxM2gv?=
 =?utf-8?B?ZllkYkFaTnlZeThpRGRuWjRFVjBwZDV3TlB3QzVIWmppcUNvYzBZWGFDZTVD?=
 =?utf-8?B?Rm15K3F3dFRaRnpJWnVsTG9WTlVPRHFHZkpHMCtRTFd0QjlkbzdxYmY0Wmhh?=
 =?utf-8?B?M3RuTDdWRzRvMXg4SjlkV3Q2cTdMVllXNm94Znc0SzVNdTFwWjZvOFRON2RS?=
 =?utf-8?B?VWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a9ba04a-22d4-452e-eea0-08dc58f1034f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 23:58:54.6475
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QUz+1ZS4bSytAlRncisLQ5FYwW9DkvWTBjALoh2ifTm4R5bu0Xue/VyAAzL80DEgbmZuLktKBQyF8V0SuyhHzpklyrCB6DFpIv3DU4Q+lvc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6945
X-OriginatorOrg: intel.com


On 4/8/2024 8:29 AM, Mina Almasry wrote:
> With the changes in the last patches, napi_frag_unref() is now
> reduandant. Remove it and use skb_page_unref directly.
> 
> Signed-off-by: Mina Almasry <almasrymina@google.com>
> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>