Received-SPF: pass (google.com: domain of linux-kernel+bounces-137742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <33c44fe4-a682-4c7b-b910-60bac93cce7d@intel.com>
Date: Tue, 9 Apr 2024 17:03:55 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v2] net: sparx5: fix wrong config being used when
 reconfiguring PCS
To: Daniel Machon <daniel.machon@microchip.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Lars Povlsen
	<lars.povlsen@microchip.com>, Steen Hegelund <Steen.Hegelund@microchip.com>,
	<UNGLinuxDriver@microchip.com>, Bjarni Jonasson
	<bjarni.jonasson@microchip.com>
CC: <linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20240409-link-mode-reconfiguration-fix-v2-1-db6a507f3627@microchip.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240409-link-mode-reconfiguration-fix-v2-1-db6a507f3627@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUhjWUM5ekZwUkNGZXdqck5Wcnp1eXNwLzB4RWFBMVFYdmJoUFUwc3F2aVdh?=
 =?utf-8?B?WlJvQk1GVFlaQW5wVnhoazZDR0o1dUU1OXptWlhoRmJ0T3dZbzFGQk01ZUJa?=
 =?utf-8?B?MDNPcWN5UXVBbFFWWDB1aEZzMlhrRWFaSytBSWFqV0RwTEMwaHJOMEhoU0JM?=
 =?utf-8?B?aWVrNWt4Wno5L1U4V0NsemhPRXR3UTRvbmxUT2g1TitwZGR1ZjYvY21zOWd6?=
 =?utf-8?B?dWRpYUZtTXUrLzVYWGRsVk1OdXFkNDNjQmNwblRKOTN3bzZ6S2VPT3l3bDJk?=
 =?utf-8?B?TFRTaDIwZDNLZUl6SHB2L0l2aXpwb0NvNVZiN0hmSHVPcytpalNSMkUxZTJ4?=
 =?utf-8?B?WG5oaHJ4bXQyRlovQzJFWEtaRithb2ZZaHJLRGpDTFFwQ0dXc1NkQy9JWVNN?=
 =?utf-8?B?c1BFQ2ZlQW9TQzdUcjduaStYdnVVQWFXd3ltYVROc3ZNYWZaZ3JiKzAwQnZh?=
 =?utf-8?B?eERkQlhDUEVZSzNSNlVOTnNDbzlPRVBPUFp5WlVSU2N2N0l0dVFyN2FjUjFn?=
 =?utf-8?B?ZlRwOGRRQnFwWmwvL0V4WXdvN21wOTVvbk92OVB6UW5hMFJzRytvVXNySFRC?=
 =?utf-8?B?L0lHbVhublV4NksrN21GdVBIZ1NlRDVscXNMckhnMnhyVUQvb3FVcG4wNGg1?=
 =?utf-8?B?SnBSQjVCR1JodVQ4ekNKR0dvRWFzaEJycHB3dUlpUGZTOXZNbFp2cENCdVdB?=
 =?utf-8?B?c1p3dk9IdUhLSmlodFRvdC9OdnpMNDBDSGpWV0haRzdUdEZhZUNXcno2ZUI4?=
 =?utf-8?B?djJVRG0yZmJZbEhtR0t2SzJzaWkrZmkyT05MQXN3TWpYWXk2ZVFkMVIvY21X?=
 =?utf-8?B?RzNGRmtUNFd4Q0VDVFJIalZWTVpnQ2hXdUI2ZWZkWldwYlBwNzdoaGV4SnY4?=
 =?utf-8?B?Y2FpT0w0aWRDTVhkZk1WcXFrVFU1RkZINFJ2QzUwcFJDQUVnVXhCSEo2a2pC?=
 =?utf-8?B?YUtrZHhGRGR5TEJTalBpNkZBeG1uOGJQQ0tvcVNpTWJ6cFpyUFUwZkptQThs?=
 =?utf-8?B?OHlhcENhZ0wvTkdna2V5dzNTTEIrNGRQYjBERlJLNGEvQ0pQTGIvM29EaVJo?=
 =?utf-8?B?dVdzcEt5VEpmOSs2bUdjN2VqQ0FuTVdRWjZFNlNDeG5rZVh4WnNsTjZhRDFV?=
 =?utf-8?B?a05GYmV4STNrRW4vaUlFakV0dVFaQlltVXcvWFo1alJhREc4STFtc2NLeEll?=
 =?utf-8?B?by9odzNKZlFDSUJCSE96U0QxcU9uVWQzNWNDckVTNjFoR1hOeDRGZVNNa2RI?=
 =?utf-8?B?USt4RjNSVjFLS1BNN0N4eDlCa1gzN29wTzBMd3ZZYmd0UkdPQUZQNGh4N01X?=
 =?utf-8?B?YjNlWVVLS0xZOWl3dmdNd0laU2k2M3VWcVhjN1cwMlFack1tQURoZ3JUU3Zn?=
 =?utf-8?B?bm96bEV2MFduY283Tmt5enNzVXdXckdGOVBZOUJoVTc4ZWpPTkc2OWVYeGpD?=
 =?utf-8?B?R0NJTlc4RjBMb3V6TGVSNzJ4Qnp0Q0xjY0w2UEJ2K0ZkbkxsM3QzK1lPdmN2?=
 =?utf-8?B?emtkelVyOElVZm1IeE0reTl0SG43QlJZdjdLeGZ1Q1R6ZHU1VHdmaHR2SFJE?=
 =?utf-8?B?RmNLTk93anVMR1cveFJWUmNvc3o2cm9xVmoxbk1Ja2dKREZ6ZExUSnhxOEFo?=
 =?utf-8?B?ZkpwRzQzaStONmc3SGcwOC9UOGhIVWN1RC80emd6UDMzSEdYM01wMXR2V0d3?=
 =?utf-8?B?N1hUYXBpVXNkSTZzZ1lxd045TER1L1RRTHNJTitqNCtEZm9xQlNGd2psQzM0?=
 =?utf-8?B?c1ZKR2xOUnRSRXA3Y0lrc1NFSE1PdnFxQzdteEpSYVlPWXVJS2JxNnhaVVFK?=
 =?utf-8?B?NWRGNjBaVkpyVG5pNDR4OXdzOHBodkkwSWRsNkRHeGdCaDNLQmErUUU3NUpt?=
 =?utf-8?B?QW1VTzJ1WGdNdjVZdDNKeVp1b01QS3lpUkhwTkZWKzdDekdUM0RGVTZoQ3g5?=
 =?utf-8?B?RmhTbXNyNFJEd3F6bkRmT3ZtNVJPYTFBcHI4ZWp2U3RwNklRdzFmSStFRVk4?=
 =?utf-8?B?c0hjdWMrbjNBbFBnZm43OURXd2hNRHRhaDlIeVR6eFlnMmQ2eHJ1M3AyR0Nv?=
 =?utf-8?B?dGNHMW83OU80YlZkYzI5cEdxbjFHeDhnYUV6amJVMXFoa2s1elBVYnBvTTRp?=
 =?utf-8?B?VnU1c3dXSEhtbUs1TGhWbFlUN1RxWE50SmdKZmRSdEtJbFkxdlAyejVSeElL?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 52e9fe14-59fa-4ced-babd-08dc58f1b7e7
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 00:03:57.6286
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cbsgwg362DDmtLUkt0DncUezjJmOMvxuRwWiPocxjonevjjD9IMWV92A4ty7CIjwHyxKR+qpEhBK8sXFbIUW2ZLGjscK0KHd/9ovo81TuoU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6860
X-OriginatorOrg: intel.com


On 4/9/2024 3:41 AM, Daniel Machon wrote:
> The wrong port config is being used if the PCS is reconfigured. Fix this
> by correctly using the new config instead of the old one.
> 
> Fixes: 946e7fd5053a ("net: sparx5: add port module support")
> Signed-off-by: Daniel Machon <daniel.machon@microchip.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Changes in v2:
> - Rewrite subject and commit description
> - Link to v1: https://lore.kernel.org/r/20240405-link-mode-reconfiguration-fix-v1-1-c1480bc2346a@microchip.com
> ---
>  drivers/net/ethernet/microchip/sparx5/sparx5_port.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_port.c b/drivers/net/ethernet/microchip/sparx5/sparx5_port.c
> index 3a1b1a1f5a19..60dd2fd603a8 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_port.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_port.c
> @@ -731,7 +731,7 @@ static int sparx5_port_pcs_low_set(struct sparx5 *sparx5,
>  	bool sgmii = false, inband_aneg = false;
>  	int err;
>  
> -	if (port->conf.inband) {
> +	if (conf->inband) {
>  		if (conf->portmode == PHY_INTERFACE_MODE_SGMII ||
>  		    conf->portmode == PHY_INTERFACE_MODE_QSGMII)
>  			inband_aneg = true; /* Cisco-SGMII in-band-aneg */
> @@ -948,7 +948,7 @@ int sparx5_port_pcs_set(struct sparx5 *sparx5,
>  	if (err)
>  		return -EINVAL;
>  
> -	if (port->conf.inband) {
> +	if (conf->inband) {
>  		/* Enable/disable 1G counters in ASM */
>  		spx5_rmw(ASM_PORT_CFG_CSC_STAT_DIS_SET(high_speed_dev),
>  			 ASM_PORT_CFG_CSC_STAT_DIS,
> 
> ---
> base-commit: 1c25fe9a044d5334153a3585754b26553f8287b9
> change-id: 20240305-link-mode-reconfiguration-fix-df961fef5505
> 
> Best regards,