Received: by 2002:ab2:687:0:b0:1f4:6588:b3a7 with SMTP id s7csp123884lqe; Tue, 9 Apr 2024 17:23:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUBums54uqosExRX3sAtnXXRCPD4yqWlZVoZPg2sVgyAKQF6s7/otV13l9L6C+3SfslP9nidvu6xa4z5ZwwGj4NLnuL1xBI0/r+KiIJ3g== X-Google-Smtp-Source: AGHT+IFFbK59Hya00s00iffRdBUqKRlLnCF7o4W1HHyxdC5x1vMD1kZvlpafqOsQ+iLq//PGTxB3 X-Received: by 2002:a17:902:eccf:b0:1e4:2b90:7589 with SMTP id a15-20020a170902eccf00b001e42b907589mr1362737plh.61.1712708618110; Tue, 09 Apr 2024 17:23:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712708618; cv=pass; d=google.com; s=arc-20160816; b=rk6smoN7cfqoXuuOrNvjAm6ellBEoSndIXNIFF1/MAj8u+e6nVuCnEWASe+OnOFZld NH6oXAtoxaAmSED8nQoSA80qCX+gzNqWJ6jyP9SRdxzQx/4TWCDMd3ZkO/DxVVWSqVba ZmVEt5RSGLY1HlDwsLLU71gcqSx2+F9VkmVaWFODraFiPe4TzocaZ58CErUQGCM3jWj8 AYW/lttm3Jw04p4Pve9ri3iFokoKaOIu3AjoNzHi/LXFlbd+CrtOiGiVpNX3asjpi1Cw jgWfJ/kFqbYp+Iqm5DKsT5YpOVdffpGVGclEwzVAGYH0rOYhAlvTJIC204UpK44Kaoru gC/g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:references:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to:date :dkim-signature; bh=ODgFnzZURolTJcv5yfCxGgoh6Ey8Xg9T/7xWu6AFDU4=; fh=MTOrrw2U/AK5/qm9lcI3shPsV8V8nRaAHZlYGjnorUk=; b=sTx/LgUY3Ze7W4J0yt04JnAM27jQV3JJgC9Wrq+uM5SoP2rBVbWZ/GNzSLIR3QEx// b5N3fZewhAt6qSqIus2zVEyoVWZPvo6fD2zN4nZVcISZWEcuxyz4z/WgCvIKke6DQWb0 fnWCOVPBjAvMcOJ8uuHqoe6NhmMsaZygxkCZPqQmcoRrQ8uuDjAe76Nqvr3UxVvFq9hZ puE6l8S0TT35NZPV5Y5pqVIneg8FDMSxNCw2J1xhJ1BaJPzW2D+CIxou40KuXHup7QoN ZfIWvf1jmIwaDtuH9YQ7g1hAN7HlA9aX4/23DaZK4DT7aSUAP2lEqcOm4iMMmDZzHZcl E/oA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=waO3yEnq; arc=pass (i=1 spf=pass spfdomain=flex--seanjc.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-137757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u17-20020a170902e81100b001e3bffa4989si9360427plg.42.2024.04.09.17.23.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 17:23:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=waO3yEnq; arc=pass (i=1 spf=pass spfdomain=flex--seanjc.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-137757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C3B2CB22767 for ; Wed, 10 Apr 2024 00:23:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9E41AA59; Wed, 10 Apr 2024 00:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="waO3yEnq" Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112672900 for ; Wed, 10 Apr 2024 00:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712708584; cv=none; b=CC+oUz1qj7zGA8g1vYyGGf+h5zqY4CM4O3HrevUOpbyrLCSRQ4COtXTH44CKXmyc5Gnw3k45NaoAqSaUBvLwSRgDapwNSYXU9eU2GLgAYkPOLTMT55ruSS5yyP2pxScVJVFqpeR57EJHSOzEBP6TYeKHXZEwuDNVPca5j7xZUrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712708584; c=relaxed/simple; bh=qbAllYoFjx9HxUgTfIOlCWsC0dWo4XP1/Rh0PT3FHPo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=kj50qBg7tR9WOwBPeLirjogeUF6Ktnv3v+rncU5Eo6r51DDzxX9ERiCy4tTplL/6xWHkPxr0w1HznHTV3aFPnXesd8Wb3MBFX8DKoquCaXmhxuHkhYTQr01riwsr/ThSMEdUEjkrW7tVC/mh7IDadyqQyOPJY0znzcVBPhvG6Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=waO3yEnq; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-5d8dd488e09so5602242a12.2 for ; Tue, 09 Apr 2024 17:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712708581; x=1713313381; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ODgFnzZURolTJcv5yfCxGgoh6Ey8Xg9T/7xWu6AFDU4=; b=waO3yEnqK+TpTUTw5lOYaQBgixdRqcbXYCI/XLqddaHPAOC3dyOYbRW7qZVu9RbYYJ SEFh0ENA3e8nlYqOxo4b6ut+43yTTjFFEAUz6QA63fY3tOe1UtoONeGdJBqHl/8oaFW4 JmAorr1SjatgSnSfUGohHaP2ACdtBNJ5ce1+J9qeGEpxTp497lG0B9vhYTolGrKBG2/b J3ZtbTothoNvEjwHjg+czf47rI81+v7Jb3xJaLrdHbbnlupbS8YWDiUEE0nveGupl/4b DWq4tVIHEIHaUeKIg+JkVY8q+HWeADk2taWGJnIejx8xGzkq9SUwDqJYZ3GYXvyNVKhn dyVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712708581; x=1713313381; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ODgFnzZURolTJcv5yfCxGgoh6Ey8Xg9T/7xWu6AFDU4=; b=cemBSHVOWBmlphiNptiUEuXcvSEjR68C0vZW4HW+/PRfeq8sF654iFlbUV2PT4g6nN yq99V1PzIkLmXuoap/na3mr2YtV2i8WXDlat4E5KywET3BLJH3ouWOkQxgXaU1pSqko1 3FHdO3lPsCc9qUCg+yOPePtLl+qujJe8YEN5i5kPFusTOsasNmkE43iAjvjkIZqevZ9r Bn0bPQI2AGPni5Ft4AgqK9ZxMGBzFqNknZQLDwjaLocpaLq0UA/wr4R7kcgGDmEGfzjV sEoEC/YY6vZlx5w99L13aL/ialMHBc9cp27j7c/WjevGAi72lYhq/iVXKslGtYGJ/NXF 35kg== X-Gm-Message-State: AOJu0Yz07qeE4AECqYzIejU8wFR/1TVl214iPVwDGLYGaLEXO873Omjf 0dhtuxfAq5NrSj+CyTDAxqqiXOzUwhVt3dYw5lY+pACtVEx9v7DMGbh277Q+RrTPMtqi2FAdTbC 3Qw== X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:4e54:0:b0:5dc:1b02:5a56 with SMTP id o20-20020a634e54000000b005dc1b025a56mr3245pgl.1.1712708581274; Tue, 09 Apr 2024 17:23:01 -0700 (PDT) Date: Tue, 9 Apr 2024 17:19:57 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <171270501999.1589908.16513783638221600780.b4-ty@google.com> Subject: Re: [PATCH] KVM: SVM: Remove a useless zeroing of allocated memory From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Christophe JAILLET Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Sat, 09 Mar 2024 18:15:45 +0100, Christophe JAILLET wrote: > Depending of the memory size needed, we clear or not the allocated memory. > This is not consistent. > > So remove the zeroing of the memory in the __vmalloc() case. Applied to kvm-x86 svm, with a massaged changelog to unequivocally state that not zeroing the memory is a-ok. Thanks! [1/1] KVM: SVM: Remove a useless zeroing of allocated memory https://github.com/kvm-x86/linux/commit/4710e4fc3e2a -- https://github.com/kvm-x86/linux/tree/next