Received-SPF: pass (google.com: domain of linux-kernel+bounces-137763-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 9 Apr 2024 17:26:02 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: John Fraker <jfraker@google.com>
Cc: netdev@vger.kernel.org, Praveen Kaligineedi <pkaligineedi@google.com>,
 Harshitha Ramamurthy <hramamurthy@google.com>, Shailend Chand
 <shailend@google.com>, Willem de Bruijn <willemb@google.com>, "David S.
 Miller" <davem@davemloft.net>, Junfeng Guo <junfeng.guo@intel.com>, Ziwei
 Xiao <ziweixiao@google.com>, Jeroen de Borst <jeroendb@google.com>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] gve: Correctly report software timestamping
 capabilities
Message-ID: <20240409172602.3284f1c6@kernel.org>
In-Reply-To: <20240408180918.2773238-1-jfraker@google.com>
References: <20240408180918.2773238-1-jfraker@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon,  8 Apr 2024 11:09:01 -0700 John Fraker wrote:
> gve has supported software timestamp generation since its inception,
> but has not advertised that support via ethtool. This patch correctly
> advertises that support.
> 
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
> Signed-off-by: John Fraker <jfraker@google.com>

I think it should be a single line diff:

+	.get_ts_info = ethtool_op_get_ts_info,

right?