Received-SPF: pass (google.com: domain of linux-kernel+bounces-137783-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <2d65584b-8811-4760-bd6f-600ed170b418@intel.com>
Date: Wed, 10 Apr 2024 13:05:01 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [ANNOUNCE] PUCK Notes - 2024.04.03 - TDX Upstreaming Strategy
To: Xiaoyao Li <xiaoyao.li@intel.com>, "Edgecombe, Rick P"
	<rick.p.edgecombe@intel.com>, "seanjc@google.com" <seanjc@google.com>
CC: "davidskidmore@google.com" <davidskidmore@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"srutherford@google.com" <srutherford@google.com>, "pankaj.gupta@amd.com"
	<pankaj.gupta@amd.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>, "Wang, Wei W"
	<wei.w.wang@intel.com>
References: <20240405165844.1018872-1-seanjc@google.com>
 <73b40363-1063-4cb3-b744-9c90bae900b5@intel.com>
 <ZhQZYzkDPMxXe2RN@google.com>
 <a17c6f2a3b3fc6953eb64a0c181b947e28bb1de9.camel@intel.com>
 <ZhQ8UCf40UeGyfE_@google.com>
 <5faaeaa7bc66dbc4ea86a64ef8e8f9b22fd22ef4.camel@intel.com>
 <ZhRxWxRLbnrqwQYw@google.com>
 <957b26d18ba7db611ed6582366066667267d10b8.camel@intel.com>
 <ZhSb28hHoyJ55-ga@google.com>
 <8b40f8b1d1fa915116ef1c95a13db0e55d3d91f2.camel@intel.com>
 <ZhVdh4afvTPq5ssx@google.com>
 <4ae4769a6f343a2f4d3648e4348810df069f24b7.camel@intel.com>
 <44af8014-f73c-4ef0-9692-07e8df18fe24@intel.com>
 <99144e08-7852-4aef-addf-2c031b6cc62a@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <99144e08-7852-4aef-addf-2c031b6cc62a@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yy9maFZMRDRxUFE4ODlRdE9GbDZ4N3lha2phWkMwQXI1cGxZbVVjTUJna1Bv?=
 =?utf-8?B?Q1FRWEpQZ2crQUFpNnBvblQ2Q094TC9RVGFKZEJjUmN6R1pxVUErUkhSSjg0?=
 =?utf-8?B?MUF3N2dsMW83MncrcGJGSUhobUFjUCt1UkhJMlNrdEozSHdBUFpNZjMvWmJI?=
 =?utf-8?B?SzJaUmxpRXIxSmRvR1JrR1BLSmdkZi94QWF3U2JRWnEvcUhqRUg1N1d6TjZo?=
 =?utf-8?B?dWp5SzZMdWQ4SG1RSzZuYlpxdTA0V0lXUkRKSUhiTncvdCtDQjMyUGQ4YVZC?=
 =?utf-8?B?Z1pxV3ErZVgwL3pWWEJneEFoTUVtaHdYWHlvZTBIQlhJMURCVENZMS9OS2RK?=
 =?utf-8?B?Y3BidllZRFhuTFFrck1UQXRubzg5Uk1sdXFtS2xHMEcwMTVHK25Ia2t5SllY?=
 =?utf-8?B?ZDZMUWwxaFBoUFBtMy9kMDBhZlNHZjhiTEdkd2s5ZG95cStUN05sOGdyRTly?=
 =?utf-8?B?eUdkeDY2TU9zK3U5UFk3bVd4NC9lRER0Y1dPVDVDNGlabFNqUGdyaUVzY1Nn?=
 =?utf-8?B?OGs0T3FDU2tBcVEyaGo5aEFpVmwwQmx6M1hRdFR6K0x6dHhkZjNGK1FGZXYx?=
 =?utf-8?B?SG1YcXVoUnk0YTN6cnFYdnQrazBsOFVTSWZoK0NHL204eDIxckZjYzlCQnQw?=
 =?utf-8?B?aWRzdWJ4d3c0VU00dzhNYk1LUWM4TDg4bGRVR1hsSWJwTWV4ZExpaDZEVnRB?=
 =?utf-8?B?OXNydUtXVjFUcUY5aDhSVXRMT2ZZVGhkVVVubUpkZzdUOGxNK3hnK3d6Z1J0?=
 =?utf-8?B?c2JUNC9jTGVGaDVRVzBlZ2xFeDM5VHljRVV3dUY3UDFnTlB5OGRtdTRVYXZn?=
 =?utf-8?B?RER4UjJKaDNEZWlVMDlqMDh6SjdRNXJqcmJlQVhBamFwK1VNSW5WaS9VWFdm?=
 =?utf-8?B?djZubTVVcHRmMUt1eWZUS1Z3V0haUXZqanB2U2hkd2JEQUo5YTRmaUQ2dFRM?=
 =?utf-8?B?RVovY25ld2lUcVlWS3V4WGFZSklJcHQxR3lqdVRmU2wvL2lYN2FPMXRJVll1?=
 =?utf-8?B?TWFRTlAxNDVzMmdlbnovQnhTR2VjbVcrajRoaHYvb1RHcVNiOUExS0s3bXFQ?=
 =?utf-8?B?ZE9PVEtPaE42VEEzVEU3RW5aVmVmUnB2SzAwL0htbGZrNHVNT1RFNE9pZURn?=
 =?utf-8?B?Z2NxWVc2N25NTytORkphaUEwUHltZXdLREkyVTJSKzBtcENoaENuSkIvc1Z6?=
 =?utf-8?B?eXNieFJkQzdXTHNSQS81RnpPNUZ6OFNnS1R1RkdUdlJ0Z2FWZDVub21yeFpW?=
 =?utf-8?B?RGNzY3pVWWJBOUtiNjRheWZSQU9pVWIrTExXeXhUSk90MzJzVXc5d3JmOEd0?=
 =?utf-8?B?N3FkQzJ1bHVCczRKa1huWHIxVkdHRlJhcnhOcU1sN3R4aWh2VkNYS05DR1ZN?=
 =?utf-8?B?cnlpZ2dtc1REN0dyamFFbExjK1RicHNnT3pNUmlad1pnWTJtUkhkaHB5QlVx?=
 =?utf-8?B?VHZVYnVtTkZDMmdCYmxZNmFYd0hZN3BjckNPUERFckk1SitNRnNSSlcwTEdZ?=
 =?utf-8?B?MlFnWmJoeFhqV2RWOGtKY2crM3ZMOHJ5a2RJbW5KdStYS1JSNnpVSWRzYitH?=
 =?utf-8?B?Q1lDN2dlL2R6a1l3ZjZ0cS9pcDJacC9DSTNGOFpoWXgrM3JMSVFCM3hKTFFy?=
 =?utf-8?B?blIvc2JpRzZDYndCMVBzVnN1SmJTUnBaMEFWVTROVzdia2V4Mlc5ODJHMkh2?=
 =?utf-8?B?TXVEZ0U1LzY1eHFxb2pmTWo3a3dSZm51VEoyRzdPYXF2c2c4N0pxMHRFOWRh?=
 =?utf-8?B?UnR5L3M3WkllS3NDcE9FSmRlL2ZYR2Z3QUJKb2FQNi9zY0NSZEx6UjZjbDFo?=
 =?utf-8?B?a2hqNmpxelNKWXNyWHBneFRSbFVXRGZETXFuUkxYazlYOVltZWxrc1lBQnlS?=
 =?utf-8?B?cXFOT3kxRVV5WjFYZ3BTZm9WOEt0Qkt5Ri9ZdVh2dFR1MHc4UUtqSUpPbmZT?=
 =?utf-8?B?eW40UnpKK2hLWTU3WVhRTlMrMk9DUFlKL05tNS9DMHZ4VUNxWFIvbWNtNDVP?=
 =?utf-8?B?Q3VJY0xpVUFQMVZpSld4MzBubDQ4VVB3UnFzNFFqUGNDOEwwaU9iNHNiTHhF?=
 =?utf-8?B?Y0hEeFdDQ1NEUFVjOENMTGsvenkwZkxJVmJNV2o0MmFhWExWcXdFaFlHTmVr?=
 =?utf-8?Q?UIWlyNP/PFJPHRgo22IReVY1U?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a3a047b8-899e-42b8-b27d-08dc58fa464f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 01:05:12.5417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9daG6cE0Slss856hYc4p+AZl1DZYyCL7y3OQMJtS1S4P0TLAEj8piaqLI6oL7TZ6zNh0AvqkC7xtKgDtwdGvFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6469
X-OriginatorOrg: intel.com


On 10/04/2024 4:18 am, Xiaoyao Li wrote:
> On 4/10/2024 12:13 AM, Xiaoyao Li wrote:
>> On 4/9/2024 11:49 PM, Edgecombe, Rick P wrote:
>>>> I don't want JSON.  I want a data payload that is easily consumable 
>>>> in C code,
>>>> which contains (a) the bits that are fixed and (b) their values.  If 
>>>> a value
>>>> can
>>>> change at runtime, it's not fixed.
>>> Right. The fixed values have to come in a reasonable format from the 
>>> TDX module
>>> at runtime, or require an opt-in for any CPUID bits to change in 
>>> future TDX
>>> modules.
>>
>> I have a thought for current situation that TDX module doesn't report 
>> fixed CPUID bits via SEAMCALL interface but defines them in docs. VMM 
>> (KVM or userspace) can maintain a hardcoded array of fixed CPUID bits 
>> and their values according to TDX docs.  And VMM needs to update the 
>> fixed array by striping out the bits that are reported in 
>> TDSYSINFO.CPUID_CONFIG[], which are configurable.
>>
>> If the newer TDX module changes some fixed bits to configurable bits, 
>> They will show up in TDSYSINFO.CPUID_CONFIG[]. So VMM can update fixed 
>> array correctly.
>>
>> In fact, this is how TDX QEMU series current implements.
>>
>> However, it requires TDX module to follow the rule that if any bit 
>> becomes not fixed, it needs to be reported in TDSYSINFO.CPUID_CONFIG[] 
>> as configurable.
> 
> If TDX module flips the bit between fixed0 and fixed1. It doesn't work 
> neither. :(

Exactly.  I think we need to ask TDX module to report such information 
rather than depending on some JASON file.