Received-SPF: pass (google.com: domain of linux-kernel+bounces-137795-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 10 Apr 2024 09:24:40 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Michael Opdenacker <michael.opdenacker@bootlin.com>, 
	Inochi Amaoto <inochiama@outlook.com>, Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, devicetree@vger.kernel.org, 
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board
 device tree
Message-ID:
 <IA1PR20MB4953CA04D33EA0C7902DFA3ABB062@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <20240409064504.4010353-1-michael.opdenacker@bootlin.com>
 <IA1PR20MB49532A8D4294ADCE0C33A654BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
 <20240409-prevent-deepness-2d22bf009b16@spud>
 <IA1PR20MB49534E00CAE29D24F7D7E718BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
 <1514d28a-5e96-4531-a972-894e41902efa@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1514d28a-5e96-4531-a972-894e41902efa@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|CYYPR20MB6833:EE_
X-MS-Office365-Filtering-Correlation-Id: 0a48ff0d-5d79-4fe1-d5f9-08dc58fcf3a8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	etRvX8sVduCZ17x7fvvRwFyG+cGzlTajq3hdOGj9/Xk2Z01JnhddhxKDr0z9RdwIW5tCk7hi7Shbt4677/jR7lGoSGt8NJtAat5EARrgNeMuqROQFTp/p8zsLnAvET/1RvUDxOg8mi5WbUctWJDtV24OD4BTCXfrc0P8LZYoUTQoJEJJOHBNzHX1CkluXjwwWrShDJU5X9KAKsdJ3syHrRRReuv0XBdA4328lIVq1jGLCPekcE7GiNjTseVvDHh3IRFLoFsel95WdBjW8JSr8qnb9hN6ADwYtzdZWAkD2s6n/zalC/iNXktO3GgTj+VEe+IiFvn39yC2PuYfRQT+X8iXVJryTZMJtWtjzrQcYvAOtw/LLrrgucX6Q75bQZhOSDUPsgpmRusG/9KI+8+hFkwK5I/m60AJsHk9vpem01nC288UXbNeCnFYPIhvJfykzJ+uQ8/vxeDT+kBhDUDKm5VHV3ISUumzCDp5+YBuZcrGgDGBTEt6SVZ9IaD3VC+5JKkHneTAD2pTDIceAJVJ8MgBWzAcN99l7EopTr3BeUGkVBJZX0LTPnInyEwNw3HGcSfsERx7L7xrmJAGS/ZJGvb35stlH6aLlVcBMOF7FFAZ2plykNLfHtIExjANW2Ln7vGuvo72E7dpv1ywPaViMaXobUnMJUycoCJEWY0uOajQPYqoxSf2NP0o7CKD1CUo
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?1pkM4q/OvzPyPdCJtGFGcPTnfSBvryZatmnaMjTJ3HPFiudoobGeAnb7NyDp?=
 =?us-ascii?Q?7j87rrCXmZyCFZQEfRg6hRdeblItb6drceGS0cKQSVUnVUPm7PsJ2fM6ZQZS?=
 =?us-ascii?Q?tn96GVTEvJKoa7D57KD+yfuD8Qu/oHmrh3MxNRHo7qUFLeJXRtkyrqsL/wKZ?=
 =?us-ascii?Q?j1BHMasInBsnm9Tfz7yCxK2dNhLwxbteOMeFFuq9BQqFKScQ5k2eEQa5FSHT?=
 =?us-ascii?Q?+ScGUeHJ0isqoCcvCLZLx8SK63c3UmjtunVEoQfN8T+jbv4hyQ7fTARj6Iak?=
 =?us-ascii?Q?UokZiAPlCOcmaH8k70vCIg9cIvgURiFPBKwzHyZtXXReno0A/narFqIelORq?=
 =?us-ascii?Q?1uZMMt0Wk9E2i2ji2uqN/5EmjgGmJzW0mCkP+lJ+ZwxKgsr0uXHUmKzw2S43?=
 =?us-ascii?Q?gVilc9fa4un70gli3e5Xx9zB67zcwavQJGAMZ7QSj0IkaE7hh4knjEGKnQ1C?=
 =?us-ascii?Q?B1pFAmZR7Ee2whoKwdel+uRpVc8r6l+9WYFQMdsg6/nr+/IX50vmUUPtPL3p?=
 =?us-ascii?Q?TDGvJj49xpyfmWkkVheNw4vzkaICPVNWzLVf6L0uF0iUjVmxkjoUajfOi1l4?=
 =?us-ascii?Q?TflEOwRE5d2rebo+QSd+jrJjytphw0Gx39+Q9ugSNCFL7HVyFFB14gg+kDrP?=
 =?us-ascii?Q?Ay8bg5XxobeScAroiXUxvwx7yud0zzMPA4VR8BUDQd02O3IElMxGq6JQuwqc?=
 =?us-ascii?Q?k+Jod0WpNEzCgQ1SD5b73+jmPocYLLl8JW2ohK9Y/oMWu5aa1ACvfymnPzNG?=
 =?us-ascii?Q?NDYy+NIZuHMfZJkw/kZDdCEYJwB0aVu09gt4+vc+Dj2IZSr9eVggYiet1ojk?=
 =?us-ascii?Q?wI2iZW7Ad4qo+3eploC1rF1gIQJ3xXb6RnITlNkR7ZP9/CfkZe+XuNoPHQS9?=
 =?us-ascii?Q?Oca0HxlAS2FUspoaEwQlh8ka3QVdP8W1DXbd7umMsjJ0mOqilnI2WnzRanLy?=
 =?us-ascii?Q?vC6urWZ2oEQEFnEroJ/iYaTRnxBWgKb17iOWJ859nx/sIdAlOOvkZoF9XYuk?=
 =?us-ascii?Q?WgPQfcmteROcayzHUfq3lv0jWP48LQi2DkBQUWsYuNONroV+n+R71QwPUNZr?=
 =?us-ascii?Q?U5VDX3tw+OtCOzrlQmZBNIKMYSjvDky7RbxQr1cpy1hPKoVH22yBg7ep7vDK?=
 =?us-ascii?Q?iVD2EzGajxI6E4McmzgIWAMH58oNcXoMF1Iq3LTeHoPyPUWSZqaYr6TOt6c5?=
 =?us-ascii?Q?ruAN2hqa7Y/efudnyGvIyLxACl0uywF1hVek7Fh4lZGqmO99BESKfEQWSKJM?=
 =?us-ascii?Q?88e+6gAuNbgJUKy2teJC?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a48ff0d-5d79-4fe1-d5f9-08dc58fcf3a8
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 01:24:22.4137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR20MB6833

On Tue, Apr 09, 2024 at 03:08:17PM +0200, Michael Opdenacker wrote:
> Hi Inochi
> 
> On 4/9/24 at 14:27, Inochi Amaoto wrote:
> > On Tue, Apr 09, 2024 at 01:13:32PM +0100, Conor Dooley wrote:
> > > On Tue, Apr 09, 2024 at 03:17:35PM +0800, Inochi Amaoto wrote:
> > > > On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@bootlin.com wrote:
> > > > > From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > > > > 
> > > > > This adds initial support for the Milk-V Duo S board
> > > > > (https://milkv.io/duo-s), enabling the serial port and
> > > > > read-only SD card support, allowing to boot Linux to the
> > > > > command line.
> > > > > 
> > > > Hi Michael,
> > > > 
> > > > I think your patch losts the board binding and have wrong compatiable.
> > > > Also, the SD can have rw support with proper property. See link [1]
> > > > (need 'disable-wp').
> > > [1] doesn't go anywhere useful.
> > > 
> > This is my fault, I copied the wrong url. The right patch is
> > https://lore.kernel.org/r/20240217144826.3944-1-jszhang@kernel.org.
> 
> 
> No problem, I found out.
> I confirm that using the "disable-wp;" property does the trick to make the
> MMC writable.
> 
> However, it wasn't mentioned in the above URL...
> 
> By the way, do I really need those under &sdhci0?
> 
> + bus-width = <4>; + no-1-8-v; + no-mmc; + no-sdio;
> 
> My board looks happy so far without them ;-)

FYI, Jisheng. Could you share some suggestions?

> Thanks again for your help
> Cheers
> Michael.
> 
> -- 
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>