Received-SPF: pass (google.com: domain of linux-kernel+bounces-137858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <TY0PR06MB561132DF147C037093A1B94D9E3E2@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <nycvar.YFH.7.76.2404031347540.20263@cbobk.fhfr.pm>
In-Reply-To: <nycvar.YFH.7.76.2404031347540.20263@cbobk.fhfr.pm>
From: Allen Lin <allencl_lin@hotmail.com>
Date: Wed, 10 Apr 2024 10:58:13 +0800
Message-ID:
 <TY0PR06MB5611D1BC58464EEE3AF612DE9E062@TY0PR06MB5611.apcprd06.prod.outlook.com>
Subject: Re: [PATCH v2 0/4] HID: Add support for Himax HX83102j touchscreen
To: Jiri Kosina <jikos@kernel.org>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor@kernel.org, 
	benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TY0PR06MB5611:EE_|SEZPR06MB6301:EE_
X-MS-Office365-Filtering-Correlation-Id: 6d4c1162-3d3b-4191-e0a0-08dc590a191e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	T+uqz+gP9DALFO4E77S63kFX+cQ0vWCHsqe3O3uNtRuG927qbW9E4s9GVjyykNpbenXhzdNAzkNGx5V17MWJuuQeqw65ANDhXM4kvnOCk5EQtgUtluxwoABmVGVbb7cmgkJcnYiAckyiLz9m5EMkKHDIrTejAaGWfGcd+ciKd7L9d6e37fK6RAAwtLSuPlVGvhu3loMmTuofJUKssUDRTO77eAaHVGLQbJyxnhPiTI/1LXBZUpFf6dtawNTr1JM1eZ/BVk+WW5m3+oHYXlJGf50HDvUYQyBUrbFv7ujH9+OVmy8w7Qq9SvOvhbaen17DfQCBfitXsVLlV6cwBmAPKVrs61RtCABW7DzqJJQ2aOzglFsSpfuxGn+dPvbh1LX5rXWpttkFlkAYJRKMS/ET9Ch/f8c6UXjhTIoBBm8udgYVenJ1DNl3UvHqiX+SngRqsU7qp41aZ1Zrul5/iajukUiPFaOhkpS2i/HqLoe82l8Njk/iUNj4VbySMl0wufwy5xgDQqxbrTrA4ukhiki+yFFqF5zJPLrKathhfD9LU/VM1ze1fzhlbuxKz/7MOWtC
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?LzBoYjF4WnFXeWRJQlF2dTlFOFFUZjdPWE84YUg5UlpHY1hHUnlGQUxTaXpp?=
 =?utf-8?B?K3lQYTN2ZkU2bWREY0FNNk5TSmlDNGtaS0QrV05OVU02amptZUFudTh5RmFK?=
 =?utf-8?B?aXh4T0Y1ZnlDeUlsdjVsMWJLSmxBUU0wMGxiSUFkbSs0LzRmaHVIVU41R1V3?=
 =?utf-8?B?cDR3eUpXNEZkT05ZcWZjR2doTmlySnFVR2VxU2FkdWt4YWkrWVZsTmFXZ0dj?=
 =?utf-8?B?MkxRdzUrem9Wb1BlSUt3ZGdrUkJXLzU5WHo1N3gvcnlwUFRCNnZzTjdlWmUy?=
 =?utf-8?B?ZWNacjFMRFMyaEo4UXhsSmhvTndtY3g4VHNKNWxGNjV4QWFsMndQckwxT1JP?=
 =?utf-8?B?RkRSSlpxMHJhSVFObFMyeFNOMFIzY0VEQ1B1ZkFteUUvWjl2QzZhYlRlNzRn?=
 =?utf-8?B?ay9mdVhlUXJrZDAvd1FZZUptQkc0SDZvdnF3MUhUT0poRWppaWtsc2lpa2lM?=
 =?utf-8?B?aHg3dy9za21tOCtwdU9JakVJTTFZWE5vN0FZSEdjdCtGVHRjeDI0U1N4STZh?=
 =?utf-8?B?MjlMdmpBZ080M2NQZGY4T2g5U3B1cm9QS1NLSlhjQ1Y5QUdZdHpPeTZqYXN0?=
 =?utf-8?B?U3hMMzREdW8yK1ZlWDZvK0ZRMGxPTFNxVHFFM3h1RHBkUHl4ckUvMzBweGM1?=
 =?utf-8?B?Q1d4QUFkTUl3TjdsOTB5clRwOUdwSGdYTnNlZ3NEdjdzOHluRmd5L0xmMDls?=
 =?utf-8?B?RmRsWEZCNjByS1dnK2RvdmpyZ1FhM3MwYytkeTNKOFh1clBwNGtZR3BlQTVv?=
 =?utf-8?B?RUM4MWMvbzhhN29pbVJiQzhMWVdpdXFaN0xaY0JEMGxyMWQ2Y3UyclppNUIr?=
 =?utf-8?B?WkJMTlcvY3lVUDNrUldZWTZCSlp4Ulk2Mk90NGpwdUY2YkY3QlRZMy9HK2FS?=
 =?utf-8?B?Z2R1SjBrWVVodk1nZ1F2SEt6SUp6VWsybjFnREpURXY4UFI3a21Pc3l1c1Nl?=
 =?utf-8?B?ZUZxQmUvSzFOeGl0RFlXNGJ4L0l6YVlpckRUWmJkdW80Z0xvNkhHbjVXTWdu?=
 =?utf-8?B?K2lLRUc0QXIzOU5XcWVKYk94S1N2UmVSK3BITHF4THJmNU5xWXhnRkxXQjBn?=
 =?utf-8?B?T0pGMDBaOGdjNTZXeU9QSGVSTjVRL1E3Mm15aU5hMW9rZjZjK090dU9MWWVj?=
 =?utf-8?B?elhGUDlVd2xJc2dobVB3T3dod2xxSk12Rm51b3NtN2wyekl1V2I2YzA5Zysw?=
 =?utf-8?B?NUZDV3YzQzk0YXVoR0EyQldSYVlaREdHS2Fwejh1QjdlYm5CSjlPNk15eDZl?=
 =?utf-8?B?MjdaUFl3ajBaVE8rYXZ4NEJ0M1Q0ajVGS1h0UjlvcVZRVks0aGtGSEZkTzhw?=
 =?utf-8?B?c0ptT0tTd3JzMVZmS0pKVDdoZ0k3Vy9BV1Zld3JKRytUOWZJZXZXU3lYTTVJ?=
 =?utf-8?B?Y2ZpaVpidUplSjhmUGtsK2pUWjZlWWFyQ2ZxdTVhSWZud3REbGwxODdrWVJJ?=
 =?utf-8?B?R3pTMmJyUWxueVlLOGlVUE1YNVZETWtlemluNkh4d3QwQVRscngzZ0NFTHpB?=
 =?utf-8?B?S2tYMjdDemFCdlRKMXQ2SjFrdDNUdzhMdDFKV01jZWxWTVRlRkcwTGlKNGFr?=
 =?utf-8?B?T2hIVTVlRWxOb2NRR2tla2hXeUdYWDEyaldRdkNoMTdEYlNPTDlRZko0V0Rt?=
 =?utf-8?B?VklRMXdndTFrRllSZ1ZVTG9OeUdhekVTSW9IVGMrc2h4LzA3ZXBoN2xzUGYz?=
 =?utf-8?Q?hPADOImNZJBQzAulsHke?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-3208f.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d4c1162-3d3b-4191-e0a0-08dc590a191e
X-MS-Exchange-CrossTenant-AuthSource: TY0PR06MB5611.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 02:58:28.8460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6301

Jiri Kosina <jikos@kernel.org> =E6=96=BC 2024=E5=B9=B44=E6=9C=883=E6=97=A5 =
=E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=887:48=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Tue, 2 Apr 2024, Allen_Lin wrote:
>
> > Hi,
> > This driver implements for Himax HID touchscreen HX83102j.
> >
> > Using SPI interface to receive/send HID packets.
> >
> > Changes in v2 :
> > -Added power description in YAML document.
> > -Added ddreset-gpios property in YAML document.
> > -Added firmware-name property in YAML document.
> > -Modified the description of pid.
> > -Modified the example.
> >
> > Allen_Lin (4):
> >   dt-bindings: input: Add Himax HX83102J touchscreen
> >   HID: Add Himax HX83102J touchscreen driver
> >   HID: Add DRM panel follower function
> >   HID: Load firmware directly from file to IC
> >
> >  .../input/touchscreen/himax,hx83102j.yaml     |  100 +
> >  MAINTAINERS                                   |    7 +
> >  drivers/hid/Kconfig                           |    7 +
> >  drivers/hid/Makefile                          |    2 +
> >  drivers/hid/hid-himax-83102j.c                | 3071 +++++++++++++++++
> >  drivers/hid/hid-himax-83102j.h                |  460 +++
>
> My only nit here -- could we please call the driver just hid-himax, to
> follow the pattern we generally use in this subsystem (drivers named afte=
r
> vendors).
>

83102j is our IC name, we add it to our driver name to distinguish
different ICs,
Can we just reserve this in driver name?

Thanks
Allen

> Please add Ack from Rob, rename the driver, resend, and I'll apply it.
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>