Received-SPF: pass (google.com: domain of linux-kernel+bounces-137896-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 9 Apr 2024 21:40:33 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>, <ira.weiny@intel.com>
CC: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>, "Navneet
 Singh" <navneet.singh@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
	<linux-btrfs@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 09/26] cxl/region: Add Dynamic Capacity CXL region support
Message-ID: <6616184163627_e9f9f294c2@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-9-b7b00d623625@intel.com>
 <20240404112628.0000633d@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240404112628.0000633d@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hTOsV+o0KjgxpfaJgDeJYraFC1QjDreM8zutzk3VY7wLg/sM9wuI92UqLpyK?=
 =?us-ascii?Q?/kmrCFakdFoW6jBYxIInOs7KCd7Mhpd/lsY8ZFpBsfS4TwLWZiEIycJA/5rS?=
 =?us-ascii?Q?DPyORvRQzdsGv5peD4nhsu3/cLrwKoJMlh8ikbjXmSf8UYc67bwmUCM+cxN8?=
 =?us-ascii?Q?wn3daEWmi6g2q4gBih/UdAfODZipDlZvSEl+2PV6YGcsYaZRGyyEvA4cPYPS?=
 =?us-ascii?Q?VMkS1JXDtRJgZ/dPIdBSc0Z6E8eSeJK6q77G/EGWyt9sWymoap1evDFg7bIj?=
 =?us-ascii?Q?N84I3i02X8Ia4a8d9q6RgsGh0/HU8Wcs+9xG5Bi0+HpOgLEEgug44o6zyZGt?=
 =?us-ascii?Q?S6SHgv+nNNeP13ISFG1cTWCnqgbfhCUpPItqiz48nRLFEdhyBqBmLn7fXede?=
 =?us-ascii?Q?9C3fqr0Wm/M2TPbLqOJPb8Uluw/pV7V8PQdi02qMCwsr6eZNnxEf7BZEVw/Z?=
 =?us-ascii?Q?9+8C5HejbeMLCgvAY3OLxr+nqKSBL0GIWw9sGu0NXPmP35aG0WfrSDnAEscw?=
 =?us-ascii?Q?T/vQ0/nyUn10DMpMze0Zmd/46NXHL+79Rmu7D80kwuDajV5NZfDL+4LItlmt?=
 =?us-ascii?Q?V3URQo4A8vyOop2X03LwBkbhiWx/ulju0UGYcncva1PRcG9b1YsTkmj43KUy?=
 =?us-ascii?Q?nEaI9PxiOh3fLyrAAdGkr3Hb7pPHVdD0HgG/2wL2tvRleeiaqKKf4XrhpS2/?=
 =?us-ascii?Q?F7Vv579gBNdyHwt0hYamCiIOLjiiPPxftBgPFVEoxAdWkA3jINXPXtbJV5/Y?=
 =?us-ascii?Q?c265qlNhzaDJ297+8RlOeqv8T2xrGD7Q3FKcm1ziPDbImxU8I6znyiFfC858?=
 =?us-ascii?Q?JjVpjzp/0C5WaP5l5hOquN4vCc5kaWakGpZkXaTVbwddcjOCtBdXn0dfhs+j?=
 =?us-ascii?Q?YEX1jFeAO464WZzxwaKlxmX7rRwBHxkeJMwf7tNtE+or9ITBKRyjieCyf1Gq?=
 =?us-ascii?Q?V8tyNvVR6iSe2rPgrmg5KFg7jM0TmfPt+upU5/vrZof4iWWWX02A2wzsBwkS?=
 =?us-ascii?Q?78Q6TTNqeIAwgi1bCtMgddttYrdwWoMqsPd4S2vvyj5i7WUbZCuRnDjycktz?=
 =?us-ascii?Q?Zfx6JYdCAin2CsAOr8XLpJ+9ZNGSO0dtq/Md0Fdo5GhNBFIs1CI/+wEkBiN0?=
 =?us-ascii?Q?QR08kbxE+KG4npJ3I7cQIgAitVSvwacpYQ+OBgOVQTfoIREEIb57AgBLBN43?=
 =?us-ascii?Q?p2yrvlfkILMQVy2X5HSWlED0r7HX0w594HMieo7T0no7kMD6WvvfS2QNIf+A?=
 =?us-ascii?Q?hxh4I8NajkhINu0aLsjeOUbyKAtsLPZgI2zXbQxDPrqiXUgBgkS0lzsbOPY3?=
 =?us-ascii?Q?QZRRxzSa2UmDVg/omGBtSzHRaFGtiIaMu12Z5clnds2Zubw0WJv/l7JcajOs?=
 =?us-ascii?Q?e96StdhP7LH0xvpVO27Cg+uM8vDFhfwonkYVVFU0AiJznqXSCxLwI1IlKPds?=
 =?us-ascii?Q?sobp85jL2BPLlGWIFFumJguQdE+IgxGxu27e9lyLl+/QMkIiEPo77RQ2S1nz?=
 =?us-ascii?Q?12iEAnaNoR0ld9+lHW8GTIoT0DeMm4ix6mpvZB+WNQwlENEaYxrwq42L7IRa?=
 =?us-ascii?Q?LIQuDQV7wzvnKmz0zJsnFGg8tFukYd3kaBp3NF9F?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 86329e63-d52a-41e0-8e0f-08dc59185d80
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 04:40:36.4173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sT9Gz97oVwgbAAiXwaipNVxyRBGaUC/ZV8vihc9TZhSeIEhZgZANFjYuKgFgH46JScLgLFNq14avfCtBbzJq0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8279
X-OriginatorOrg: intel.com

Jonathan Cameron wrote:
> On Sun, 24 Mar 2024 16:18:12 -0700
> ira.weiny@intel.com wrote:
> 
> > From: Navneet Singh <navneet.singh@intel.com>
> > 
> > CXL devices optionally support dynamic capacity.  CXL Regions must be
> > configured correctly to access this capacity.  Similar to ram and pmem
> > partitions, DC Regions, as they are called in CXL 3.1, represent
> > different partitions of the DPA space.
> > 
> > Introduce the concept of a sparse DAX region.  Add the create_dc_region
> > sysfs entry to create sparse DC DAX regions.  Special case DC capable
> > regions to create a 0 sized seed DAX device to maintain backards
> > compatibility with older software which needs a default DAX device to
> > hold the region reference.
> > 
> > Flag sparse DAX regions to indicate 0 capacity available until such time
> > as DC capacity is added.
> > 
> > Interleaving is deferred in this series.  Add an early check.
> > 
> > Signed-off-by: Navneet Singh <navneet.singh@intel.com>
> > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> With the -EBUSY others addressed LGTM.

But the other docs do not have that notation.  Also the EBUSY was not changed
from the previous documentation.  Only the text for DC was added.

I'm inclined to leave this.

> Fan's duplication comment
> might be something to tidy up later.
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks,
Ira