Received-SPF: pass (google.com: domain of linux-kernel+bounces-137898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <60db8c70-323b-4e28-8869-6f8166515aec@arm.com>
Date: Wed, 10 Apr 2024 10:13:16 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] selftests/arm: Add signal tests
To: Muhammad Usama Anjum <usama.anjum@collabora.com>, shuah@kernel.org,
 linux-arm-kernel@lists.infradead.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
 Anshuman.Khandual@arm.com, suzuki.poulose@arm.com, ryan.roberts@arm.com,
 rob.herring@arm.com, Catalin.Marinas@arm.com, broonie@kernel.org,
 will@kernel.org, mark.rutland@arm.com
References: <20240405084410.256788-1-dev.jain@arm.com>
 <20240405084410.256788-3-dev.jain@arm.com>
 <1ce0e9c7-0bd3-47c1-893c-3ea5aa95fef5@collabora.com>
Content-Language: en-US
From: Dev Jain <dev.jain@arm.com>
In-Reply-To: <1ce0e9c7-0bd3-47c1-893c-3ea5aa95fef5@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 4/7/24 02:58, Muhammad Usama Anjum wrote:
> On 4/5/24 1:44 PM, Dev Jain wrote:
>> This patch introduces two signal tests, and generic test wrappers similar to
>> selftests/arm64/signal directory, along with the mangling testcases found
>> therein. arm_cpsr, dumped by the kernel to user space in the ucontext structure
>> to the signal handler, is mangled with. The kernel must spot this illegal
>> attempt and the testcases are expected to terminate via SEGV.
>>
>> Signed-off-by: Dev Jain <dev.jain@arm.com>
>> ---
>>   .../selftests/arm/signal/test_signals.c       |  27 ++
>>   .../selftests/arm/signal/test_signals.h       |  74 +++++
>>   .../selftests/arm/signal/test_signals_utils.c | 257 ++++++++++++++++++
>>   .../selftests/arm/signal/test_signals_utils.h | 128 +++++++++
>>   .../signal/testcases/mangle_cpsr_aif_bits.c   |  33 +++
>>   .../mangle_cpsr_invalid_compat_toggle.c       |  29 ++
> Too many files/tests in one patch. Break this patch logically into multiple
> tests for easy to review and follow.


In this particular case, I am not sure about the utility of doing that.

My idea was to put the wrapper infrastructure and the individual testcases

into a single patch for ease of comparison with selftests/arm64; this will

actually help in pointing out mistakes or suggesting improvements.

>
>>   6 files changed, 548 insertions(+)
>>   create mode 100644 tools/testing/selftests/arm/signal/test_signals.c
>>   create mode 100644 tools/testing/selftests/arm/signal/test_signals.h
>>   create mode 100644 tools/testing/selftests/arm/signal/test_signals_utils.c
>>   create mode 100644 tools/testing/selftests/arm/signal/test_signals_utils.h
>>   create mode 100644 tools/testing/selftests/arm/signal/testcases/mangle_cpsr_aif_bits.c
>>   create mode 100644 tools/testing/selftests/arm/signal/testcases/mangle_cpsr_invalid_compat_toggle.c