Received-SPF: pass (google.com: domain of linux-kernel+bounces-137899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 9 Apr 2024 21:48:45 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: fan <nifan.cxl@gmail.com>, <ira.weiny@intel.com>
CC: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>, "Jonathan
 Cameron" <Jonathan.Cameron@huawei.com>, Navneet Singh
	<navneet.singh@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	"Davidlohr Bueso" <dave@stgolabs.net>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
	<linux-btrfs@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/26] cxl/mem: Configure dynamic capacity interrupts
Message-ID: <66161a2d18c7e_e9f9f29463@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-13-b7b00d623625@intel.com>
 <ZgNWYdTMv8gjiKj9@debian>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZgNWYdTMv8gjiKj9@debian>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HElyP5ZSkDbLEu5ZQkdDJVGJ2EMU6xMc0M0hMduqQNVy2DyvCoMEDjP78MR9?=
 =?us-ascii?Q?XzyPHWK6wxi1Kw3FDa6fPk0UtaNPiRte7cfoEVwxATFjNV5IpssByAfc28ee?=
 =?us-ascii?Q?x8AGSTaao7DBMBaPMzwTnSSAAN73EHpVqm6FHfCsh6UWDT1y0DXClGWLI3W3?=
 =?us-ascii?Q?vBhcVMlx7LIeqxI5ylCRmcvNGk0thBgsmQIUCr/8oJ8Gq0wfRuJLAN2OsrMQ?=
 =?us-ascii?Q?2Ofo8UMjBavBEDhXrMSdzia0hiel35+jZXNFgLC4AXLZC1tB84Hlt3+5HbG7?=
 =?us-ascii?Q?QyF8ooKXlMsqNO7tdtm8VL2JhyBubLHGpEXnU4BaWNGWxyGfPsAJY0JX2yPK?=
 =?us-ascii?Q?GqSGG3SX/cgMrUkrsTW8OVyuT/Sn+DIPxyBjLGav2PZm6hxx879+YWzcViHd?=
 =?us-ascii?Q?L9EqbF2SftYtmrSIRlnu+xackh32a8+5FFC0zI+dn13QuFc9c+jzkkeIM14M?=
 =?us-ascii?Q?hAktrvm1//ebug/F6ngt8bikhBFKnx03jw5HLBTwLwVemJc6tzjrLGRX3pnM?=
 =?us-ascii?Q?we/5J8xFYiqLFYHvdzxe5/7UYWrkE0ZO5I6eyKNUKfP4AnbDQbvIXon1FcN8?=
 =?us-ascii?Q?F06fUJr1uYTtg8/63Uw2wnfbID937+Z98N4/xa0FBl86QePYqFb/HSHDkEUC?=
 =?us-ascii?Q?pWdpmun2tS7wUge2gYXn8LVPbWAQzNDKkb2vWoBEpJ4sLQUGPnUrzP9wQTiN?=
 =?us-ascii?Q?ynQH8rryTRrOdGilhP/u0G309dzS6p92k5dnfavOPgLCpXA/2Ogfb2qb7JvT?=
 =?us-ascii?Q?LT4+5Lz4LYklBZyJHpi32lHV8vtjMuWz0APIf4aaxlxawtM9/XcxVnrsjpeD?=
 =?us-ascii?Q?3I8nxxLYhF8h7EYq5dZWD/EgLkSoAXtvULrOli/cHOg92joyY+JBv0ULHUo6?=
 =?us-ascii?Q?dF3WiJ+/MGz7smhh8vADwrZfF6A26Phk2vt/uKbH4JmlrSTdTX0kGCHjzvpU?=
 =?us-ascii?Q?6aBddDAbAGrwUQWiCpsEMOCioaCoTcEuOE2Myj+kBxxKbEYdvkssna6Xl5mE?=
 =?us-ascii?Q?VyfJyb6MVUAG5HNGm0+0WW6Ul6rYGD6TyH9o+ZzIktum3ltpO5RsNOIV4k8l?=
 =?us-ascii?Q?SHFpFUKZVqkQOGtNGKGgUBnr4X+jfahlhF4t9pGXOpR+N4QjB8WtJN/oXobw?=
 =?us-ascii?Q?X0WKZtTDfYy/IzqC685dKRwbl0btKjZ6IaUHabeB3l8SdvII4KJUcGh2kUJY?=
 =?us-ascii?Q?HxcDUuTou4t2ujFQ8OGUbViKkf7s97ji/iP+eFDmNldDwfvprZH1/Ey3BNO5?=
 =?us-ascii?Q?t16Aj0bowkScvj1fwbVFgmahoKCIJI1g6Ruux2JphbAGt6eH18f6i1uLjjp4?=
 =?us-ascii?Q?mXylBA1RHTDufkttzN+JvT07CIw9/m+7OAPDTAyrb9eWvOYuR7Ek5CvMPVXS?=
 =?us-ascii?Q?p0r708+xEgiP6ROColNxxEPmaZ9v8LFfCoqZ3Yz2nZ2CAG6sgz76TF2+zWpY?=
 =?us-ascii?Q?0rPsS5L/W6VDX0KTroPw30sGcFY3vy4EnB2hmSdQSUvVc1cLaVwxAGQ3Q4Gl?=
 =?us-ascii?Q?tlid+bE0TkyQtZM9JBZvBXZumSJMfR7WDcDmods0Ovfsz1fuhsQk7BwTHdSC?=
 =?us-ascii?Q?nV/9EdLixAUO0swJca40jlZWarTz1iRKPw681zL3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 81a11be0-1396-4998-2d26-08dc591982d2
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 04:48:48.4894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: trXOzywNGLU2X37GmT85uT2JDHunMiE1MuGtDZqw6aZcSehQqAlWjMqqMFgkZpjkI5IYrKwfoCioylNRofVk4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8731
X-OriginatorOrg: intel.com

fan wrote:
> On Sun, Mar 24, 2024 at 04:18:16PM -0700, ira.weiny@intel.com wrote:
> > From: Navneet Singh <navneet.singh@intel.com>

[snip]

> > @@ -786,12 +830,15 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,
> >  	if (rc)
> >  		return rc;
> >  
> > -	rc = cxl_event_irqsetup(mds, &policy);
> > +	rc = cxl_irqsetup(mds, &policy, native_cxl);
> >  	if (rc)
> >  		return rc;
> >  
> >  	cxl_mem_get_event_records(mds, CXLDEV_EVENT_STATUS_ALL);
> >  
> > +	dev_dbg(mds->cxlds.dev, "Event config : %d %d\n",
> > +		native_cxl, cxl_dcd_supported(mds));
> 
> The message will print out two numbers, seems not very clear. Should we
> translate to more straightforward message, like
> native_cxl? "OS...":""
> cxl_dcd_supported(msd)? "DCD supported": "DCD not supported"?

Perhaps but it is just a debug message to know if something is wonky with a BIOS configuration.

So I'm inclined to leave it alone.
Ira