Received-SPF: pass (google.com: domain of linux-kernel+bounces-137914-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 10 Apr 2024 07:10:43 +0200
From: Louis Peens <louis.peens@corigine.com>
To: =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= <ast@fiberby.net>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Taras Chornyi <taras.chornyi@plvision.eu>,
	Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Yanguo Li <yanguo.li@corigine.com>,
	oss-drivers@corigine.com, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Edward Cree <ecree.xilinx@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next 1/6] flow_offload: add
 flow_rule_no_unsupp_control_flags()
Message-ID: <ZhYfU/KUBHIAZffi@LouisNoVo>
References: <20240408130927.78594-1-ast@fiberby.net>
 <20240408130927.78594-2-ast@fiberby.net>
 <ZhT/E1qDsMmMxGwb@LouisNoVo>
 <2c7bc566-c975-4dd8-a17c-10c7b9ff3928@fiberby.net>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2c7bc566-c975-4dd8-a17c-10c7b9ff3928@fiberby.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?TScVoaT07VgkEfKIbwIWPefp4AHszer/OY/uYgJ05jDthY2s9V50SSNuvR?=
 =?iso-8859-1?Q?ZZOtOZvQ5fblPfxPh1E1P9EMx/v64wxKtdjkfP2sqE5HtMtMnD9Rg/6JbG?=
 =?iso-8859-1?Q?kqN9Lw7h4P/0+h845tXDXt/DjsZUPM9D4XA7c8iYwmqegdwQIc4CcfUuYn?=
 =?iso-8859-1?Q?BV3YT7Pi3jf2Zdmg3yaFpyyxSw72Y1CdDA6UIhD6umdq+VXwDlaznscTfK?=
 =?iso-8859-1?Q?51VuTlCaa/bucvmAIbQU5VnDDV5cgbxZkUn9y0NradB1096JL/l1sf3zhq?=
 =?iso-8859-1?Q?iuZKD5HOrTuK2eZLCplksLznwerkvgnt8XC2dgfugQS+zAeFJUVmBR/vGA?=
 =?iso-8859-1?Q?dI84MoSgiFg85AlRNh7RYr1IknI0ys76GEjw968KcvuG5u1pHvUcd5wvUZ?=
 =?iso-8859-1?Q?1nfqV9fMrm06Xpe/bVj2Yw3/CSbgnRYdN+JsH1SpSwRTlOmMyn1mAabI+F?=
 =?iso-8859-1?Q?tiu6dtVfGxyfWv6HWAIz/6mvj92gI2KfmLAb7cGP9KGuE6l4JcX13+afyD?=
 =?iso-8859-1?Q?tCQsXhv+t4kUBCBpHMsAmOoJuG8Y3D7w7FFVZu1qNL1prvxvclhWoium+6?=
 =?iso-8859-1?Q?U4S3HqqIws3ejDswpFBIsf36ZZOLJMGRdboO6br3BKsCpgBIfZda6k6M/w?=
 =?iso-8859-1?Q?0kp5RUMYPgYAjVdq7pFGHPaejlvlRjx3gyRcBacB+Avl48q6qFlQ+p26Hh?=
 =?iso-8859-1?Q?tH39iM30C5zDIPhRI+0FlddD4RLBzTdQG95xy9xJnfLnirEHTv5IkDVAWI?=
 =?iso-8859-1?Q?B7Vt3bhC1qtgyDJSIeYUoN0t5H5+Z3mxWAgSh4ohk4Py23rmZLF6B1PbX0?=
 =?iso-8859-1?Q?oSyWjRWN5+z05K7MGmmXagtGkHrkwS8Ht8Spok5dkMOz/Bfyh0KkcyMxrE?=
 =?iso-8859-1?Q?i+Ae6LgMC6AMozdF1/u2OJk0P/3Aq+fftayNXjGJGzWR6n0mJLro5Zh9sg?=
 =?iso-8859-1?Q?HQtqOLoFKCOw76tkSnL15eGiVmkq1VZ9p2NXJNWx1qtE2zaCZactuNmDMs?=
 =?iso-8859-1?Q?DLO5i/iHPVCqvK99+QQKjTT3olwzvPmTsA05T6EY9T9q9PDIFobHwS6RHC?=
 =?iso-8859-1?Q?BQ5/g7VxspaKi+/0iJZlD2V4NY1IjwOMFx7ne1y0H7pUPQKIDCPgaFNeDg?=
 =?iso-8859-1?Q?8VBogGZt3yf1y6vYMX0lc8pypFWjDCcD6XsvF3vzCiANlKFwLVpMlr7UXu?=
 =?iso-8859-1?Q?6fzrdkbx8QutLvIq/KWF1z4U3NMsF3dOAgkVI6iRLMGpDCccAkwAyA2tQk?=
 =?iso-8859-1?Q?Q23wJfOiarL23t5zFSFYcqsktOialjScAIqJExpMUHWwYxxk2sQoTFJMqF?=
 =?iso-8859-1?Q?HTeR6etUvaLsZYecqrG3kKL8s5i/fh3SoFcFkiU4+TwRlwLz/XrsZan8tA?=
 =?iso-8859-1?Q?dW+YCVsK3GblJ0+B79/nvJCSBOKw1q8Sg4odTIVAtmwNrKUGuj20L0on/O?=
 =?iso-8859-1?Q?c/40IGfqZrjQ5Fd5XPm92DwUoA7GmFYRbkQQaUmZ29gMvprB9DZqy2l0ki?=
 =?iso-8859-1?Q?93pf1K2gXNsEdIr8XV0QAmr3g91YH4VVXJVPNbtjdTFVZtj+X8YX9/POL2?=
 =?iso-8859-1?Q?p8ryY1UJlmxAnwpcOjc8yHN0GkpfcYiL/SWV3KbSSqpKSCQrAhUlwZ41w9?=
 =?iso-8859-1?Q?RMT3Od1+cfdjqap1M7/zZQvg0Q8E+U6tAduh4t1K/3aVK4KrDNHrdhpA?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca14c86c-3254-4396-57b7-08dc591cbda4
X-MS-Exchange-CrossTenant-AuthSource: BL0PR13MB4403.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 05:11:55.6623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GiJb3fUffX8vuJflxWYslf6M3UM6nuArGFHjkGqPuWWkteHl0bWVnrTa0pqL7Dpu3vFpViMR36ekouhg/x7VDHskr65Snd9p0GWesBi4nzQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4923

On Tue, Apr 09, 2024 at 11:13:22AM +0000, Asbj?rn Sloth T?nnesen wrote:
> [Some people who received this message don't often get email from ast@fiberby.net. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> > > +static inline bool flow_rule_no_unsupp_control_flags(const u32 supp_flags,
> > > +                                                    const u32 flags,
> > > +                                                    struct netlink_ext_ack *extack)
> > Thanks for the change Asbj?rn, I like the series in general. I do have
> > some nitpicking with the naming of this function, the double negative
> > makes it a bit hard to read. Especially where it gets used, where it
> > then reads as:
> >      'if not no unsupported'
> > 
> > I think something like:
> >      'if not supported'
> > or
> >      'if unsupported'
> > 
> > will read much better - personally I think the first option is the best,
> > otherwise you might end up with 'if not unsupported', which is also
> > weird.
> > 
> > Some possible suggestions I can think of:
> >      flow_rule_control_flags_is_supp()
> >      flow_rule_is_supp_control_flags()
> >      flow_rule_check_supp_control_flags()
> > 
> > or perhaps some even better variant of this. I hope it's not just me, if
> > that's the case please feel free to ignore.
> I agree, I will update the naming in v2:
> 
> flow_rule_no_unsupp_control_flags             => flow_rule_is_supp_control_flags
> flow_rule_no_control_flags        + s/no/has/ => flow_rule_has_control_flags
> flow_rule_match_no_control_flags  + s/no/has/ => flow_rule_match_has_control_flags
Hi Asbj?rn. I like these, I think it will follow much easier, thanks.

Regards
Louis
> 
> --
> Best regards
> Asbj?rn Sloth T?nnesen
> Network Engineer
> Fiberby - AS42541