Received-SPF: pass (google.com: domain of linux-kernel+bounces-137930-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 9 Apr 2024 22:26:59 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <ira.weiny@intel.com>, Fan Ni
	<fan.ni@samsung.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	"Navneet Singh" <navneet.singh@intel.com>
CC: Dan Williams <dan.j.williams@intel.com>, Davidlohr Bueso
	<dave@stgolabs.net>, Alison Schofield <alison.schofield@intel.com>, "Vishal
 Verma" <vishal.l.verma@intel.com>, <linux-btrfs@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/26] cxl/mem: Configure dynamic capacity interrupts
Message-ID: <6616232345637_e9f9f2944@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-13-b7b00d623625@intel.com>
 <918e6a48-10e1-42c4-86aa-ddd63d785e16@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <918e6a48-10e1-42c4-86aa-ddd63d785e16@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C/YxTKaSBNceg9HX7n13ZcffAbVXHxaum93Vtcy4EwHrSvvV/0GLA7HbVe2x?=
 =?us-ascii?Q?fXjlCASQib8zuAmc4PObjiqOCAVycH63/a3rHPeP8CbqGIxQuoknpp/4FQ5a?=
 =?us-ascii?Q?wIpc33wLSplfkIliYyrFAB1BEdouHBdknXXaMFC14NmaD9U7UdmEdhHxPFId?=
 =?us-ascii?Q?sXQiWiLHACwaM2UsNIE8ED5KBB0N8i/S9L5lt041rUoF2JiD46Leo2zmZ6W1?=
 =?us-ascii?Q?GZOtt2ua6EYfZ8KKCQcNTSjTEY8/4rKFQZMfn5YCL+rgYAAKW5HkYykhfFIb?=
 =?us-ascii?Q?t1jUsuVUx2o1kDPyfKz6HoGtkHC5cerQr0zEDZoRKUW38USSjwAM5hfSgTG/?=
 =?us-ascii?Q?Vns7x2tV1OlnBZWwGLRVu13OAa0xcfM3y9zX99Lp9j2U2K5GBX96toJM9wTz?=
 =?us-ascii?Q?DSquKTdBR6Q7ZFXlBO/Iw6LLTlZW+kkXnusmw3Cli2F9XPaix5rptXXEr6Pu?=
 =?us-ascii?Q?bjmfro9UPLaIjzPAnfoRV4LXPkz0ryHmt6YOGhdaSaovLsB38/CeSR0w5Igp?=
 =?us-ascii?Q?h1sg2uSUXApTTstHsUDasFAzEBVCXRHw7RY6084uUZ5CX5IRdhnM/obOqdbb?=
 =?us-ascii?Q?oobNyADs+qQysN/rOhOIX6aFBlU5ZVPuKAzVu7ma1QtNSgwVAWWgnVLmvWWs?=
 =?us-ascii?Q?nVh99vxNW8OYJGLfG6jZ7qRzs6KGAjD6VItAblTv6qbSVf06c7ZH6Mb5pDRh?=
 =?us-ascii?Q?y0ZzRVhg+CosrSPlejQq9gKYHLeNlAt7zUJr97w9C8ZoRzTfJdelId//xsdm?=
 =?us-ascii?Q?plGVyfn2cNKqDk7sUtsp0SRHPWoy8uoyIoDWsBPxZik7kEazpDCjzwJDd0lL?=
 =?us-ascii?Q?fu1NRxvtob+l7Xj5rGI6pc693wRcQKJOAD4hZV1oQQgfjh9g2tFKaU9F5FJm?=
 =?us-ascii?Q?m1TPnK2BS3YHwyGZY08j7vqhZN5o53syJ+ajMLNLizvVidJMSSIsZB0hultp?=
 =?us-ascii?Q?k6eivxjUgjZTxxPdIfMP0njsyANYFr1RILN3TjAnnb8Kmoml4WegfhuIPCjv?=
 =?us-ascii?Q?AX+WQkqx5gORbnhaBsYtATWqyoryyjjAKmcNZybfvBbHkXIgMHTOWRxIeqZs?=
 =?us-ascii?Q?4rsUbnacdZJVe9p3GmWaRvR/bJsIn1HR6STRuH4yrTmS3ts8FRvRGkeQB8rZ?=
 =?us-ascii?Q?uSYXHHXYO5pvfV1U0ecxj4R/B2fc0JE/lK97pkYBq08Bxb+JK2u+fSKV5vpV?=
 =?us-ascii?Q?N62bvqJRe/f2i1cEgJxVdIYsjA3zXpICoo3V6VRbS34ZvmH9u9sp1Ge7k50b?=
 =?us-ascii?Q?eVBJUhQ/sBRLzhFTsrId2Fjkaw593LmJc2PGrcRFwAq9YkD14p+Fjgk8NAeG?=
 =?us-ascii?Q?Cx0djqAb8tJId3kTEwKuRgvGuT60I0WqMQfnSQIzO7jZp3t7F4W4FlcS7qlF?=
 =?us-ascii?Q?up2E1D9fc0sAk/K5pq1ZkTcaUR2RnXMW3xw6lPrVwKSjai6uGH2Uo1Zi6F6v?=
 =?us-ascii?Q?ODQYjU08HnXz31WVuIfIX9jQ04WvOnWaCZ2eIxBojN5hCt/kmNf4rhhUj4rl?=
 =?us-ascii?Q?YamhlIspku40Apa+Bay5gyiCnUQKBYB7E+oQV9ac21wRoF9kPFuqmnHLTJaX?=
 =?us-ascii?Q?U4A8QA2izD2pGW81uUW5Mm4dVcFOmSvMhdHf4lJP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54283148-1f8b-4957-be6a-08dc591edf96
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 05:27:11.6291
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5lyzqpH4kp+KSKN+5gRViwe3BXoP7Wi6/4onYKSZYhLSL9mfxdwaj2WKQ5fakKkryxHmIpl368IVWnc9vnvByA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6546
X-OriginatorOrg: intel.com

Dave Jiang wrote:
> 
> 
> On 3/24/24 4:18 PM, ira.weiny@intel.com wrote:
> > From: Navneet Singh <navneet.singh@intel.com>
> > 
> > Dynamic Capacity Devices (DCD) support extent change notifications
> > through the event log mechanism.  The interrupt mailbox commands were
> > extended in CXL 3.1 to support these notifications.
> > 
> > Firmware can't configure DCD events to be FW controlled but can retain
> > control of memory events.  Split irq configuration of memory events and
> > DCD events to allow for FW control of memory events while DCD is host
> > controlled.
> > 
> > Configure DCD event log interrupts on devices supporting dynamic
> > capacity.  Disable DCD if interrupts are not supported.
> > 
> > Signed-off-by: Navneet Singh <navneet.singh@intel.com>
> > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> A few minor comments. The rest LGTM.
> > 
> > ---
> > Changes for v1
> > [iweiny: rebase to upstream irq code]
> > [iweiny: disable DCD if irqs not supported]
> > ---
> >  drivers/cxl/core/mbox.c |  9 ++++++-
> >  drivers/cxl/cxl.h       |  4 ++-
> >  drivers/cxl/cxlmem.h    |  4 +++
> >  drivers/cxl/pci.c       | 71 ++++++++++++++++++++++++++++++++++++++++---------
> >  4 files changed, 74 insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index 14e8a7528a8b..58b31fa47b93 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -1323,10 +1323,17 @@ static int cxl_get_dc_config(struct cxl_memdev_state *mds, u8 start_region,
> >  	return rc;
> >  }
> >  
> > -static bool cxl_dcd_supported(struct cxl_memdev_state *mds)
> > +bool cxl_dcd_supported(struct cxl_memdev_state *mds)
> >  {
> >  	return test_bit(CXL_DCD_ENABLED_GET_CONFIG, mds->dcd_cmds);
> >  }
> > +EXPORT_SYMBOL_NS_GPL(cxl_dcd_supported, CXL);
> > +
> > +void cxl_disable_dcd(struct cxl_memdev_state *mds)
> > +{
> > +	clear_bit(CXL_DCD_ENABLED_GET_CONFIG, mds->dcd_cmds);
> > +}
> > +EXPORT_SYMBOL_NS_GPL(cxl_disable_dcd, CXL);
> 
> Should these one-liners just go into a header file?

Yea they could.

> 
> >  
> >  /**
> >   * cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity
> > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> > index 15d418b3bc9b..d585f5fdd3ae 100644
> > --- a/drivers/cxl/cxl.h
> > +++ b/drivers/cxl/cxl.h
> > @@ -164,11 +164,13 @@ static inline int ways_to_eiw(unsigned int ways, u8 *eiw)
> >  #define CXLDEV_EVENT_STATUS_WARN		BIT(1)
> >  #define CXLDEV_EVENT_STATUS_FAIL		BIT(2)
> >  #define CXLDEV_EVENT_STATUS_FATAL		BIT(3)
> > +#define CXLDEV_EVENT_STATUS_DCD			BIT(4)
> 
> extra tab?

It does not look like it on my end...  :-/

#define CXLDEV_DEV_EVENT_STATUS_OFFSET>->-------0x00$
#define CXLDEV_EVENT_STATUS_INFO>------->-------BIT(0)$
#define CXLDEV_EVENT_STATUS_WARN>------->-------BIT(1)$
#define CXLDEV_EVENT_STATUS_FAIL>------->-------BIT(2)$
#define CXLDEV_EVENT_STATUS_FATAL>------>-------BIT(3)$
#define CXLDEV_EVENT_STATUS_DCD>>------->-------BIT(4)$


Ira