Received-SPF: pass (google.com: domain of linux-kernel+bounces-137934-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Holger Huo <holgerhuo@outlook.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
 Holger Huo <i@holger.one>
Subject: Re: [PATCH] drivers/nvme: Add quirks for device 1cc4:6a14
Date: Wed, 10 Apr 2024 13:31:50 +0800
Message-ID:
 <ME3P282MB2481225B8B95249FB92E4981B5062@ME3P282MB2481.AUSP282.PROD.OUTLOOK.COM>
Organization: DragonCLoud Networks
In-Reply-To: <ZhYCyuP6vTJq-TZq@kbusch-mbp.dhcp.thefacebook.com>
References:
 <ME3P282MB24818FA28E7C73BC01302882B5072@ME3P282MB2481.AUSP282.PROD.OUTLOOK.COM>
 <ME3P282MB2481C1DC0506D154FA3AA3D2B5062@ME3P282MB2481.AUSP282.PROD.OUTLOOK.COM>
 <ZhYCyuP6vTJq-TZq@kbusch-mbp.dhcp.thefacebook.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: ME3P282MB2481:EE_|ME4P282MB1349:EE_
X-MS-Office365-Filtering-Correlation-Id: 63c71ac8-011d-4ff8-cca1-08dc591f9b1b
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	X7l4t8du0ijBPeZK3LfBQtF1RfInjSdCxoes/uocTmUWQxILN6mTBwnXs0fEaTCKLYRJz8cPbAykflebMSxLMnznWD+YpBp35eDQN7Ra/zDWU0MOSILmZlSnSc6YMMVsLQdA3C2onhRkSNQ0Wt7C18HVwUl6t5TV3YVdByCMg7QnjPwXHnN36qJ7noku+kIGPHdSA68ghnIfG8W8H5x8emR+RKBi3tGUMgJgMlxAQUlROZTZpZpytDs7TeDZ0mRVZftG20qLvOfkTKOhGCZO/OXlvEg1VK6qI0dKZSxhdifSL5RgFVxBqc3wH9wwro1PZ6igGVb7VissyVqdPIdTquINlXuemedP9kNTkCOC+6XCYJ/NPW9DA/Rch+5C2rckllfF401yb3bKZbXqvlkBh6uOaT4Bk0VRd9p0oAhIKk+qMNWXVDAzCts3XHHebi4xPnETL/Ddd9/N21UaRrxhdFVBvNp1VPrgCM9BHXLkkpSc5vLCUSN2Y5N5wHH01LYLG9XdoW/iBSoHCSrtxpzSdb31XtMpwBy/6N6du0Gr+2O/Y0CEYBA8LvZ7Gs/m/XY0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YjU2TGZYR3h4dVRNaU1STDZqdFU1eWJuZm5WTHVMVTJSTjU2dnZiWTBrTjJZ?=
 =?utf-8?B?K3RGYXRTQm93RGtUNHFPZERsR0ZpWG02SXVVbEphUjJrWHpKRVpmYVJmbEtr?=
 =?utf-8?B?enpYQTZxL0hoSGwwQWpSWjJRWDBLTk41dUxEOEw3bmZLZHZnM0VITmdJM0x4?=
 =?utf-8?B?d2NlYkVwcU1oeFV2Tmx3SHRDSUk0THo4ajE4REJSWkxuZEtKakZ1b2hYckds?=
 =?utf-8?B?NHc5anJKWDd5b0k0SHhTRnB5UmtNMkZ3eGhQdzF3MXdjN3Yrb0VGb0hnb0F6?=
 =?utf-8?B?N0xUWG1DV1BPNG1mU0UzL1FJcC9UeVZhVzNHdzkxVXNoNDludzduSFZCNGMy?=
 =?utf-8?B?NkJBRmR6VEFNUHBNYlRRa08ybHFvVEVLZDdxb2dlSXl3RGUrNm5oK1M0RWRI?=
 =?utf-8?B?K21Xem03MUdSZndqQ3hIeS9TWnNWQVBVUkxUd3BJeVZjcGVNRmlnNG94NWJC?=
 =?utf-8?B?UkR4RXlCQ3kvOG85L0tEZG1lVTZzeURlY2ovTUVBSU9NU3dEOWh5d0Y5WE1a?=
 =?utf-8?B?dlc1L1hHV3JhWkgzZUVEdnEzTjdvTVVQaDRmNFlsM0llRVU3RS9mRHRCL1cr?=
 =?utf-8?B?UDk0Rzd0UTNkcTVCSHMvMWlYVFRUVHlaZ3N2ZHpCUmUvOEM0WjhzTWlxVWY1?=
 =?utf-8?B?TXpmam0yT200Q0JOMFU1V3FsczRnUmhsQVFaY1o0UGVzY21HVkdYWVZ6Z1hp?=
 =?utf-8?B?YTVHbE5UZ1kwQlRuQ0FmOUF1dWgvMDFUeEp6eEtOQXpQenlLWXB2SGdzaXJM?=
 =?utf-8?B?TDJhdkxBWjFkODB1ZWZBS3NJSjhYTlB2cHdsMnM3czgvdng0amp3OHhBNlRY?=
 =?utf-8?B?N3Urd3VWSFQwSnBXeEJCWlVzZndrb1Nrd1pPekQ2cXVOWmhZNEcwdWxXNXVt?=
 =?utf-8?B?bVloQlhLcyt4ZDFydnJ1YTdpTXdQMjFSTEtQVys2bC9PY3hKVXlFelhIMDRO?=
 =?utf-8?B?RXRaM3R2Kzg2dXA1MlNQUGFuYitKbGtsOGJRSU1GR1B4MktwQTVsV0tMOWxu?=
 =?utf-8?B?VEZ1MkJTRXQ0WlRWNzM0blo3cHV5aTB1blNGbmJ0cC9sUVl6YkorNmZlbHBX?=
 =?utf-8?B?RUdNUEN2aHhIdGVISGhybENrZTBZc0t4TmE2aDBkTlRSbURHM3htQWY1Qk5s?=
 =?utf-8?B?MWxKUUk4azBURjk3TVRFSjBHRHRJaHdxZkpOVitPOFpwcDMvVnlHSW8vUnJB?=
 =?utf-8?B?SHI5YVcwcDM1YU9JM1BGNTBGdHZLUTVhakdLcE9WK1hXUmFiQzRhY0htZWhw?=
 =?utf-8?B?K0tGRE00ci82RFlhb2FEZkxXbXFTdDdadWtxSXhtOUFZN2gzUWJnK2tNei8x?=
 =?utf-8?B?RW41ejBhRnVEd1VKejIrSTBub28rcUM3NWpHaW5qWU9oQkRXNm5HYkVRakYz?=
 =?utf-8?B?Q1orRDViKzBGT3VPVjVQZGRBQ0hMOWthUllEUUk1RVZFK1BxSkFJZDJxV0dm?=
 =?utf-8?B?ZTVLSmpNQ0VxU0YvTERIVnBsN0tHU1I4TzBScEd2SWUzdU1GMGdsRUowcEtB?=
 =?utf-8?B?KzgrcEpXNVp6VXFHNjE5TkpSay9zZ2dDUVRPcUJ2dHRUeHROQStVb3hyRXk1?=
 =?utf-8?B?VEZJS085Z2tPZDdCQ2ZVK2d6TW5aTW5hbG5vd0FzbE5FY1FhUEtGR05GTi81?=
 =?utf-8?B?VnNzTGwxS3VkUzBJS0xTbTdtVjlNSnRqcS9LZDF2TEtHTUEwWGRnckVHcTZt?=
 =?utf-8?Q?78USdcI8acaWTRHBdayh?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63c71ac8-011d-4ff8-cca1-08dc591f9b1b
X-MS-Exchange-CrossTenant-AuthSource: ME3P282MB2481.AUSP282.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 05:32:26.8845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ME4P282MB1349

On Wednesday, April 10, 2024 11:08:58=E2=80=AFAM +08 Keith Busch wrote:
> On Wed, Apr 10, 2024 at 10:05:46AM +0800, Holger Huo wrote:
> > On Wednesday, April 10, 2024 4:14:42=E2=80=AFAM +08 Keith Busch wrote:
> > > On Wed, Apr 10, 2024 at 03:28:50AM +0800, Holger Huo wrote:
> > > > This commit adds NVME_QUIRK_BOGUS_NID for device [1cc4:6a14], the
> > > > Shenzhen Unionmemory Information System Ltd. RPEYJ1T24MKN2QWY PCIe
> > > > 4.0 NVMe SSD 1024GB (DRAM-less), which can be found on many Lenovo
> > > > notebooks. This SSD produces all-zero nguid.
> > > >=20
> > > > Other SSDs manufatured by Shenzhen Unionmemory Information System
> > > > Ltd are likely to face similar issues, but I currently have no
> > > > device to test.
> > >=20
> > > Are you using the most recent stable kernel and still need this patch=
?
> > > These quirks shouldn't be necessary anymore unless it's advertising
> > > multipath capabilities, and it doesn't sound like this one should be
> > > doing that.
> >=20
> > Yes. My current Linux kernel version is 6.8.4 by arch. After further
> > investigation I found these quirks truly had no effects.
> > But my nvme drive still freezes with Device not ready; aborting reset,
> > CSTS=3D0x1 failures and AMD-Vi: Event logged [IO_PAGE_FAULT domain=3D0x=
0001
> > ...] waking from s0 (s2idle) sleep. Are there any other quirks or what
> > that I should try
>=20
> I've seen the IO_PAGE_FAULT error reported before, but all I've heard is
> that it means the device attempts to access a memory address that it is
> not allowed to. I don't know why that would happen, though. I've never
> first hand experience with this condition, I'm just as confused.

Thanks for your help! I found this to be IOMMU related and I have to set=20
AMD_IOMMU=3Doff to have it working. This is not nvme driver related. Sorry =
for=20
making this patch.