Received-SPF: pass (google.com: domain of linux-kernel+bounces-137935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 9 Apr 2024 22:34:08 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>, <ira.weiny@intel.com>
CC: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>, "Navneet
 Singh" <navneet.singh@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
	<linux-btrfs@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/26] cxl/mem: Configure dynamic capacity interrupts
Message-ID: <661624d07d41e_e9f9f2944c@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-13-b7b00d623625@intel.com>
 <20240404162245.000032f3@Huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240404162245.000032f3@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YAAfVjf8lDfmt7f+40ku/vJSYtAvcvqGaGpG4lg9PfD5xWPQQ2kdiqVD0JlN?=
 =?us-ascii?Q?4kyN40X8xzoyMDemfL9KfUAPDeenYPlGxU2ebUHbTa7OOeeIqclMIIFU8EOX?=
 =?us-ascii?Q?seoBcrxYOyfeVe3lSPD7PQX8hgfxOHt1SynCQlo9mWcUaVe7n2G3VaxapTty?=
 =?us-ascii?Q?5gDbKDVFkrZOvCXMuO+eDT4N1amWAnF8BZlsCjjigIu5jkxLEWpbJbXTolUv?=
 =?us-ascii?Q?cc5RoEGPdJNtnsEu8jBvXe3gTNCb/DGqtUYTiJ4nMKgE7umvkSSvxRCs76w5?=
 =?us-ascii?Q?MipmVsz8WvYWIizl67wHUCROwAzLAktAQCoLM05RnWdBTHxO4JhhXb0tyd4x?=
 =?us-ascii?Q?azwpLQIBZ0rBAE2SB7XG3re1UAME+hDxqPma+HDXjqtlbAXERQ607ZukETnP?=
 =?us-ascii?Q?ObcVteMqRhpUPFhO2BWBkmHUhbeDZ6ZUYa4Kp+a2eaSPCNPhuqEuXRPqCLwG?=
 =?us-ascii?Q?gJzSXmt0fMTmyu60ivcyXMUtf6R9DOxTqYmVd8++ully1NEoVZb6wCoFT6AW?=
 =?us-ascii?Q?HwtGtBbFqyxS1k/sIyhJ1q93oSazL0LHYboAIMDEVlincvzsIHac3pti0TDd?=
 =?us-ascii?Q?+zXhgVZqMLYXCxyXGrv7JHAQXHlYH5lfk+ROSW/XLCYx3pdpm1R/k+fITB2E?=
 =?us-ascii?Q?mlvTO3LCnWkxQwcM5MgvXLJnvgcUXv9ZAdW30Vj0og6mDPDH59dCuwrk/JIY?=
 =?us-ascii?Q?oh2hBGRxWFZe/r5K9Y8GFsVuE6oUYQUbW0XdJnJvxCjpMD4kv3quImrw67H3?=
 =?us-ascii?Q?IG+GmAEEvOS9H+j7EDD6P4g6EfOpkVgl+Vq3zVsPc+snGH/bJgIx5mi81BLz?=
 =?us-ascii?Q?N4lFFMM1Gb3ELICoe1qnNmT3VfL2R9ComPo6/ejLj5NUmRDNVSMoSCYNXx/a?=
 =?us-ascii?Q?EcQ858gkm7SynSkd6hpgCfiB6RoUxdShba8Rcfp1jc9ZCC32lt6iBwjRIcyW?=
 =?us-ascii?Q?PCYTHBCf80sTqKocn8/AFcn5bfwdusAdBEuVvsip7bJ0GeOF6V46LrE/5KBc?=
 =?us-ascii?Q?0Q0T3/TpyIJA2UxyJMroJNspdul52yrI6mdLTWbwlLU2pC65Jwgj5uBfmvr9?=
 =?us-ascii?Q?V152vaza/TSE0HFXYyh3rXErO4eGvaj2HZlnCSbRxPq4TtCfZDsXuCbh8wKQ?=
 =?us-ascii?Q?yJx0IQzG/zo2h2Es3CuH8ymkeVbpFGE67S71umkUvEtsMRIM51Sg/mAj9tSz?=
 =?us-ascii?Q?wvuhxMhSiiZbT9q6MoBikYeDVgxroMM5oySIeWSBtlXQ3K1v+Pr0UxN5C39Y?=
 =?us-ascii?Q?juXMoGGM+iei82uH2x7dpOK2G0noa83/eVgvYVOrCNgmAY+SHF8Wmh1dz0qo?=
 =?us-ascii?Q?YBXJMDwssjLlyfIJuf0PTgWzl8oQqIBDh7/koxQrh7vFGfLSlYkvnzhfD4D2?=
 =?us-ascii?Q?dLOkt30G8NU6QC4R/cjDAFcegWXoTvXVcMAtg+wXgZweQi61oKwCZQ8A5DoR?=
 =?us-ascii?Q?OeeVH0uz2/e/Fqr1EBrt2PH/9YSEihMToZ17zKS7IHtOVD+IlJZ1q8Yhfx8v?=
 =?us-ascii?Q?RB7bKWtHuCgBMIOc5KDMMk9GIh4g0uzm5GutS2T58EL79XUISJYMA9luWzy/?=
 =?us-ascii?Q?SotkgVkMEuiIGA9+ehqDoXWKgfVDcousRu+eYWgz?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bdb6634-c1b6-47de-81a1-08dc591fd9d1
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 05:34:11.3843
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gEG7muFt73CrIx9+jchkQRSCSH13rPNRULDx7dpI5YbbZ3tKj8AWleZAWFOQN6F5zsIAB6WpByp24Y1VaagICA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6431
X-OriginatorOrg: intel.com

Jonathan Cameron wrote:
> On Sun, 24 Mar 2024 16:18:16 -0700
> ira.weiny@intel.com wrote:
> 
> > From: Navneet Singh <navneet.singh@intel.com>
> > 
> > Dynamic Capacity Devices (DCD) support extent change notifications
> > through the event log mechanism.  The interrupt mailbox commands were
> > extended in CXL 3.1 to support these notifications.
> > 
> > Firmware can't configure DCD events to be FW controlled but can retain
> > control of memory events.  Split irq configuration of memory events and
> > DCD events to allow for FW control of memory events while DCD is host
> > controlled.
> > 
> > Configure DCD event log interrupts on devices supporting dynamic
> > capacity.  Disable DCD if interrupts are not supported.
> > 
> > Signed-off-by: Navneet Singh <navneet.singh@intel.com>
> > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> Trivial comment inline and Fan's suggestion on the debug print seems sensible
> to me.

Ok I went ahead and added it.

> Either way
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks,
Ira