Received-SPF: pass (google.com: domain of linux-kernel+bounces-137945-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 9 Apr 2024 22:46:38 -0700
From: Ira Weiny <ira.weiny@intel.com>
To: fan <nifan.cxl@gmail.com>, <ira.weiny@intel.com>
CC: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>, "Jonathan
 Cameron" <Jonathan.Cameron@huawei.com>, Navneet Singh
	<navneet.singh@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	"Davidlohr Bueso" <dave@stgolabs.net>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
	<linux-btrfs@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 14/26] cxl/region: Read existing extents on region
 creation
Message-ID: <661627bec82e_e9f9f29416@iweiny-mobl.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-14-b7b00d623625@intel.com>
 <ZgNZ2Fl8vdW_qm_I@debian>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZgNZ2Fl8vdW_qm_I@debian>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sp68NsdIsbCXD95ymZMHSnPZr/4oMlia+9ttg9auDX8NSQufcpryOXCCSYsb?=
 =?us-ascii?Q?zSkdiQczsLEh8VtDGpozqIgMmPOTJl5l/t9vZpczSmPfVmrCSPfZJ7d2Lcej?=
 =?us-ascii?Q?yWC7KTxLigf9SYlvEvqUVvQFoNj/2zhQcRHlNgTFnqWT2gQOepS0A3sumLiC?=
 =?us-ascii?Q?J7h6z8vbQvdpdn3JoUsb3Ug0N7I2Gd5QqECzdKJv1qCs8LR3604pEfAsgDyb?=
 =?us-ascii?Q?XMUPaW2q0cc/iO8D5f+pvLaWweyVpemwxweYf963nS1pAgV1GbI5QDky6aap?=
 =?us-ascii?Q?QN7VfRYosT4RLspwMDffRYifGmBhq4DmUOnrM7bZm/UQhAjG1ZhgwCP5WUKE?=
 =?us-ascii?Q?xhZfMUoJoPxl4la+3dtWZMB6qmJjhhP1kmcf1McaG+yT+RdhOnWWO3U/Wa4E?=
 =?us-ascii?Q?NCzQ9rKspHbvrTzOCjdIsUebw21gr8GICPezgstJ84cmLFerzaGA46MQKiqf?=
 =?us-ascii?Q?S881OYsPxg7/+dDkLQKbPSMjEZM7nZWPYIsa3kGuqDFXfP4gR1z1IbpwaBwK?=
 =?us-ascii?Q?mrcivMde3Bzha7ap2sYogwvXsoLFjZ3QB+l24INWBOO6cGNt2xkYeAxV+4kH?=
 =?us-ascii?Q?POyha+3QoUbbu8+PHek3ciJck26J4nRdEmG9wBderhOLLlCtq7suOpsTOj61?=
 =?us-ascii?Q?n1xXZvvQdIJejOwCfALwQ16P9Xxa+b88adTnTvK2V8Jh076lu0nwrL7l67j9?=
 =?us-ascii?Q?xtiOteg2gyRjWefkcoR9EmFEyoAeeGlWH4g4habmZ1UP9PiaGZ/RPLzEzMYx?=
 =?us-ascii?Q?LSQl1DkSnyJzsmcr8SHCB5ERUf5Tv4oJHzkbG5/gqKNhZNJmXEX7x8F/eSnu?=
 =?us-ascii?Q?zMxM5e063MQGdYS5YH9D+gzkqH2AwACHDsygdI1FURMOZGLmxL0MBxunRTo0?=
 =?us-ascii?Q?puRJ77vLRRRxbGb6Rc0W2FVfFzfgO7cHiyAbdqnTXlOIClaB8LLsac5sTNwI?=
 =?us-ascii?Q?5mAQ3sZV0V7uH/0Gn41/8N2i3TMtjodl9C3FEeGVg2kdkjTaLM/m/ILBG0Te?=
 =?us-ascii?Q?TXHIAFTKcYNqh79c0eA+cadPurfRjwE/Z5B3IgXL2pchNsm9uRfMbRNqtsRs?=
 =?us-ascii?Q?578OgAQIaKD6IW4ERlTniBaRwFIagDkzB7loveV44S4G2kD11+5MBlWjfNMn?=
 =?us-ascii?Q?WXxpwUkl9bwewd5/N/qvKxg0EgfIyJCrQCsvmnSAi4VJVuofpODCR8I+686w?=
 =?us-ascii?Q?5J/mleqQ6P/OYyHsfv1T50ODMbkClppxhoCStapucPJhUFow/eWKdYwh433B?=
 =?us-ascii?Q?hPP4cH3BVVu03S18/IZpP115SL1If9DjZYg+e+nmI7bOvRedDt4K/J8Dy6ca?=
 =?us-ascii?Q?FbSv1SMtH2pphvb5tKfnW0H3v20u6EA+FM0ndIaM4KBmKmjGsX5riOQdPzqA?=
 =?us-ascii?Q?JTxJ/I0bEVMJZINmKH+r5j81M4gQdDKjvDh7dlbZ7TVsyxvlhub12w5e2n4L?=
 =?us-ascii?Q?1b5aszV2RGXtTFyURc0tFoNpFpIMqB0bmcx5FZvuUYq54foCLJvhyJz5O2OS?=
 =?us-ascii?Q?9y9ga0XpfPyDha3K5B/Q6WshmdVoSQCam8v9nMShxs1gEETfOt/zJQIFrsIE?=
 =?us-ascii?Q?v2+uPx4iO6y4I57YA0UfeS+chGlJpOhnJ8itEcfp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 52541052-7057-41ed-ad12-08dc59219878
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 05:46:40.8156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 58139wzUrdpUVRLP3V2/8hitUBYU6ymN19DtFH3STltsvafEqs5Rtq2NtMcS+aOAjDIhnWYSuzxNS0fRf+3TWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7924
X-OriginatorOrg: intel.com

fan wrote:
> On Sun, Mar 24, 2024 at 04:18:17PM -0700, ira.weiny@intel.com wrote:
> > From: Navneet Singh <navneet.singh@intel.com>
> > 

[snip]

> > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> > index 58b31fa47b93..9e33a0976828 100644
> > --- a/drivers/cxl/core/mbox.c
> > +++ b/drivers/cxl/core/mbox.c
> > @@ -870,6 +870,53 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds)
> >  }
> >  EXPORT_SYMBOL_NS_GPL(cxl_enumerate_cmds, CXL);
> >  
> > +static int cxl_validate_extent(struct cxl_memdev_state *mds,
> > +			       struct cxl_dc_extent *dc_extent)
> > +{
> > +	struct device *dev = mds->cxlds.dev;
> > +	uint64_t start, len;
> > +
> > +	start = le64_to_cpu(dc_extent->start_dpa);
> > +	len = le64_to_cpu(dc_extent->length);
> > +
> > +	/* Extents must not cross region boundary's */
> > +	for (int i = 0; i < mds->nr_dc_region; i++) {
> > +		struct cxl_dc_region_info *dcr = &mds->dc_region[i];
> > +
> > +		if (dcr->base <= start &&
> > +		    (start + len) <= (dcr->base + dcr->decode_len)) {
> 
> Why not use range_contains here as below?

Because when I initially wrote this I (or perhaps Navneet, I can't remember) we
were not using ranges.  This version I tried to convert to ranges and I missed
this one.

Good catch!

Ira