Received-SPF: pass (google.com: domain of linux-kernel+bounces-137969-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, "iommu@lists.linux.dev"
	<iommu@lists.linux.dev>
CC: "Liu, Yi L" <yi.l.liu@intel.com>, Jacob Pan
	<jacob.jun.pan@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, Will Deacon
	<will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/1] iommu/vt-d: Remove caching mode check before
 device TLB flush
Thread-Topic: [PATCH v2 1/1] iommu/vt-d: Remove caching mode check before
 device TLB flush
Thread-Index: AQHaiwxKiFy5v0dRUUSJTg1YiSPoIrFhBm0A
Date: Wed, 10 Apr 2024 06:14:24 +0000
Message-ID: <BN9PR11MB5276AEA3AA7ED2D945745D388C062@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240410055823.264501-1-baolu.lu@linux.intel.com>
In-Reply-To: <20240410055823.264501-1-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wUO5SHaUvvhw/+N1PqLdagZZEO8SSpkdp7ktdR4FybemwTQbOLpMOhpQHpK+?=
 =?us-ascii?Q?1Ybgq5gmNKpuaynxZVeL6ZEk0as9Kc2wVcEp4UQeVJo2Ur3MD6Y0dyb5w7bI?=
 =?us-ascii?Q?YQNOXHjR9qLhO26vom2w+Y9GMvBu8rrcg500C06ZIKcIaj3+My/rc+2egIy5?=
 =?us-ascii?Q?uabk0RR//WsMq7yNhUQZV7epQfqYd2V9+sHTcAlaftpGUrJuU4L1YNj2lUlx?=
 =?us-ascii?Q?DIBbr5W9eHZ27AGZhFfcn0QvJLQsPOU6kGwaq8ahKFImU+T+YbzkEjwpYbb2?=
 =?us-ascii?Q?KLUgn8c60ZiqRpisHefiyt3pnfNJ95vY76sgqXmdRJvYU4qy0kGB2juw8eJH?=
 =?us-ascii?Q?YOiB3YBXludYfKDYujyKhfrGti/q8nBbmx/4BToSVOACE2V0Gr/Z1Q3wmWZf?=
 =?us-ascii?Q?I3dr4nO+im+BNAiEbT5e7X8biX3aRSF1cGbno8CZO/LZT3CdTHTj3ABB8eHD?=
 =?us-ascii?Q?zzNL+i4Xs4E5a0LpGu5fvEkc+HQvN9AEEeJI+iQZKV/uJp2J53v05avLQLo5?=
 =?us-ascii?Q?2NZzlH9hHZxVOxEKfwqQtbjI0FE1NV73LNpBTX50yAYhIpVceKQ6gJIYsG01?=
 =?us-ascii?Q?FWQx1ZInHLN30pT7jh8B4I+vY9fDboCNiCgg+ooKvn3xKq1JfKVEyCYC+uD4?=
 =?us-ascii?Q?oIK7M/pqTpXJtmn9VJtdNaMeCYEjL5UEkSry/btbmPGWair8anCp/mTFlnFe?=
 =?us-ascii?Q?i1kMm+TjVSiV7AV9OQ0woSgI8W9tn4QeSAHIoK289SreqYhSkrGOjaEkHpHf?=
 =?us-ascii?Q?YlZBjd7iEoV+OXDIjr1f+b1xXzNnRZA617m1fkIIOr3jdNRLtL31DKuZfG24?=
 =?us-ascii?Q?zq6tG6TYpl0pkPeJ0ctXF/cBesVX5hUt8eJy8zzRzEzodpYDzQZ/onVMjbII?=
 =?us-ascii?Q?K8VlBOdsHdxLZi9U3rXU3lmXCGRTwNm9wGpPkiKTmdGL6V71pX2laNesr37p?=
 =?us-ascii?Q?z8yBZpW+LE6A1R+rEqMMvU84migUjHmT24uGGOchfY4DyKpROGL3nxym5oT/?=
 =?us-ascii?Q?XSTgWBdp7cldKKqranOIzHOQHRyfmgRvL9YcNlrsaYboQasQowWJpQ4tauja?=
 =?us-ascii?Q?FVw1bDKQ8UQ67OWZskisBNpoLi54lAxxtbifd5ECQ8pJj9btLLH34euE1NhD?=
 =?us-ascii?Q?4dUjoyF8dnz9hejE2OnLJk5psvrV9KQD9d8vig7b6Xs3bC4v338A5aJC4K8f?=
 =?us-ascii?Q?4/SC6SnzE2sBDnUwzEVcDqgQEhKJ8+oeu5MTUcxsgW8TIa6/jlGCIOA/uC33?=
 =?us-ascii?Q?BuzAAKG+CGazgGRtdcBmnbj5tN9l98E9j12rKnbZi5DBaQ4pJzBlBA8kaqjp?=
 =?us-ascii?Q?xaBoXNuGPcMb6oWQU3OkQ7fKUmkYWkE7V18uAKGow6C3UVjjeKFxdTO7ivuK?=
 =?us-ascii?Q?/cV0xchICTKpvxbCpRtLilVdBviy1n73ukJ+0cczRMLezNUCKfMBNw7eluqQ?=
 =?us-ascii?Q?0p4dCZgGDUiyelZHK3pXgCoYiX+/Vtmz6nwnjwyzCx5Nulx67vP1N/q8tiJJ?=
 =?us-ascii?Q?EvKb9oQfA5AQJ//+5RrymHARr3wFDWvN2EU0oSYsd2dwHXcya6LKIxUnyeNy?=
 =?us-ascii?Q?Czh40TPPLxDWrQubUAVtHdMWhWCG9YZI2HGda6PN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09a6fc38-3576-4eae-8953-08dc592577f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2024 06:14:24.0788
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lQYyh9UVcI+aht65hS2L6QFTEiezlrEOA/HjOoyhJtVsII48svQNVXddxOtlnBAFuUKq0PA5NktzCguLTFaxDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5087
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Wednesday, April 10, 2024 1:58 PM
>=20
> The Caching Mode (CM) of the Intel IOMMU indicates if the hardware
> implementation caches not-present or erroneous translation-structure
> entries except the first-stage translation. The caching mode is
> irrelevant to the device TLB , therefore there is no need to check
> it before a device TLB invalidation operation.
>=20
> iommu_flush_iotlb_psi() is called in map and unmap paths. The caching
> mode check before device TLB invalidation will cause device TLB
> invalidation always issued if IOMMU is not running in caching mode.
> This is wrong and causes unnecessary performance overhead.
>=20
> The removal of caching mode check in intel_flush_iotlb_all() doesn't
> impact anything no matter the IOMMU is working in caching mode or not.
> Commit <29b32839725f> ("iommu/vt-d: Do not use flush-queue when
> caching-mode is on") has already disabled flush-queue for caching mode,
> hence caching mode will never call intel_flush_iotlb_all().
>=20
> Fixes: bf92df30df90 ("intel-iommu: Only avoid flushing device IOTLB for
> domain ID 0 in caching mode")
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>