Received: by 2002:ab2:687:0:b0:1f4:6588:b3a7 with SMTP id s7csp232746lqe; Tue, 9 Apr 2024 23:31:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWbW2uNyctiNRiMyosU7Eix0pp1l4iOBEnrJgvIw3k17j5jQ189yC73IkkEkSCqWlMwmiqMlSz80mNeZSTUkdyXBu/1HLTmAzsgsvhDWQ== X-Google-Smtp-Source: AGHT+IF7iuxtSxtEp4oXi2Wi+/V4UrhzJdcsgBaI7mKisPecqY/TqyKGe+Lx7iuMuPe0RUFk+WEt X-Received: by 2002:a17:906:e08b:b0:a4e:539d:217f with SMTP id gh11-20020a170906e08b00b00a4e539d217fmr1322563ejb.33.1712730688807; Tue, 09 Apr 2024 23:31:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712730688; cv=pass; d=google.com; s=arc-20160816; b=kmG4WXOQ1IRTFYEmzd44AGeFTZgASMtPa/te+uzVv2VRqroU9/q6W/HWhu3fJFlvEr vyA4R8nZAT68XqNW8vZj12kGIPHAaGVuElxCWihyu6MkTyJRON2mWXzLHTNE7V4iC1fU NrA7EyQtvspMEeDEvuTaBNfJVcoKB1uMS6WpdxnEHqJlLdDMVXWklVNQfEl6MIBV3HrJ VkcUW0Dg0DptXgOnD7LTywOjjSYJ0cMXBxedf4foY3H57f+/0aZ/0hMmbcxsEoeNgWj2 ZEMGLeSsoTT5c4VEQsIBZjrmkJ3Jrpxhk6C64mSoOEAag7eS8L375SMfXgqjueHH5C6j dXbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=gWci41MJZyAHUWq9dFdkgNIb3G6A9TJ1w2pD10mN2/A=; fh=+7WKDbIIy/IuQrwFqpZpo0/GQPMUUGOrKdrKhw2vQUA=; b=Dsq9E7vrl/ntEq88raXdkjEthFsev4gENR/Fep9yosnjLKwg6q349YSjsIzUssR3Nl qZZfvtcJPnbovholmcA1/GbM8X1f6ZxJdPnHstd9d9tQh3wvRKynnxQSE7o5p6N80t3T ViaskdTyZPiAOez3LMdOeK4mUYTqvX3xjA2ewRMrK++OCqYtULqcnM7hMCy1YdJy9ut8 yl4rtTl58Q3IYbEXBNv+FV4AHlDMc59XXgWIjhC2l9sD/cCTIeSXKMT6vPshwIQPfJ6n AggxBgonm5/H7oBBmzdIQYl09YZe9XLud0TAolCP14kh3J5KOgBnJU7uURuo8FpK17SD XF/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="VDRJ/0Wq"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-137990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e11-20020a17090681cb00b00a51c36021e2si3894010ejx.200.2024.04.09.23.31.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 23:31:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="VDRJ/0Wq"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-137990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2AB6A1F22547 for ; Wed, 10 Apr 2024 06:31:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4041E20300; Wed, 10 Apr 2024 06:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VDRJ/0Wq" Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4D21FA5 for ; Wed, 10 Apr 2024 06:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712730632; cv=none; b=nCu9b7uFkxQJziaFeC/FJZkP0EtzF8qTZNZ7acBOAC0etHlGV/2v8LIda9iXqerlc30OfL+PcGsUvCO4cvXpx4D7VVgY/+6AzIuKPUEVsCXljw8AitqUN2CJT6M/Wxiafnw1AovhtJM74SbEQcjt9CHQAZ2vgJrhC4+7Kj2zvXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712730632; c=relaxed/simple; bh=snLcBzW5JAfOjL33AeXOFsWB7BGPbRw5aXOn3Slj5aE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rEDwNPgq8SF2OACZlG8fmTGy/uhe4Y6fJq6LghBFSf9u3Fup/iKKPWlqZpKX9RzqIuF+UkoRkLrH3vnC/EQmvctYAin6vE5AqO9xUvxcVGGx7o4CZkNPUZC/Aedyzae1TiS8bQlgcTepwFbzE4QvogZObax5Z68BrF+EkEiohQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VDRJ/0Wq; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-41786893a0bso603515e9.1 for ; Tue, 09 Apr 2024 23:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712730628; x=1713335428; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=gWci41MJZyAHUWq9dFdkgNIb3G6A9TJ1w2pD10mN2/A=; b=VDRJ/0WqGJPukTRPFaC0F47hHej5EvoXUIR0MVumGpaXexQgu9rLomKqo/258sucxq 9Sp2mNrtWZu7CQq+xmhHOP27Xyb0eMkdUTVGPP1zeeXwQFa2/b6mduGUfoAIbdNimFCL tZLSz/7x/UDjUcMLYvKn9DIQINAFTfROM7uNx4Z9A+vlm3g2Q8KlgMAo5VaN8U5xK1IW YZX6VMrTb+6Ln4rcmj0D5NRhNAzfx/fnjtqRYQlNUCukXwgvScPZJ+c647zRkmAvMRAG tOgM/ZaxmCkw+XHcxRQWwTIzm0l+uDq3Omb+gEB7YZwMuDjsi6MqLG52berQqfQIjjsT t0vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712730628; x=1713335428; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gWci41MJZyAHUWq9dFdkgNIb3G6A9TJ1w2pD10mN2/A=; b=polZ7/FTb2nL3ctDpT2E+DbJyfjogQruMDNDTrCRKpEaIOwGFrbDzj1d/cEJ8gRlpn ve9xq6rPIXtUYxsPHuTFG5eo1Ua7bdU+1XHG/yiMEX/zaXRc1LNcySqLySzZIOlAoi+T xro4yq1t70vzzNl21uIPSbK17p3DxKsHjhSd3azj0R0GEDdkdW+dDFSZgp3eeeLwTQ0J OeWfAfvEH0d48CtX493fuRIGi4DhRf3oqpPfEVIkb9uS9iKWSXiveA2TDoOknvfGKpo4 KXhNaexY7IGUpjg7uw45bbvQtPjSQolscmo6oUtEA8xFD/mURzh5ht7jydWc9A74thDe vQ8A== X-Forwarded-Encrypted: i=1; AJvYcCVhLKmZl4sL5X9TDskHjGs330/rdXV7zEY6qHZw9UiqndSFR7Pnxyyq59q+V+tyGxMxJhmnUiaoGZ5/jS9EGYSqv9HCsXQXsz7Gxa1B X-Gm-Message-State: AOJu0Yx7nVeZ0RsDZlIMnQUle7JFKO4SnNVl7pkUYPpTHakRUv4fS0SW 39kwGmA+OKem2nZHwxvD22INLOQZZP5n9nv8dbrTmL+5613m46fR3ynx95kK+0w= X-Received: by 2002:a05:600c:4f08:b0:416:259d:b250 with SMTP id l8-20020a05600c4f0800b00416259db250mr1522584wmq.18.1712730628148; Tue, 09 Apr 2024 23:30:28 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id f13-20020adfdb4d000000b00341c6b53358sm13049534wrj.66.2024.04.09.23.30.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 23:30:27 -0700 (PDT) Message-ID: <680f8830-6cd8-433b-85b7-439070bc528f@linaro.org> Date: Wed, 10 Apr 2024 08:30:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required To: Frank Li Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, imx@lists.linux.dev, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, peng.fan@nxp.com, robh@kernel.org, vkoul@kernel.org References: <20240409185416.2224609-1-Frank.Li@nxp.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/04/2024 23:09, Frank Li wrote: > On Tue, Apr 09, 2024 at 10:02:32PM +0200, Krzysztof Kozlowski wrote: >> On 09/04/2024 20:54, Frank Li wrote: >>> fsl,imx8qm-adma and fsl,imx8qm-edma don't require 'clocks'. Remove it from >>> required and add 'if' block for other compatible string to keep the same >>> restrictions. >>> >>> Acked-by: Krzysztof Kozlowski >>> Signed-off-by: Frank Li >>> --- >>> >>> Notes: >>> Change from v2 to v3 >>> - rebase to dmaengine/next >> >> This fails... > > What's wrong? > > https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/log/?h=next > >> >>> >>> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml >>> index 825f4715499e5..657a7d3ebf857 100644 >>> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml >>> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml >>> @@ -82,7 +82,6 @@ required: >>> - compatible >>> - reg >>> - interrupts >>> - - clocks >>> - dma-channels >>> >>> allOf: >>> @@ -187,6 +186,22 @@ allOf: >>> "#dma-cells": >>> const: 3 >>> >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >> >> It does not look like you tested the bindings, at least after quick >> look. Please run `make dt_binding_check` (see >> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> Maybe you need to update your dtschema and yamllint. > > Strange, Test passed > > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=fsl,edma.yaml > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/dma/fsl,edma.example.dts > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC_CHK Documentation/devicetree/bindings/dma/fsl,edma.example.dtb Nope, you tested other patch. Just look at your second patch for this. When reviewer points to errors to your code, please investigate? NAK, fix your patches. Best regards, Krzysztof