Received-SPF: pass (google.com: domain of linux-kernel+bounces-138043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <603470e5-3310-47c4-854e-d6fc36366699@vivo.com>
Date: Wed, 10 Apr 2024 15:09:42 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dma-buf: add DMA_BUF_IOCTL_SYNC_PARTIAL support
Content-Language: en-US
To: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 Rong Qianfeng <rongqianfeng@vivo.com>, Jianqun Xu <jay.xu@rock-chips.com>,
 sumit.semwal@linaro.org
Cc: pekka.paalanen@collabora.com, daniel.vetter@ffwll.ch,
 jason@jlekstrand.net, linux-media@vger.kernel.org,
 dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
 linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
References: <20211113062222.3743909-1-jay.xu@rock-chips.com>
 <1da5cdf0-ccb8-3740-cf96-794c4d5b2eb4@amd.com>
 <3175d41a-fc44-4741-91ac-005c8f21abb8@vivo.com>
 <9e6f1f52-db49-43bb-a0c2-b0ad12c28aa1@amd.com>
 <5c7ac24c-79fa-45fc-a4fd-5b8fc77a741b@vivo.com>
 <42aea61f-52d7-4cea-9944-7130ffcf9c15@amd.com>
From: Rong Qianfeng <11065417@vivo.com>
In-Reply-To: <42aea61f-52d7-4cea-9944-7130ffcf9c15@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eGZ6SUlqTU9oU0VkSWJLUm85R28zSFpIUUU0NHZIeDVJaDFXKzFxSWFmajds?=
 =?utf-8?B?MlNYTjV2RWY0RGNxTUNIVzVLNkVweGkyQ2ZtNGhZZ29jYmVRNHZNWGdpejlm?=
 =?utf-8?B?YksxWVpQenZoVVlCRlF4WXV3SWhteFhPaXJSSk5aOFpVdENFcVFMS0c1OXRk?=
 =?utf-8?B?LzVkeDZmTDE4b0tUVlZwcm5XU0FEMVVjS3ZXd1l0U2V4TXdzYmxmQ1huVXE2?=
 =?utf-8?B?dXR6Ty95bHMwamJpOWlVcmNKM3JNSnZ0alR2WkR3OHYzUWY5NEZhWjJ0bWJX?=
 =?utf-8?B?a3JMRExPNytLSTdkQktHSDQ5a2p5UlN1ZlJYL0V5NHViaUw2TVFseGJmMDZ1?=
 =?utf-8?B?aXR2U0Voa2lvWlJpL1d2SXJBcjhHWGhFdUJNWHg1ckFoOWxnY1d4OGNTQ0NN?=
 =?utf-8?B?VUt3N0NEbGJFNjJtdmhXajdFT0NuaGlIZldsSVQyVkMyYWVJRDZOemdvMncw?=
 =?utf-8?B?N1A1VlN5S3FiNDZZRHZTTytBamJwUk5jZDAwRzR5cWVmZGl1eUdmNkRWcTJl?=
 =?utf-8?B?NUc3YThqOTY4aEhTa0p6cVpCRWdHNUozMnJMSG1LbmZLb2N1aXFFR1dBRFBw?=
 =?utf-8?B?MjJ0aVdYTjJrSkFSU1JkdkZ1cisybkJlaHVxTzVVUUxrS1F4SHEvUisxRFdn?=
 =?utf-8?B?WENrMVpDUEI4MmJpNXhmeWYvTHBiK0I1Y0JRMktWSTFwbnBnK1JkTW9sUlMx?=
 =?utf-8?B?RExnbCs2T3ovS3M5WmtNOXIxc3dHaGI4UHMyYis2SWl3VGo4a1RWWXF4eEg1?=
 =?utf-8?B?L2hCSUY5MmY5VTY2eHE2RnpVRTRoeDRlZ3BJSlNUZktKaXRWNTlQU0V1YjN3?=
 =?utf-8?B?dVRGNEhMZW5wM1YxM1h5U2RLaVBPUURtRlQxcU1UMFM5RkFrOHozYS9RemRu?=
 =?utf-8?B?LzFIWk56alNmYkg3NEhTKzBhMWROQkxCeVBYYXdOZURWVFF2TU1RbnVHVVRT?=
 =?utf-8?B?cGdXdDJYVGlmWjQ3VHZOSThieVlZWVJHKytEUG4waStMUXVVRmNpdEY0WVlv?=
 =?utf-8?B?amwyOEhTdHFKOGlSNUNvSFd4YnRBUDJkM1pRVkZ1TUg5dGJsTHlQTTYxOFZY?=
 =?utf-8?B?RXpSY0E1dE9ZcVRzM2F0RVdEdjlMTHZaR2JCNS9jTjdDTTEvb2Z4OWRLa0RW?=
 =?utf-8?B?V2orbjRlUkx6VUdvNXM2NHkvREducy94Zkd0Rkxhc3Nhb0hPV3BVdmQ1WnVS?=
 =?utf-8?B?OUhBY01mUmtydjdycm0zMEpiR3B4bFlQZmc2T0V3WWlraVM4VnprVU05bVZy?=
 =?utf-8?B?ZWpKbllYemdKNUIzakFNTEdpc3F6ay9TWU1VY2NIUTVkdU4xeS83WW1PcElT?=
 =?utf-8?B?ZEdZWXl2R2lHeXd1OG93UFlTcWU0M2dwZUlUa2NRRUNrVE5WRTIxTWpNVVd0?=
 =?utf-8?B?SHlabmh1dEl5R2Y0bU1EU29lYTQyS1NuZnNvQWZjaWo0WngvckFlWUxHb09a?=
 =?utf-8?B?SExSWFRkajhyRmQzUTU5TGIrWmpqQ3BzK0QvMEFUa2V4dTIvbHFMOCtBYy9y?=
 =?utf-8?B?TnlPWk1oamJveEpBNG5JVm5EZGpYVmhlK0dMeHhmNWhxMU9BU3V4RVlNYXNL?=
 =?utf-8?B?VXZDb281VUUvSFhHUzBrVjJmM01WSFFicGlmVGU3dVhrdmZiWitWeGVoRzVV?=
 =?utf-8?B?VFJzNUZaVVZqWTlBcDVjV040cis1TG1GVVVUY1lxbUhhMDRycWdlWnJjQWU1?=
 =?utf-8?B?M2pvVThBWWtHUUl1TlpwZ2VCYnEvcm5sQnNNNXpOdFdTWGsybE1OWmdqS0Nw?=
 =?utf-8?B?dE5nc3g3enJxWUQ4SHpBemNGT1kzdUhkeXAvaUd3WVBZTm45SXBSK3FvRXdZ?=
 =?utf-8?B?NWN2Z0VJK3hWNllpMytrbndoY3FhdHlwVFVMczB4bmRJTVpzVkozMVlvdy84?=
 =?utf-8?B?enZxS0RTZkZrMklWTE80MFY4SzBxbHhHZXJDVGRxT21OSitjTDY3VmFFRWhF?=
 =?utf-8?B?TFRSRWRZMlljM3A2TGZocCtxRGJsRUdIWEcwL0ZQdE5Ram51K0tpZDJUNXJ4?=
 =?utf-8?B?R0hTV2dGaDhaS3VDK0ttc29nRy9VczFOdll6eHNaT2J3RWdmOWo3SitBeDBr?=
 =?utf-8?B?MXlaK1JnMmZrcVpkMFV0aFpXbU1LYklwM2szN2pIMjJpVUNWdm96VTVwWkti?=
 =?utf-8?Q?g/zEwmMgSJY/3+TJNmmnQUqRM?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce586b1e-e438-4b7f-3563-08dc592d335f
X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 07:09:45.1415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r0Yqi+9nlFzCBkkc1/XSH8CeeMuHrgluBSK92rOWnXxKs40oWc3ZVShOgLt2ALui518OKRKSWcHiz6kzYmKkeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB7366


在 2024/4/9 23:34, Christian König 写道:
> Am 09.04.24 um 09:32 schrieb Rong Qianfeng:
>>
>> 在 2024/4/8 15:58, Christian König 写道:
>>> Am 07.04.24 um 09:50 schrieb Rong Qianfeng:
>>>> [SNIP]
>>>>> Am 13.11.21 um 07:22 schrieb Jianqun Xu:
>>>>>> Add DMA_BUF_IOCTL_SYNC_PARTIAL support for user to sync dma-buf with
>>>>>> offset and len.
>>>>>
>>>>> You have not given an use case for this so it is a bit hard to 
>>>>> review. And from the existing use cases I don't see why this 
>>>>> should be necessary.
>>>>>
>>>>> Even worse from the existing backend implementation I don't even 
>>>>> see how drivers should be able to fulfill this semantics.
>>>>>
>>>>> Please explain further,
>>>>> Christian.
>>>> Here is a practical case:
>>>> The user space can allocate a large chunk of dma-buf for 
>>>> self-management, used as a shared memory pool.
>>>> Small dma-buf can be allocated from this shared memory pool and 
>>>> released back to it after use, thus improving the speed of dma-buf 
>>>> allocation and release.
>>>> Additionally, custom functionalities such as memory statistics and 
>>>> boundary checking can be implemented in the user space.
>>>> Of course, the above-mentioned functionalities require the 
>>>> implementation of a partial cache sync interface.
>>>
>>> Well that is obvious, but where is the code doing that?
>>>
>>> You can't send out code without an actual user of it. That will 
>>> obviously be rejected.
>>>
>>> Regards,
>>> Christian.
>>
>> In fact, we have already used the user-level dma-buf memory pool in 
>> the camera shooting scenario on the phone.
>>
>> From the test results, The execution time of the photo shooting 
>> algorithm has been reduced from 3.8s to 3s.
>>
>> To be honest, I didn't understand your concern "...how drivers should 
>> be able to fulfill this semantics." Can you please help explain it in 
>> more detail?
>
> Well you don't give any upstream driver code which actually uses this 
> interface.
>
> If you want to suggest some changes to the core Linux kernel your 
> driver actually needs to be upstream.
>
> As long as that isn't the case this approach here is a completely no-go.

Ok, I get it now, thanks!

Regards,

Rong Qianfeng.

>
> Regards,
> Christian.
>
>>
>> Thanks,
>>
>> Rong Qianfeng.
>>
>>>
>>>>
>>>> Thanks
>>>> Rong Qianfeng.
>>>
>