Received: by 2002:ab2:687:0:b0:1f4:6588:b3a7 with SMTP id s7csp248846lqe; Wed, 10 Apr 2024 00:18:25 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXQRPT5/P7KXvO7/Lzxn37sXRUrXM7ary+MvlA05RjFJ96NEzyQIKv3dLpLXEHbjm4VVvuO7C00sSJTs06vqM03xsMj6NquPyeA6X5ZGg== X-Google-Smtp-Source: AGHT+IFvBiIPR2PMI2H5w8qBtYW1e4RzmFM3kWksA6vRW88lfeHJ+IUb9T6tRMMhIlPPLhU2Uk+5 X-Received: by 2002:ac8:5d51:0:b0:434:3f82:40e5 with SMTP id g17-20020ac85d51000000b004343f8240e5mr2317500qtx.4.1712733505177; Wed, 10 Apr 2024 00:18:25 -0700 (PDT) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m10-20020a05622a054a00b00432d45cdc6asi12661236qtx.182.2024.04.10.00.18.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 00:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138063-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-138063-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138063-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D58DA1C212B9 for ; Wed, 10 Apr 2024 07:18:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9BA2413D2B3; Wed, 10 Apr 2024 07:17:34 +0000 (UTC) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C27E13D2A2; Wed, 10 Apr 2024 07:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712733454; cv=none; b=Ku2I0hSmIwZBn/mveIDEJPNYN0lHUlu6mRZRDUac2dxZ5UYlRb3wX2UGXqhNn1bIE18OJLGmJYpJrs71VZz9RgmChdRFPkgT/RRt7TBWFAv1dkd5OizXZ0yf6ugHlGOqchqkmeEo3z6bwkjuFvyjzefRLMqi7BG92cenBo395lU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712733454; c=relaxed/simple; bh=H/2SRJZyEG+iyb9DFJEFwPWSwlCN93pqSGDbL0uBIgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q9cDT/tH2aoJhG7p1blDHO6nM+r7lMKxBA4BJRlyjnIph1ASWzpDuqqDsHzRg5GkLrT442iM1TfBiUlP3evp3fcJvWD9pt7I3oIESItOg5HGjA4FCqlHWltpSmwisOl+tSmv8LE7blzXTyshcmdynxWKV9zqydNAWFW7lVte6Uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a450bedffdfso894186466b.3; Wed, 10 Apr 2024 00:17:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712733450; x=1713338250; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fuUol7FYR59VdhQtwGyuh1y4vFucPajgfbXo16j1CVw=; b=osWQfilc/JD6OhcdzdNUNKkQ77MyC/nEJIwOV3HC/7WuILvafyHwbq6vsflPMK9ZRs ZUdoy0leCQAVqA3KSd0NCcRWvXWAfzBviVfUNIhDgo/REbYceDs8gfL4BDGmoYB6il4r FFexhqkeGYwjM4h3/y4KKbLwUT9PAp/MaQI6FmxBNK2vVOsdlyV5h6efzBprXHHPKYPD xST7bKWb0rbpb6AAILWOrPbgxpUlIBTgHlpKZe5VXzKkC7u+WlQnkadctNDAqYs/pbCc frddQf65g/r0rjDR/5g2CKFKGVOgXq07S1UXVf6zZsUIr66wPSP35868/rVI/mk99OSB R/pQ== X-Forwarded-Encrypted: i=1; AJvYcCW44WWhRvXunUmTb5Fwq6fRG64JavBT2DUyXodtONgXMvPxOKZP/8FCYEePnvzQRgEm1d/cf79cYBQpNenQILea5GiFxkVblHknQE1Q0wYTnsuEGkmK7rvrcDZlKlizaq7x/wWW+ylsQz27 X-Gm-Message-State: AOJu0YzDJkgVk4drkdVqhqn2sQEwbev2QrkQIRWhKPp3ib/TSx/d9Bze XVBjlXmug0uDbzz9mcDous/pCkuLLGsBBmIHSjlTD93WME3WV8ti382zYp6A0lI= X-Received: by 2002:a17:906:4c4f:b0:a52:10c9:661f with SMTP id d15-20020a1709064c4f00b00a5210c9661fmr396269ejw.62.1712733449486; Wed, 10 Apr 2024 00:17:29 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:69? ([2a0b:e7c0:0:107::aaaa:69]) by smtp.gmail.com with ESMTPSA id b16-20020a170906039000b00a51a5c8ea6fsm6480553eja.193.2024.04.10.00.17.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 00:17:29 -0700 (PDT) Message-ID: <889be591-93cc-4e80-bebe-04a6f8f58c70@kernel.org> Date: Wed, 10 Apr 2024 09:17:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/8] serial: max3100: Extract to_max3100_port() helper macro To: Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Hugo Villeneuve References: <20240409144721.638326-1-andriy.shevchenko@linux.intel.com> <20240409144721.638326-8-andriy.shevchenko@linux.intel.com> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20240409144721.638326-8-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09. 04. 24, 16:45, Andy Shevchenko wrote: > Instead of using container_of() explicitly, introduce a helper macro. > This saves a lot of lines of code. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Hugo Villeneuve .. > @@ -110,6 +111,8 @@ struct max3100_port { > struct timer_list timer; > }; > > +#define to_max3100_port(port) container_of(port, struct max3100_port, port) This is wrong. If you pass something other than "port" to to_max3100_port(), the third arg of container_of() will explode. Use an inline to avoid mistakes like this. regards, -- js suse labs