Received-SPF: pass (google.com: domain of linux-kernel+bounces-138077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240409155250.3660517-1-kyle.meyer@hpe.com> <20240409155250.3660517-3-kyle.meyer@hpe.com>
In-Reply-To: <20240409155250.3660517-3-kyle.meyer@hpe.com>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Wed, 10 Apr 2024 09:34:40 +0200
Message-ID: <CAKfTPtAyYbWS=NYxD6B+z3g3A3gOeQ2oD6SSAVijGHi8hi_j3w@mail.gmail.com>
Subject: Re: [PATCH 2/2 RESEND] sched/topology: Optimize topology_span_sane()
To: Kyle Meyer <kyle.meyer@hpe.com>
Cc: linux-kernel@vger.kernel.org, yury.norov@gmail.com, 
	andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, mingo@redhat.com, 
	peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, 
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, 
	vschneid@redhat.com, russ.anderson@hpe.com, dimitri.sivanich@hpe.com, 
	steve.wahl@hpe.com
Content-Type: text/plain; charset="UTF-8"

On Tue, 9 Apr 2024 at 17:54, Kyle Meyer <kyle.meyer@hpe.com> wrote:
>
> Optimize topology_span_sane() by removing duplicate comparisons.
>
> The total number of comparisons is reduced from N * (N - 1) to
> N * (N - 1) / 2 (per non-NUMA scheduling domain level).
>
> Signed-off-by: Kyle Meyer <kyle.meyer@hpe.com>
> Reviewed-by: Yury Norov <yury.norov@gmail.com>

Acked-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  kernel/sched/topology.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 99ea5986038c..b6bcafc09969 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -2347,7 +2347,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>  static bool topology_span_sane(struct sched_domain_topology_level *tl,
>                               const struct cpumask *cpu_map, int cpu)
>  {
> -       int i;
> +       int i = cpu + 1;
>
>         /* NUMA levels are allowed to overlap */
>         if (tl->flags & SDTL_OVERLAP)
> @@ -2359,9 +2359,7 @@ static bool topology_span_sane(struct sched_domain_topology_level *tl,
>          * breaking the sched_group lists - i.e. a later get_group() pass
>          * breaks the linking done for an earlier span.
>          */
> -       for_each_cpu(i, cpu_map) {
> -               if (i == cpu)
> -                       continue;
> +       for_each_cpu_from(i, cpu_map) {
>                 /*
>                  * We should 'and' all those masks with 'cpu_map' to exactly
>                  * match the topology we're about to build, but that can only
> --
> 2.44.0
>