Received-SPF: pass (google.com: domain of linux-kernel+bounces-138083-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <72cad548-e2b4-48c3-9427-53004a40ee2e@nvidia.com>
Date: Wed, 10 Apr 2024 13:10:59 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [Query] ACS enablement in the DT based boot flow
From: Vidya Sagar <vidyas@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>, "Rafael J. Wysocki"
 <rafael@kernel.org>, =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>,
 Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 Manikanta Maddireddy <mmaddireddy@nvidia.com>,
 Shanker Donthineni <sdonthineni@nvidia.com>,
 Krishna Thota <kthota@nvidia.com>
References: <PH8PR12MB667446D4A4CAD6E0A2F488B5B83F2@PH8PR12MB6674.namprd12.prod.outlook.com>
Content-Language: en-US
In-Reply-To: <PH8PR12MB667446D4A4CAD6E0A2F488B5B83F2@PH8PR12MB6674.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WStIcEFaakZ4amdmSU50UXR1N2xLZVNBNU82ZElXMVFFempVd3J1RVFCNXlO?=
 =?utf-8?B?dUZLQU9rdnhQSmVnRlN5NzlXUzdRU2FmSXlqVk1qSUgveTFGZkxuNzRtNUtE?=
 =?utf-8?B?bC83MVE4YVA0MGJTRlByeGhNeUpldENkMnZqWUpOR25DSWtzU0c2Z21vZGRX?=
 =?utf-8?B?bXlVa0t3SmR3NWNBRW9lT0xMNUJtNFRuK0pibzhMaU50WGVoazMzNHVkbzAx?=
 =?utf-8?B?bW16THluQUdpMlAwYXViTERoM3hpRktOQmpyTDI3MDErODRORTdVNjZUVDJK?=
 =?utf-8?B?dXF5MmVxK3VON25TUG55UHNoRG1tbWhtQ2dsQ0c0Tk5uU2JEd3dKS1pSQUdR?=
 =?utf-8?B?ZmNlaUJBaVZUYjdKSzJ5Y3hzY0NKbHJiZlYxQk8vdGFKQ01Tc21NcWlRV09t?=
 =?utf-8?B?aTNuMlp2dlRvbmxYcUc0UE83eGJXT3VmVFk3bXdLTnN0S1F2V2VpUE9FdmV1?=
 =?utf-8?B?VEVxWTM2VW10M245ZEJidU01RitYRFk0Mytqc1VlZy9mL0VxTFlBWG9lRjB4?=
 =?utf-8?B?OEVsdFRUSGVJb3pTeXRvd2VVWjNJSXR1N1NRVXJvbVhqVFBobHlxT290SmFk?=
 =?utf-8?B?Qi81VXNnVTJxcXRCcHZDM2NZMzFndmF0b0x0cURKMFpYOGkyVUs3T1U2Nzd0?=
 =?utf-8?B?Qi90SlQ4K3lSU0s4Ry9yc1A5Q2YyYUlwQkgxYnh0SHlBNDcyd1BJWkoySWVE?=
 =?utf-8?B?eWh0M3o5OEFsdytIVjZoV29pUnZPdHN1WitBc2NzV2Qza08weE0weHp0bllh?=
 =?utf-8?B?STlIdWFUZGtKaDgvQjJwWng2OXVVdXlFblo4czgrMmRYTVZNeGd3SUN3TWRU?=
 =?utf-8?B?alE5cG02NVUzVklOamtDZFUwRURPWFhuamMzN0JsMmVMMHFoUVVYK3l3TmQz?=
 =?utf-8?B?cm4zUCtkd2EzN1JOOUw4em5Gc3dPeHYxa2lwVjZWZlpESWRNWWJ0TDFaZHVU?=
 =?utf-8?B?UTdqc3Z4aW5EV2t5VFRxWk00NTV1bDgzOE5KNHBsUTFwQXZDUDlUdE5GaWcy?=
 =?utf-8?B?eklKMDNiem9kZjRJN09zaVVINmZsbDVOYXloUVZoQkR6MlBxeHFwcVVXNXpF?=
 =?utf-8?B?MExhZmxFM0ppS0Y0L2RXdWM1V0J1YVQxUEZTRGo2NE41eEJmemFtSE12aFR1?=
 =?utf-8?B?SFh4RjY5TXNtMlBJa2xHeU10RW1jMGNMdEZScnlzb3N2cU1CZnlvRUUrZURu?=
 =?utf-8?B?K2xVeGRaZk10TGN5VmV2SmRkWVk0L2hRSnBXT0dseEcvdFdZdW1nWDNEaEIr?=
 =?utf-8?B?VmJnZ3NCa0pmM2tWSEVob0tDendNbEJZY2daNHY5Unp6UmtwRVRsUVJEd1Bh?=
 =?utf-8?B?ZHNnVWVuMnVmelBPaHNQS0M3Z0JzZkhXUkF6MHlWVkd3dmNhTTA0aDErbElY?=
 =?utf-8?B?REYyZDZmTEpVbG9DQU1zOHZBcnVCa2JtRVRoRzIyc09wbmp0OHgrYXhObXlp?=
 =?utf-8?B?ZzdlT1ZaY3ZBVEE3NnhndHNpV2dNaW5YWHVPSVNzTzVtUGFsMjl0bXFuRWR0?=
 =?utf-8?B?WWFCeEJvMmQ5RjhLNHZTUG5zSXAzTzZCQjFFanM5cTZldzN0NzYzVWE5KzMv?=
 =?utf-8?B?a1pmT2tlR0o4QXVsTlE4amFFRGxCQmJ0WE5aL0o0UDdJaWNLaklLVmdCSWhO?=
 =?utf-8?B?b0N6VEljTGF4Lzh5cGd2SFdOMk9tTkhPTTM1dGlRaWhJOXJ4ajEwV3B3U3V5?=
 =?utf-8?B?Sm5iR1NnU3pHNFdDQ0xzWW81Qjh1RGJPYlBxdjZIYkVhWnBNZURXZVlKbVgz?=
 =?utf-8?B?Y255M0hnU09zQU94SE5OZk4yNHVXbGFMbC9qNlpPeGl2SWRMc2R4b3M2SFFh?=
 =?utf-8?B?dVYxTnVFZmlKcEEwclp6a1VibDVPOU9NS2xkYkxTWWxWOW0vSWZjU1JvOVls?=
 =?utf-8?B?OW5vVGNucjBlM1VlbnpZc3pDM3Zxa2FUWmFpWGxWdVl0RFJFUm1CTDR1aGs4?=
 =?utf-8?B?NVRsOTdrTHZoZWpXa0ZndDlYVWNha2x6d2JRaVJDOTRISTFMWW8wRHhvZnRl?=
 =?utf-8?B?Q3dxWEhjdUhpUWdrRVNZcGNRRzNnV3NCbldBS0RhanI2WE5sQm1PTXIvTFll?=
 =?utf-8?B?bUNMN3JrWXJ6WGdnSkNyTGhVRllSM1lFT2U2UVpja2hySjJQL3p2bk9CU2x6?=
 =?utf-8?Q?683v+1NmQPQV2yhiD9suv3fpe?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c948c55-99f0-4c88-c654-08dc593195d4
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 07:41:08.5408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ui4EEwBzCAnb9deq9gtV2fgH0mLTQgzGmnssMNHucE32B+S4Malts+qtMufaCV876A5vSbEmzEjQ5SNUHIHzvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8173

Hi folks,
any thoughts on this?

On 01-04-2024 16:10, Vidya Sagar wrote:
> Hi folks,
> ACS (Access Control Services) is configured for a PCI device through pci_enable_acs().
> The first thing pci_enable_acs() checks for is whether the global flag 'pci_acs_enable' is set or not.
> The global flag 'pci_acs_enable' is set by the function pci_request_acs().
>
> pci_enable_acs() function is called whenever a new PCI device is added to the system
>
>   pci_enable_acs+0x4c/0x2a4
>   pci_acs_init+0x38/0x60
>   pci_device_add+0x1a0/0x670
>   pci_scan_single_device+0xc4/0x100
>   pci_scan_slot+0x6c/0x1e0
>   pci_scan_child_bus_extend+0x48/0x2e0
>   pci_scan_root_bus_bridge+0x64/0xf0
>   pci_host_probe+0x18/0xd0
>
> In the case of a system that boots using device-tree blob, pci_request_acs() is called when the
> device driver binds with the respective device
>
> of_iommu_configure+0xf4/0x230
> of_dma_configure_id+0x110/0x340
> pci_dma_configure+0x54/0x120
> really_probe+0x80/0x3e0
> __driver_probe_device+0x88/0x1c0
> driver_probe_device+0x3c/0x140
> __device_attach_driver+0xe8/0x1e0
> bus_for_each_drv+0x78/0xf0
> __device_attach+0x104/0x1e0
> device_attach+0x14/0x30
> pci_bus_add_device+0x50/0xd0
> pci_bus_add_devices+0x38/0x90
> pci_host_probe+0x40/0xd0
>
> Since the device addition always happens first followed by the driver binding, this flow effectively
> makes sure that ACS never gets enabled.
>
> Ideally, I would expect the pci_request_acs() get called (probably by the OF framework itself) before
> calling pci_enable_acs().
>
> This happens in the ACPI flow where pci_request_acs() is called during IORT node
> initialization (i.e. iort_init_platform_devices() function).
>
> Is this understanding correct? If yes, would it make sense to call pci_request_acs() during
> OF initialization (similar to IORT initialization in ACPI flow)?
>
> Thanks,
> Vidya Sagar