Received-SPF: pass (google.com: domain of linux-kernel+bounces-138088-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <aea3ae44-409b-4916-8e1d-5a902713a619@nvidia.com>
Date: Wed, 10 Apr 2024 13:14:35 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V5] PCI: Add support for preserving boot configuration
To: bhelgaas@google.com
Cc: lpieralisi@kernel.org, mmaddireddy@nvidia.com,
 linux-kernel@vger.kernel.org, will@kernel.org, jonathanh@nvidia.com,
 kthota@nvidia.com, frowand.list@gmail.com, kw@linux.com,
 linux-arm-kernel@lists.infradead.org, lenb@kernel.org,
 devicetree@vger.kernel.org, sagar.tv@gmail.com, rafael@kernel.org,
 linux-pci@vger.kernel.org, treding@nvidia.com, linux-acpi@vger.kernel.org,
 Rob Herring <robh@kernel.org>
References: <20240223080021.1692996-1-vidyas@nvidia.com>
 <20240401075031.3337211-1-vidyas@nvidia.com>
 <171207369295.222743.17702844066682854972.robh@kernel.org>
Content-Language: en-US
From: Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <171207369295.222743.17702844066682854972.robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0E1YlVzNFlyYVZuUDV4Z1VUdFJFUmpWWlhiN2dHaVNXM0FIOWd1bWo5bHhM?=
 =?utf-8?B?SUVoaHRRUjlZRFBKRmdvdzhNZVIwNnR6cHFmNzZSRkU0MmVXU1Zldm92Vms0?=
 =?utf-8?B?bWNWbG1CSWFZSnVVbTJaZXIvYStHd1BkS3haenRhajhOZlhabGFETWJ5eHFp?=
 =?utf-8?B?TXV0YlZWTnBXOTkzS2o3SWFBSDBmbDMvV1ZpWmVUdXZXd0R4cWtWVnlxVDZl?=
 =?utf-8?B?TUtwSWRnaDVvSStaRk1aZ21oM1IyYUtXcW9jYUhrOUZiUUZHZUlSZFFOdXZ2?=
 =?utf-8?B?RGtWZkZKZWVYMkR6MXJ4NVZhbFBoMnRWTDNzbDhYTCtTdXVhRFVNWUg5RXhq?=
 =?utf-8?B?Z1FuRkFhSnpPMFFQSlBBMFJIOVlnQjl0RVY0ekpmMVdXL3FQMjMyQUFpUFJP?=
 =?utf-8?B?eFVzRCtYT3pGc0FFcUtKNkdJdmFpMUEzYjVDUTNGZ2lLVFAvNTl3K0NyTTVh?=
 =?utf-8?B?Y1VSSHVKdVNwSldaRjE1anEyZHpieVVGYk81WXdNclNYOWVyNjNHeVFiZEdi?=
 =?utf-8?B?VExTa3Q2Ni8zdWJkbnFNVDl4TEE4c0JodC9QenN3NVg2ZEFOYUt4R0ZYYkVK?=
 =?utf-8?B?QWRLZHE3V3NOL3YzSnFxeWlxS3J2M0FvWEpUZ1o4cy9kRldlNisrNXQ3NVdJ?=
 =?utf-8?B?SmE4UENuUjk1YWNXV2RWK0hnMnducEM2R1lQa1ZNK29YVzA1TGlxOENabjJX?=
 =?utf-8?B?Si9zVFZRcFh5N0xmU0FJTnJ0Q2hTWEV6dzlZT3FtVmM0eWlzTTA4akN5eUgv?=
 =?utf-8?B?Q0NRTDlSWUhwWVRSb2VuZkVnUURuUVpHYkt4aGdLN1dkS0hVaE5FWitRV3lz?=
 =?utf-8?B?a3lBSXRFd2lDc2NpUVRFODFMQ25DZXdabTdQNEE0QXhKOWZPYzdmM0FJRmxX?=
 =?utf-8?B?TU5FTEZLaC8vdHhudEJjM1VhRlgxQmllZ25DVFk2K0FjRjc5RFMvL1N0STJs?=
 =?utf-8?B?bkoyc1F3TDhFOTZ4VmhEWjBEMzlIcVhXTGx1MGFFQ0d0QXgyOXV4TVgwNmpL?=
 =?utf-8?B?dWViZlNzMTZ4dVpPT2pSRGtGNGlBUEMvNzBiMy83cWZnTjdKb3pvZ2hiQVUr?=
 =?utf-8?B?VzJBU2ZSSVIxRjhGZjJIREFDcnVCYmFCUEF5d0ZSN21ia0dhSEhFaUdDRXBh?=
 =?utf-8?B?d2pSbWQ3Y2lqSjJCcFh2b2VFRXI1RW1XWk9ycEJmQ3gxSXVBR3g4bWhVaE1R?=
 =?utf-8?B?KytRS25NNWE4ekRncHZQcVEvUmRnQnAzUldZdTEwSkpNV0FaSFFraEUvTDAw?=
 =?utf-8?B?clNXSS9ubHdWV2tobUtBdTR2QWg3eEUzbUo0TVNPM1AvR1FDM24rZ1I5Q29s?=
 =?utf-8?B?eE5CTmpXTWU1WFhDeVhBd2JUNzhVb1kxY3p3Sk9wZWlrZTVGZUZHSExrbXNo?=
 =?utf-8?B?TFhrZFZNNEFaMGh2SUFiYXZsQm9PQWtyQ2Z1a0FZdG9Sc0lqK1FJM0RIY0ts?=
 =?utf-8?B?MGxRcXh6b0pGZjhkZ09DcDJncllGYmpaVWJEd2hBeUxkR055MDk5ek1TakM0?=
 =?utf-8?B?OFFUNDM4aEY2bGtOTVNYVWZTU0R0dUV3LzVjK096S3h1VWZDVktmd2kvMVpy?=
 =?utf-8?B?ZmpaV1RPS2Zpcjk3ZVk2VVFTNW1nOXZGYUdoaGJwcGNqT3pLWWFRbHYyMTJm?=
 =?utf-8?B?WDU0cTg4M1hFbVdUamZDUEl4K3BUMFdtQ0RmS2xGVkdVRTFRdnpOZ2l5SnFH?=
 =?utf-8?B?TEwyUFgveUczY0Nra1dpL1RiVWMvdmxQUVp0alp4cExzaXRDMjZiUVZ6Z2k1?=
 =?utf-8?B?Q1R1YVBlT3pNVkVzR0FnWVA0VHgyb0MvTks3N0YxZDRUak5QRXpoTTRzS2lH?=
 =?utf-8?B?bzBTaGM5bUx6VmdsKzNweTNvYysxckZtRXQrNUVWZTRTKzlRTVoweURmbUgr?=
 =?utf-8?B?b1k1NEVCUlFBY2ZjYjJXNzVQMkoyV3ZsR3VjY2VLOWRpM1RLTVNkMG1WTm1V?=
 =?utf-8?B?aWRDMUszdC9aRFFrR29KZzJwdmNXcmZ2VDgyMXl6QVg4WHhPWnFES1o2LzVO?=
 =?utf-8?B?T2FZRXpvdDJpNm9YM1c3SmdxMHprSnNsOFAwdUhRTW1yVjZwRXVQK3BOdjVS?=
 =?utf-8?B?NVZuUEhoTnB3cy8wMEpKbTMwemdrTHFUeng5azJrVldlNUlGb0g0MTRXMDI3?=
 =?utf-8?Q?fPczDhuO5i1rhfC/2jUHbyV3k?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fd680bd-f09a-49ce-139f-08dc593217ae
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 07:44:46.3530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RdYYXLFX3Jx8V/cC1hcb6rw+xUi/IJiD5i6vjIZipogCv5rkv/bOaWA6vTaDv2ZJS586/0M/MPjYnIcXkpeeDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8173

Thanks Rob for the review.
Bjorn, do you have any further comments for this patch?

On 02-04-2024 21:31, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, 01 Apr 2024 13:20:31 +0530, Vidya Sagar wrote:
>> Add support for preserving the boot configuration done by the
>> platform firmware per host bridge basis, based on the presence of
>> 'linux,pci-probe-only' property in the respective PCI host bridge
>> device-tree node. It also unifies the ACPI and DT based boot flows
>> in this regard.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> V5:
>> * Addressed Rob's review comments
>>
>> V4:
>> * Addressed Bjorn's review comments
>>
>> V3:
>> * Unified ACPI and DT flows as part of addressing Bjorn's review comments
>>
>> V2:
>> * Addressed issues reported by kernel test robot <lkp@intel.com>
>>
>>   drivers/acpi/pci_root.c                  | 12 -----
>>   drivers/pci/controller/pci-host-common.c |  4 --
>>   drivers/pci/of.c                         | 57 +++++++++++++++++++-----
>>   drivers/pci/probe.c                      | 46 ++++++++++++++-----
>>   include/linux/of_pci.h                   |  6 +++
>>   5 files changed, 88 insertions(+), 37 deletions(-)
>>
> Reviewed-by: Rob Herring <robh@kernel.org>
>