Received-SPF: pass (google.com: domain of linux-kernel+bounces-138122-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 10 Apr 2024 09:52:48 +0200
From: Nicolas Schier <n.schier@avm.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>, Tony Finch <dot@dotat.at>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] scripts/unifdef: avoid constexpr keyword
Message-ID: <ZhZFUEFJQ-THmulp@buildd.core.avm.de>
References: <20240408071758.2526806-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240408071758.2526806-1-arnd@kernel.org>

On Mon, Apr 08, 2024 at 09:17:52AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Starting with c23, 'constexpr' is a keyword in C like in C++ and cannot
> be used as an identifier:
> 
> scripts/unifdef.c:206:25: error: 'constexpr' can only be used in variable declarations
>   206 | static bool             constexpr;              /* constant #if expression */
>       |                         ^
> scripts/unifdef.c:880:13: error: expected identifier or '('
>   880 |                 constexpr = false;
>       |                           ^
> 
> Rename this instance to allow changing to C23 at some point in the future.
> 
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Nicolas Schier <nicolas@fjasle.eu>
> Cc: linux-kbuild@vger.kernel.org
> Reviewed-By: Tony Finch <dot@dotat.at>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  v2: include fixup from Tony

thanks, LGTM.

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>