Received-SPF: pass (google.com: domain of linux-kernel+bounces-137542-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-379-gabd37849b7-fm-20240408.001-gabd37849
Precedence: bulk
MIME-Version: 1.0
Message-Id: <03b98c31-130d-4ec7-b162-621bd5b604cf@app.fastmail.com>
In-Reply-To: 
 <CAOg9mSSMAao4WpZWmVhsqLwsn=sfs05XPVuHMdjH0wUyWET_WQ@mail.gmail.com>
References: <20240408075052.3304511-1-arnd@kernel.org>
 <20240408143623.t4uj4dbewl4hyoar@quack3>
 <CAFhGd8ohK=tQ+_qBQF5iW10qoySWi6MsGNoL3diBGHsgsP+n_A@mail.gmail.com>
 <96b55a64-2bcf-44da-a728-ae54e2a73343@app.fastmail.com>
 <CAOg9mSSMAao4WpZWmVhsqLwsn=sfs05XPVuHMdjH0wUyWET_WQ@mail.gmail.com>
Date: Tue, 09 Apr 2024 21:33:48 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Mike Marshall" <hubcap@omnibond.com>
Cc: "Justin Stitt" <justinstitt@google.com>, "Jan Kara" <jack@suse.cz>,
 "Arnd Bergmann" <arnd@kernel.org>, linux-fsdevel@vger.kernel.org,
 "Alexander Viro" <viro@zeniv.linux.org.uk>,
 "Christian Brauner" <brauner@kernel.org>,
 "Martin Brandenburg" <martin@omnibond.com>, devel@lists.orangefs.org,
 "Vlastimil Babka" <vbabka@suse.cz>, "Kees Cook" <keescook@chromium.org>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access
Content-Type: text/plain

On Tue, Apr 9, 2024, at 18:26, Mike Marshall wrote:
> I applied Arnd's patch on top of Linux 6.9-rc3 and
> ran through xfstests with no issue.
>
> Also, instead of Arnd's patch, I used Jan's idea:
>
> +
> +       buf->f_fsid.val[0] = ORANGEFS_SB(sb)->fs_id;
> +       buf->f_fsid.val[1] = ORANGEFS_SB(sb)->id;
> +
>
> And ran that through as well, no issue.
>
> Sorry for missing the earlier patch.

Thanks!

I was about to send the updated patch and can skip that now.

   Arnd