Received: by 2002:ab2:687:0:b0:1f4:6588:b3a7 with SMTP id s7csp263130lqe; Wed, 10 Apr 2024 01:01:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU21G/6v9taujL61g289WCw8aO4B3S2qzPG73zfBjgNv/Y3XmOSlkL5kW5aDsdELnPj92qkVoGGLdJ6ftsiBK9fdVFU8l2zNwmF6viGNQ== X-Google-Smtp-Source: AGHT+IHwu0623nkueleMGQjUwRlV+9HTuzAEQboCFt6HuzYx2UbHg1ODAl3JNEatm1mXewzvcQ19 X-Received: by 2002:a50:c056:0:b0:56e:603:9ff2 with SMTP id u22-20020a50c056000000b0056e06039ff2mr1357897edd.11.1712736092025; Wed, 10 Apr 2024 01:01:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712736092; cv=pass; d=google.com; s=arc-20160816; b=JdpjLqMnHZdiy3iJaq7gfrB/xH+JXrLxClCxll14/chU1N2u34Ti/H54aeQHsIF0wZ 3n87cD6en6RV+rz3sLC+n0E4KLMd3kLts/D93+2Pew7oTujY6RH5FAx9rIIH2Q7Nlhwu +ce2kxjmSi97nKeBj13oy4J1cBiNVC24fODiv8uGda69Bi6dNeoRNi2cbhuC9mF8j3SY RDpqagTSlbL8XX6pIi8Pzt8zkRepNpasQdkPQ9Y8fqyOSmFvwNcYrD0m9Ya41Wb8X6u5 CXQdmCBFn2m7KD5ueGCfOOtT729Ger5B/a2f6YIdAtjjISrGSXYMz55aibnYNC6wZmKe BK8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=Psdmzv9Q22dOjisZFwYedqhwHZwglD6dc0Hocu49us0=; fh=4RS/Zc3fjX1WOI+V6NpHxF/LtqIOgWpbUhvtfn9QLuU=; b=qcuq8tIKqPkgIegDrbxG4Mpour6PZ1ZvR+oLtRDkIv2TWUxNsS68OsVmrPXseGRzTl faoXycJU918MS3nVaaj9WdJIXuS86LS0g4HIkQ+cwkFDH64MTTD69joXejRf/Iws6ZZX 1R6sHkXctWgqdD2BAH+ssPJ4QqrXUv7RaZW2lZVX8DxfBQ1E/qmEWF/jbwgp+egd0HiV kuuzSpmn3i1+/09hCMPHokzWK18k9A6WrOFeLqDL/gG8h5E2xUz+dbtQOHewXgptEXcI AOb7MJilJF6/FJ4TnwuglUOAdTunBfErmpAdeTG4rD2FnCSg5+sgdj+53Cvqe8sz22rJ Djpg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-138128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138128-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id v5-20020a509545000000b00568d7509819si5680600eda.197.2024.04.10.01.01.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 01:01:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-138128-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138128-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BC7921F217C5 for ; Wed, 10 Apr 2024 08:01:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 03BF813D2A0; Wed, 10 Apr 2024 08:01:25 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13C772AE6A for ; Wed, 10 Apr 2024 08:01:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712736084; cv=none; b=tDLyT+C/7h31hMK+/+vl41J9EO2tjXJTYg6L6/0RhG+mUg/iyS4fUBc9/zyrILMaU0EZd4o8jBqJBQSCrKPt86OdfpaYvgl8FugvcDv6d3svmBaP652zmNtw4hBOKFkx8mVWuJdGAV4qkebRTlSABW8x+ZgTx/CEqvadKGfvphY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712736084; c=relaxed/simple; bh=VTwZMXnYIbWR0MWJwZOA1x+kDKtOjvRESHbBhhqjrGk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bx4ofAJ/mjTbyCh/ksXhNOKytWo+t54ZZMFRvayxlWpXhhHEFUZDT4zQV331W50srX+L+SdsuSllyv2Nllgh8FndqcbPywu6vyT/Kh8WpBck8rJ9ztEbVrxUe52M7/gn1IJmMXxnY8J0cap0v/e7iEXVp8mxITY/j+Hk9Yo+iwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C1271480; Wed, 10 Apr 2024 01:01:52 -0700 (PDT) Received: from [10.57.17.166] (unknown [10.57.17.166]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 87FBA3F766; Wed, 10 Apr 2024 01:01:18 -0700 (PDT) Message-ID: <1d317158-f9a4-48b8-bc29-5a1d75c6493d@arm.com> Date: Wed, 10 Apr 2024 09:01:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Fix wrong flag passed to set_rd_overutilized() To: Shrikanth Hegde Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Vincent Guittot , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider References: <0afb160788a297f8cda63b70385de5f6bddec11e.1712693356.git.hongyan.xia2@arm.com> <4370fce5-323e-4f03-87e1-89632e724e2c@linux.ibm.com> Content-Language: en-US From: Hongyan Xia In-Reply-To: <4370fce5-323e-4f03-87e1-89632e724e2c@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/04/2024 07:11, Shrikanth Hegde wrote: > > > On 4/10/24 1:43 AM, Hongyan Xia wrote: >> In update_sd_lb_stats(), sg_overloaded is passed to >> set_rd_overutilized(). This seems to be a typo during refactoring, which >> breaks many of my local EAS tests because overutilization is mistakenly >> triggered. >> >> This fix makes those EAS tests work again. >> > > Yes. This is a needed fix. > >> Signed-off-by: Hongyan Xia > > > FYI, Same patch has been posted by Vincent a week ago. > https://lore.kernel.org/all/20240404155738.2866102-1-vincent.guittot@linaro.org/ Thank you. Somehow I missed it in my inbox.