Received-SPF: pass (google.com: domain of linux-kernel+bounces-138143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 10 Apr 2024 10:09:48 +0200
From: Kory Maincent <kory.maincent@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet
 <corbet@lwn.net>, Luis Chamberlain <mcgrof@kernel.org>, Russ Weight
 <russ.weight@linux.dev>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Oleksij Rempel <o.rempel@pengutronix.de>, Mark Brown
 <broonie@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project
 <dentproject@linuxfoundation.org>, kernel@pengutronix.de, Maxime Chevallier
 <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v7 13/17] net: pse-pd: Use regulator framework
 within PSE framework
Message-ID: <20240410100948.1df6ca0d@kmaincent-XPS-13-7390>
In-Reply-To: <20240409141621.392bd34b@kernel.org>
References: <20240409-feature_poe-v7-0-11e38efd4dee@bootlin.com>
	<20240409-feature_poe-v7-13-11e38efd4dee@bootlin.com>
	<20240409141621.392bd34b@kernel.org>
Organization: bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 9 Apr 2024 14:16:21 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Tue, 09 Apr 2024 17:04:03 +0200 Kory Maincent wrote:
> > -static inline struct pse_control *of_pse_control_get(struct device_node
> > *node) +static inline struct pse_control *of_pse_control_get(struct dev=
ice
> > *dev,
> > +						     struct device_node
> > *node) =20
>=20
> One of the related patches breaks the build:
>=20
> drivers/net/mdio/fwnode_mdio.c: In function =E2=80=98fwnode_find_pse_cont=
rol=E2=80=99:
> drivers/net/mdio/fwnode_mdio.c:32:35: error: passing argument 1 of
> =E2=80=98of_pse_control_get=E2=80=99 from incompatible pointer type
> [-Werror=3Dincompatible-pointer-types] 32 |         psec =3D
> of_pse_control_get(np); |                                   ^~ |
>                      | |                                   struct device_=
node
> * In file included from drivers/net/mdio/fwnode_mdio.c:13:
> ./include/linux/pse-pd/pse.h:157:69: note: expected =E2=80=98struct devic=
e *=E2=80=99 but
> argument is of type =E2=80=98struct device_node *=E2=80=99 157 | static i=
nline struct
> pse_control *of_pse_control_get(struct device *dev, |
>                              ~~~~~~~~~~~~~~~^~~
> drivers/net/mdio/fwnode_mdio.c:32:16: error: too few arguments to function
> =E2=80=98of_pse_control_get=E2=80=99 32 |         psec =3D of_pse_control=
_get(np); |
>     ^~~~~~~~~~~~~~~~~~ In file included from
> drivers/net/mdio/fwnode_mdio.c:13: ./include/linux/pse-pd/pse.h:157:35: n=
ote:
> declared here 157 | static inline struct pse_control
> *of_pse_control_get(struct device *dev, |
> ^~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors

Arg, a leftover of an old version of the series.
Thanks for the report.

Regards,
--=20
K=C3=B6ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com