Received-SPF: pass (google.com: domain of linux-kernel+bounces-138210-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <b9ee67f1a6d782e6b6ee9e273bc8c6fa5bc1813b.camel@pengutronix.de>
Subject: Re: [RFC PATCH v2 1/5] clk: meson: axg: move reset controller's
 code to separate module
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Stephen Boyd <sboyd@kernel.org>, Conor Dooley <conor@kernel.org>
Cc: Jan Dakinevich <jan.dakinevich@salutedevices.com>, Jerome Brunet
 <jbrunet@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Michael
 Turquette <mturquette@baylibre.com>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>,  Kevin Hilman <khilman@baylibre.com>, Martin
 Blumenstingl <martin.blumenstingl@googlemail.com>, 
 linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, 
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
 linux-arm-kernel@lists.infradead.org
Date: Wed, 10 Apr 2024 10:56:56 +0200
In-Reply-To: <dde59dd2ef4da81528e31f65844e0b3f.sboyd@kernel.org>
References: <20240328010831.884487-1-jan.dakinevich@salutedevices.com>
	 <20240328010831.884487-2-jan.dakinevich@salutedevices.com>
	 <1j7chfiz8e.fsf@starbuckisacylon.baylibre.com>
	 <e3a85852b911fdf16dd9ae158f42b3ef.sboyd@kernel.org>
	 <f01cdd910ab35316b8012795f73fd2b34c8e6f8e.camel@pengutronix.de>
	 <13617b7a892424d2b024c725505a6f4f.sboyd@kernel.org>
	 <20240408-numerator-escargot-a642507a598e@spud>
	 <20240409-shallow-voice-c84ed791bc7d@spud>
	 <dde59dd2ef4da81528e31f65844e0b3f.sboyd@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
Precedence: bulk
MIME-Version: 1.0

On Di, 2024-04-09 at 19:27 -0700, Stephen Boyd wrote:
> Quoting Conor Dooley (2024-04-09 05:05:37)
> > On Mon, Apr 08, 2024 at 06:05:51PM +0100, Conor Dooley wrote:
> >=20
> > > > > Seconded, the clk-mpfs/reset-mpfs and clk-starfive-jh7110-sys/res=
et-
> > > > > starfive-jh7110 drivers are examples of this.
> > > > >=20
> > > > > > The auxiliary device creation function can also be in the
> > > > > > drivers/reset/ directory so that the clk driver calls some func=
tion
> > > > > > to create and register the device.
> > > > >=20
> > > > > I'm undecided about this, do you think mpfs_reset_controller_regi=
ster()
> > > > > and jh7110_reset_controller_register() should rather live with th=
e
> > > > > reset aux drivers in drivers/reset/ ?
> > > >=20
> > > > Yes, and also mpfs_reset_read() and friends. We should pass the bas=
e
> > > > iomem pointer and parent device to mpfs_reset_adev_alloc() instead =
and
> > > > then move all that code into drivers/reset with some header file
> > > > exported function to call. That way the clk driver hands over the d=
ata
> > > > without having to implement half the implementation.
> > >=20
> > > I'll todo list that :)
> >=20
> > Something like the below?
> >=20
> > -- >8 --
> > From a12f281d2cb869bcd9a6ffc45d0c6a0d3aa2e9e2 Mon Sep 17 00:00:00 2001
> > From: Conor Dooley <conor.dooley@microchip.com>
> > Date: Tue, 9 Apr 2024 11:54:34 +0100
> > Subject: [PATCH] clock, reset: microchip: move all mpfs reset code to t=
he
> >  reset subsystem
> >=20
> > <insert something here>
> >=20
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>=20
> Looks pretty good.

Yes, that does look convincing.

regards
Philipp