Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp21229lqj; Wed, 10 Apr 2024 02:33:56 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWcHuVp2JTaWkmJTznUL4mGH4JDoPgQTZ/CGpcYEiOu1/fRz3CJ9Ww2wB2pHNgt6sEq/BQi4AzEUZ73lsKJxSlF/20jq0kj8p65a15bWg== X-Google-Smtp-Source: AGHT+IHzIi3GfKQ573aiOo+CUKIpiw6ik3Qn4NrC5k+xYuaZ3QLKFDN+F6S078Mc6ctV5u47iFw4 X-Received: by 2002:a05:6359:5a0d:b0:17f:729a:8568 with SMTP id mw13-20020a0563595a0d00b0017f729a8568mr4027217rwb.4.1712741636048; Wed, 10 Apr 2024 02:33:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712741636; cv=pass; d=google.com; s=arc-20160816; b=M9h74Iwnd+YL8kXC9Ei9G0PMeVUsDJZJ9goChB6D7Dj2BPWEJHZQROK5nTZuR+5Zmd BidEfdA76FywyDBSSPAkpd/i1F1x7QzUKMVxJZRH60i+kYru/9uEfhDUkmIe1HfFTs6i JRGW/uBEa1r051ILfa2i1L4JnNzv47+bLII0NsiJQpQy6+V+25n/CUniQsihBcrOBvzl rjqAjCkXoMU7UPu3TbkjbNeQdbFhwUep9Oq59SpSZPytIxb1sp7vIr/r8DWA2ZisTPFK huobPzLTGbOBl8nyMjrQwgFSjA2enMVGETX+KNseF8jcoXFes/0FLYMXpV7JK27We3Cn 1Org== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:message-id:references:in-reply-to:subject :cc:to:from:date:dkim-signature:mime-version:list-unsubscribe :list-subscribe:list-id:precedence; bh=RiYdWuU6TA/MRaisJkvN1oi05HBnSA4JJqXFKW8pk3w=; fh=Cvkuz/cb3aUD9obp+m+12PGIkCwVI5wGzW0KSIluJB4=; b=Vdeu1UQNzIqTpo2Dj/Jg8SLsqAumuyR8DK2UuY+h9u16uONXlymDFpA4B+lXBkraUM dQA/W1MLZm5L2QkJnEZjIQmf3dkOEyjyTdOpJhMVdxRLGuHVzpGadGLpyx0w5YAOsmI+ xoP5jKHtNVGbEme8/EEGMznNw90K66EwNYr5MRwSmBESDPTrC2TsAH8Z6QrIXBACJ6Ko 07E0pN1QjuNtH6EMGbx/3WqA+SOAKbyOb0p+ZB8OVZQh6wtxjam25iHkTfnoOX8/jDHl zapOuVeHeavwV2yWFn7lZBBdtE2CSylqc1VZN9vi8HDVoJgScPxJ5rdzjaeLVVBbc/do BWQw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@manjaro.org header.s=2021 header.b=abHtNVPg; arc=pass (i=1 spf=pass spfdomain=manjaro.org dkim=pass dkdomain=manjaro.org dmarc=pass fromdomain=manjaro.org); spf=pass (google.com: domain of linux-kernel+bounces-138250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manjaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s17-20020a632c11000000b005dd3d01b50asi10445497pgs.17.2024.04.10.02.33.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 02:33:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@manjaro.org header.s=2021 header.b=abHtNVPg; arc=pass (i=1 spf=pass spfdomain=manjaro.org dkim=pass dkdomain=manjaro.org dmarc=pass fromdomain=manjaro.org); spf=pass (google.com: domain of linux-kernel+bounces-138250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=manjaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BF29FB23E5F for ; Wed, 10 Apr 2024 09:28:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CEE4F155732; Wed, 10 Apr 2024 09:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="abHtNVPg" Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2271F1552EF; Wed, 10 Apr 2024 09:28:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712741295; cv=none; b=J6AFRe5/5TIkhfTY6f0U7HEKVg7xSSdPie9QWTxiEFqHytVAOjspR3ggryHcy6/pbfYQMzdZMpt0a1vpxbk8eKLt2YcNc2dNYfn6ESsBF8p8UXexi/MKHpbjUZnJew8Wi0/EsTFw98A0vmsHn83NrEtekA8mLyOn177LFs+XauI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712741295; c=relaxed/simple; bh=zsoYaP4ttIY6R/+fdqaCRZ/R7zwJWemSd7limzCI9I0=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=BJU0r0gdjtmTKIQftIFLY+MEmVuRqCXEU+b/RbyKFhMWO3+L4X81hyLASOjtW3O6hkrhAxB3xHRdrg1ldtGuwWL2zBXGYLYKViffylifKqdYzXjKtw5x9CHnK0g7AXNoKerPZ6EUgmRWB15h+nJPnAkTIJ112tpV6qC08R3LxZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=abHtNVPg; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1712741290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RiYdWuU6TA/MRaisJkvN1oi05HBnSA4JJqXFKW8pk3w=; b=abHtNVPg9dPnB3ukM7+xz0G35WCgg6u8vPOyxisReIzDTWEfKOBvxo9dx+qa1/TAR+GQF3 +Z3ZNNgMSDrnnUGkamYkqWlDfofS646hD7T77g/GzFAHBQGStPmMU9ldYydE85W7oA1Sc5 MD7+cJt4LFCF5RLhEAt0MQ897p4uZJ/hgIBFvPuu7np1QFCMTCtQGo/zLuw9LuA1PHfxOP dSHLs9caK6SSVb2GOvnPyab2fPaVUcmIzuUEVei7ML4A9K66r4ZXLw/5Jpw/uQyNFIbsmN 2PI/V1Q/GaRieWtjhBrHzYBqjhSRbHumZ2Qy5Tg8lvQYORUG4Dy8ZR64pLZJSw== Date: Wed, 10 Apr 2024 11:28:09 +0200 From: Dragan Simic To: Diederik de Haas Cc: Alexey Charkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , linux-rockchip@lists.infradead.org, Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/5] RK3588 and Rock 5B dts additions: thermal, OPP and fan In-Reply-To: <66689051.MzlzmSNrL9@bagend> References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <66689051.MzlzmSNrL9@bagend> Message-ID: <9f4c7615a6685ac42dccdbe35e57c357@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello Diederik, On 2024-04-10 11:19, Diederik de Haas wrote: > On Thursday, 29 February 2024 20:26:31 CEST Alexey Charkov wrote: >> This enables thermal monitoring and CPU DVFS on RK3588(s), as well as >> active cooling on Radxa Rock 5B via the provided PWM fan. >> >> Some RK3588 boards use separate regulators to supply CPUs and their >> respective memory interfaces, so this is handled by coupling those >> regulators in affected boards' device trees to ensure that their >> voltage is adjusted in step. >> >> >> Signed-off-by: Alexey Charkov >> --- >> Alexey Charkov (5): >> arm64: dts: rockchip: enable built-in thermal monitoring on >> RK3588 >> arm64: dts: rockchip: enable automatic active cooling on Rock 5B >> arm64: dts: rockchip: Add CPU/memory regulator coupling for >> RK3588 >> arm64: dts: rockchip: Add OPP data for CPU cores on RK3588 >> arm64: dts: rockchip: Add further granularity in RK3588 CPU OPPs >> >> arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 12 + >> .../arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 12 + >> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 30 +- >> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 385 >> ++++++++++++++++++++- 4 files changed, 437 insertions(+), 2 >> deletions(-) >> --- >> base-commit: cf1182944c7cc9f1c21a8a44e0d29abe12527412 >> change-id: 20240124-rk-dts-additions-a6d7b52787b9 > > Can you rebase this patch set on Heiko's for-next branch [1]? > And then also fix the ordering of the nodes and the elements within > those nodes so that they match the current conventions? Ah, thanks, this is a good reminder about the proposal for the plan for moving forward, which I promised to send a while ago. :) > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/log/?h=for-next