Received-SPF: pass (google.com: domain of linux-kernel+bounces-138358-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240409153519.291205-2-thorsten.blum@toblux.com>
In-Reply-To: <20240409153519.291205-2-thorsten.blum@toblux.com>
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date: Wed, 10 Apr 2024 12:43:41 +0200
Message-ID: <CAMhs-H8EByNhBAkhDvtHL_ZUgLnMFQcR1zeYhaKQSg-13uFnVQ@mail.gmail.com>
Subject: Re: [PATCH] MIPS: ralink: Use min() to fix Coccinelle warning
To: Thorsten Blum <thorsten.blum@toblux.com>
Cc: John Crispin <john@phrozen.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Thorsten,

On Tue, Apr 9, 2024 at 5:36=E2=80=AFPM Thorsten Blum <thorsten.blum@toblux.=
com> wrote:
>
> Fixes the following Coccinelle/coccicheck warning reported by
> minmax.cocci:
>
>         WARNING opportunity for min()
>
> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> ---
>  arch/mips/ralink/timer.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
> index 54094f6e033e..d271ac98312a 100644
> --- a/arch/mips/ralink/timer.c
> +++ b/arch/mips/ralink/timer.c
> @@ -75,11 +75,7 @@ static int rt_timer_request(struct rt_timer *rt)
>
>  static int rt_timer_config(struct rt_timer *rt, unsigned long divisor)
>  {
> -       if (rt->timer_freq < divisor)
> -               rt->timer_div =3D rt->timer_freq;
> -       else
> -               rt->timer_div =3D divisor;
> -
> +       rt->timer_div =3D min(rt->timer_freq, divisor);

I do find the original code more readable.

Best regards,
    Sergio Paracuellos

>         rt_timer_w32(rt, TIMER_REG_TMR0LOAD, rt->timer_freq / rt->timer_d=
iv);
>
>         return 0;
> --
> 2.44.0
>