Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp62566lqj; Wed, 10 Apr 2024 04:13:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU9drA30kUJGtj3AVpGUFO+IJ4YLayLLlF6LP4qcW2WYe1GnyY03ZzX7TniCpEiuDF5UmQEkk4W0FwoGB86b36Yz9rL6HiywXEiiojMpg== X-Google-Smtp-Source: AGHT+IHDpkOlXKoKskkG52DFb6trm9PXb9c+T73V/b/lElVZW7Bu+OaSq11gUruN7vpB97eTtkDf X-Received: by 2002:a17:902:d2c9:b0:1e4:4537:40ab with SMTP id n9-20020a170902d2c900b001e4453740abmr2527919plc.12.1712747609712; Wed, 10 Apr 2024 04:13:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712747609; cv=pass; d=google.com; s=arc-20160816; b=oynHegGnFMJHgFOO2uM74YKff/i1tXOHOW+zfT9U6sNXtUH66tHGMXXaZN61NAGss8 0OIj4Z5iAUMYouR935EFTjliI5VY79aUElT6hKsMQ5jAHAaHQYjDURImRDGMwNnqBRpa NvIALkBaEjfHpW/VQ6AcuApCgfuDcHbr95WkbdXyBo63GO97HviyfrkUKAK6qDtgjD1P PvmUpDPtQmTsR7r7Ax4LqKQhxv584G0G/1inVtgA6h9SN6vik1uTWqkmDVZj1Aa7RraR Ke7eBNMDhdNyw/IMogHn41ZZ6mAiCFbRYsuuhM2ZAJGCU8jsHMJlvDSU3lKirJTLeVuc K7KQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=3NKuEGy7DGbRGNtgId65Fgs0SQs/0kAjzl2ZfgaeWJY=; fh=Wbw5TvxHa83FV4OqtXQSD31xg/OVCA86GyxforvF3Pk=; b=yf9+UN15ABQLqPs4dJ0x/ducjXLK8qcxHCSXoneP3P/IQKxAmqKGRy0He9VTvVb/6q R7tZQezgq0XoAl1KhChz+nCEFPrKHZEkxtRRjVvS+O3yLvENaa5NmuyZjANrjALFsGq6 ueWgaLTCc7gAK0FuHRavhfZ+anA2Uy61CS1K6mGDE9k+4fuyXGtKhzQ+6lqDTORQMOLc TXMbQBT7L2OpHnqIpSumfnmKYVwM2nMt6VNF7fYRA2bP7VYYQPAIcIAyyzkivcPVaO9P GuWBob2hS1ko7q0vV5Yy+ArSqmVDYbkVxxPy1fKvYxO5ES2TPhj0iEkWf3r58NbHouZO B6Bw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=mgQg8l4t; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-138382-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138382-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c10-20020a170903234a00b001e5108136efsi521279plh.158.2024.04.10.04.13.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 04:13:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138382-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=mgQg8l4t; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-138382-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138382-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 41483B21473 for ; Wed, 10 Apr 2024 11:11:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 821F215959B; Wed, 10 Apr 2024 11:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mgQg8l4t" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EC23156C4C; Wed, 10 Apr 2024 11:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712747490; cv=none; b=bqrm8fkD+PsqzSat1Ox9qICL36U0hENKq64Eyvm3SLnsxvu3JikjNmc82pl3i1wIL8EnYQKe+ZT4qqLwCv+cRtDI6e7wLe3t1LgDcMvm30smFkcQmt+6TKJjU9fqpLwtxRwDCUX7vb8My3LPCnwl4QUxJav+cpAtFuT0G5vvR60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712747490; c=relaxed/simple; bh=/VeiGzK8lC3FVg2lRwCpx8Hm9fTsDx2RHhQLKAONLqc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DSfXyUe+aAojTQIhS4RQ6dRjLktZF3bSWUwoiSPQsgwDZYfy17PRNja5cc66/a5j/9QKug2W5li/j9KkfM0xUHMcb/QOORcjrn9xicgCRijvbxkqymMBt1fqd36PvaPFRk/hTBEGRRcPrLfIymgsqn6bNq4wpfUrb9+BP45XAfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=mgQg8l4t; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from [192.168.88.20] (91-154-34-181.elisa-laajakaista.fi [91.154.34.181]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A3CA4741; Wed, 10 Apr 2024 13:10:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712747445; bh=/VeiGzK8lC3FVg2lRwCpx8Hm9fTsDx2RHhQLKAONLqc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mgQg8l4t09o5g0UmavOhXgAGn1qjP3Zh/RXRb7FApGEUzT//zYQMuyq+Az9GLg3Pj 0vF72/zCXKUFrAty95MfnmdNah7e15BHQQxDy0fQJr5p+41JkO6wb4Qeh50vlfqjqi kepxIKlmgTNAyj3CumLC7Kb6sXFfZXKGXC6jaDTs= Message-ID: <0b4f1714-2c63-4cc5-9288-f419512bf3d4@ideasonboard.com> Date: Wed, 10 Apr 2024 14:11:23 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm: xlnx: db: fix a memory leak in probe To: Dan Carpenter , Rohit Visavalia Cc: Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Michal Simek , Vishal Sagar , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <86def134-9537-4939-912e-3a424e3a75b6@moroto.mountain> Content-Language: en-US From: Tomi Valkeinen Autocrypt: addr=tomi.valkeinen@ideasonboard.com; keydata= xsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2 wCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA Ru0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO eYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn LnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA G4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk DYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7 0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO rXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv Bus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl aW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+ ll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6 PaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT VDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA 0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi uBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU R4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+ sR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl Rz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3 PxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs dcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE qHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU hsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE DDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa KbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk 0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb xPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy UVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9 /4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c 9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb 4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH mvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe 9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S suYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq xKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII m9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU CH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B CFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof 92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a ueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F yjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw 3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw== In-Reply-To: <86def134-9537-4939-912e-3a424e3a75b6@moroto.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/04/2024 10:32, Dan Carpenter wrote: > Free "dp" before returning. > > Fixes: be318d01a903 ("drm: xlnx: dp: Reset DisplayPort IP") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c > index 5a40aa1d4283..8a15d18a65a6 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c > @@ -1716,7 +1716,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub) > > ret = zynqmp_dp_reset(dp, true); > if (ret < 0) > - return ret; > + goto err_free; > > ret = zynqmp_dp_reset(dp, false); > if (ret < 0) Thanks, applying to drm-misc-next. Tomi