Received-SPF: pass (google.com: domain of linux-kernel+bounces-138485-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 10 Apr 2024 14:25:18 +0200 (CEST)
From: Romain Gantois <romain.gantois@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
cc: Romain Gantois <romain.gantois@bootlin.com>, 
    "David S. Miller" <davem@davemloft.net>, 
    Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, 
    Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>, 
    Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
    Conor Dooley <conor+dt@kernel.org>, 
    Geert Uytterhoeven <geert+renesas@glider.be>, 
    Magnus Damm <magnus.damm@gmail.com>, 
    Alexandre Torgue <alexandre.torgue@foss.st.com>, 
    Jose Abreu <joabreu@synopsys.com>, 
    Maxime Coquelin <mcoquelin.stm32@gmail.com>, 
    Russell King <linux@armlinux.org.uk>, 
    =?ISO-8859-15?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>, 
    Thomas Petazzoni <thomas.petazzoni@bootlin.com>, netdev@vger.kernel.org, 
    devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
    linux-renesas-soc@vger.kernel.org, 
    linux-stm32@st-md-mailman.stormreply.com, 
    linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1
 GMAC
In-Reply-To: <CAMuHMdX-F8LXWx=Ras4f+Dt_r485HKjRDLydDXZsnZBW8HJzxw@mail.gmail.com>
Message-ID: <9bd8eee4-952d-d5b2-c462-45c1466c54d6@bootlin.com>
References: <20240409-rzn1-gmac1-v2-0-79ca45f2fc79@bootlin.com> <20240409-rzn1-gmac1-v2-4-79ca45f2fc79@bootlin.com> <CAMuHMdX-F8LXWx=Ras4f+Dt_r485HKjRDLydDXZsnZBW8HJzxw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="1582177605-1727822458-1712751921=:538696"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--1582177605-1727822458-1712751921=:538696
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

Hi Geert,

On Tue, 9 Apr 2024, Geert Uytterhoeven wrote:

> > +config DWMAC_RZN1
> > +       tristate "Renesas RZ/N1 dwmac support"
> > +       default ARCH_RZN1
> 
> Why default to enabled?
> 
> > +       depends on OF && (ARCH_RZN1 || COMPILE_TEST)

The kernel doc states this as one of the possible cases where setting default 
y/m makes sense:

```
Sub-driver behavior or similar options for a driver that is “default n”. This 
allows you to provide sane defaults.
```

In the case of DWMAC_RZN1, it is a suboption of stmmac which is "default n", and 
I think it makes sense to enable the RZN1 ethernet controller driver if both the 
stmmac driver and the RZN1 architecture were explicitely selected.

Best Regards,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--1582177605-1727822458-1712751921=:538696--