Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp105354lqj; Wed, 10 Apr 2024 05:37:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUsfYM/z4bj6mgVbByKHJTcX7cH2t+gs52j6fEjxIV4xAJqJ5TrT6D9/lgXZrTNJs6xThryvg8HTo6MoJdA3hnPCrx9E7XY5PgeiGYrTw== X-Google-Smtp-Source: AGHT+IHH6oCd/rjDobM6UHTSOiDIqZUpIIVHLOs32S9M8qC8P2n+rE6YTM5cLPeqnoc1kv7BuVgu X-Received: by 2002:a17:90a:4d8f:b0:2a5:3b9:928 with SMTP id m15-20020a17090a4d8f00b002a503b90928mr2186886pjh.28.1712752626695; Wed, 10 Apr 2024 05:37:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712752626; cv=pass; d=google.com; s=arc-20160816; b=HIYQPLguaKw1l8a7Il6JX4o6eut+x6sl8OeueIz3uZd0qBFUcPaDdB3woVcYDSQ9B9 uq7eKaotQKyYitgXkHpNuz2zvpQbCXDfqJkgb+2cHrzriAysNku5Sp0ERX3M5It/PhcY 8vM0cqL8SeRDFKtfXw7vGmp+B4Rm/dlXx8B0cnle1HH5xo1ngP3d7F9vVE7zzg8g0oOv NFKMAfPrye1RGKgLjhNq7lLKq0SCW1O1UT4I416Tg4FM+hxvuEfXgF2N0wgb1Ebrj3Lr JoaiWc7iFu0M4ZhmxohhsAACOAzEEKE7OjE2JayZwnBfU2NFiDMWtffFFyjzN+MpthKB h9bA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:from :dkim-signature; bh=gUJk3s+g0gf/oCnedvHlI7mVHiQvuTNnh2KsVpkzKkc=; fh=KsVfM5wJAwSmWlBDhQUIuzi3h8aTwgJEe33eqLJyRj0=; b=LItPxtj5jVI1ePyVRcPxoOQzlahJxVi7T9G8mflAU9idCDfNP8PpPXUTJhCy+Z7hMG XJvzWMB7YlGZRtDd5QoHi7tkVx52+AY5m5iq0dbOimgDcd6p5uTNBxEzkIXbqiBISQBQ F/6DrUem3D/m7z/o0gL/vLLoqwCAiZuQy5apDVvhRfN0w2BeWgc0yioSMPeadWfzDRVb dD9JZGaAd8zD23JucolytQ/6mMdNcGRxRdjRruhZZOkdjLb8hodh0hb7Ne0OFQx/FTPG AP9yjU2i1mqV9rcbJkXTy2zYf49rS4dDKnG66oe0CV/9DKKQco6m2dReL7SmsedxCzGG Yxyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=fnNN7Rjq; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-138505-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138505-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id j8-20020a17090aeb0800b002a0726b07dasi1462089pjz.118.2024.04.10.05.37.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 05:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138505-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=fnNN7Rjq; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-138505-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138505-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 17DD82869A2 for ; Wed, 10 Apr 2024 12:37:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0BD3615B14C; Wed, 10 Apr 2024 12:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fnNN7Rjq" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E6CA2BAEC; Wed, 10 Apr 2024 12:36:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712752614; cv=none; b=lcw0bmXWY7RMbqBevVi2wxnchI0JdW+CvG4pU0x2jjLuRGrb7epGggxN1sbTjWpiTEkzZMfGDDSiTQ/trGFprQx6RR09VHusA92c1ffo2+zPg6MP5lZaP0jWRwl2asAjfTVtk4+vyYSd6ZrYHt+0DzssgPndf2Cgvb0jOYDaw10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712752614; c=relaxed/simple; bh=RxANx2ecABIJ7VUtAP4l0MvYWpheCKmTFHpvSVmBTYE=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=gPTWxO3GXTe7f1f0wjJrEscVUiliOR/BewpbeDLheB/OoOkqpthKhu1oyrQWCTo2RE4VfHk8+8bKRC7bVhU5sN6Mu0D7kXOrsgk1x1CgvSiqbuS63piodIEzY9THfiyLmGNEJydvXhi26faWgbDz9+riC/yruFakIZk8O6UZYYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=fnNN7Rjq; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from [127.0.1.1] (91-154-34-181.elisa-laajakaista.fi [91.154.34.181]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F15656BE; Wed, 10 Apr 2024 14:36:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712752568; bh=RxANx2ecABIJ7VUtAP4l0MvYWpheCKmTFHpvSVmBTYE=; h=From:Subject:Date:To:Cc:From; b=fnNN7RjqfHuH/qSCYaIfOWMIlZ3URh78Jb/KTWmkY94pNQjzaZyuIDHvej7vbOMX3 0EgNygHIfUgeRS5wv26ih68DBT1mJKaiVhK7dWxN+j9h7Zipl/2QV/Unwy57F5Lhcj Oo2V+KbCH1sosx6W3pQW3AWZYV5H0JFQbNzRngJI= From: Tomi Valkeinen Subject: [PATCH v3 0/9] media: subdev: Improve stream enable/disable machinery Date: Wed, 10 Apr 2024 15:35:47 +0300 Message-Id: <20240410-enable-streams-impro-v3-0-e5e7a5da7420@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAKOHFmYC/4XNSw6CMBCA4auQrq1pC6XgynsYF32MMom0pCWNh nB3CysXGjOrf5L5ZiEJIkIip2ohETImDL5EfaiIHbS/A0VXmggmGlaGgtfmATTNEfSYKI5TDNS ZzljX9V2jOCmnU4QbPnf2ci09YJpDfO1fMt+2f8DMKaOccaVraQwwdUYHOgVvgo7uaMNINjeLT 0v+sESxhDBW961qW+m+WOu6vgHYdq8BCwEAAA== To: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Umang Jain Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2523; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=RxANx2ecABIJ7VUtAP4l0MvYWpheCKmTFHpvSVmBTYE=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBmFofam8xjwyvp3kqcaLiyYajCVSk3Xp8y/IDVb g8L1GuoNaOJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZhaH2gAKCRD6PaqMvJYe 9YnkEACdN/8i7fyBExglNHzkTVOmNUx5chAn8FGq8NIpHW3nqNW4jLx472cJtjwf04bPGnboRv5 Ve5W5BEksVAI9i3v7Jns6QPXBXFU848pcoAovnFuwWhSHHAT8ixmdpOsTd/K6Jz/fIOZCvOlR9r KQjncmbRvcFrBtuU9P6yHHqkKOAvRltdi9eSYCEkU8St1ITjmWRjIamAkxhAkcykWKjN6YtHZx9 RXIO0KwBfhPHzMvKR45Pg4QMvu38l5mBVMNAa4ZYqHKiAJmmVNEdeV60JNS/x5ZW1JWtLkkI/4U N256y09PsoRUaLWoUxrX4T7MQyOjENFeoD/tK3IpOtOCYaa+jYTWztPFCXIO+Uaq1eN+IF6HKdD yTFfHDSzkxVpvumYyGWhBWOmz9DOxUcWTn8bKbLBmYG6ETpfieMQQsIxcIqF5u1wB3s/xsgIIjW J+WY/1YWDQ/Q1zYTkAl7CUau8S7sAMe8sFeDtUPiOYq95cGQ0f/bTDX90QiC5t8nDuHsfc0q9vl MJgdHM3WjnJNcMase+NgjyT/Rsx0GhaFK2uyTbwcTGQgf0KDBuai2p0U/8CQpzEMMWidlvJTJBK KzhxZWF0NWNh25PQMYiF8PmJNlYZVPPI0vb/JhxSzEnNkBeFNiXzGF4DSzePHfvefpaUCHiYa8Y 6qhPC1lDcftwyew== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 This series works on the .s_stream, .enable_streams, .disable_streams related code. The main feature introduced here, in the last patch, is adding support for .enable/disable_streams() for subdevs that do not implement full streams support. Additionally we add support for the privacy led when v4l2_subdev_enable/disable_streams() is used. I have tested this on RPi5. Tomi Signed-off-by: Tomi Valkeinen --- Changes in v3: - Rebased on top of "[PATCH v2 1/1] media: v4l: Don't turn on privacy LED if streamon fails" - Drop extra "!!" in "media: subdev: Fix use of sd->enabled_streams in call_s_stream()" - Enable privacy LED after a succesfull stream enable in "media: subdev: Support privacy led in v4l2_subdev_enable/disable_streams()" - Init 'cfg' variable when declaring in "media: subdev: Refactor v4l2_subdev_enable/disable_streams()" - Link to v2: https://lore.kernel.org/r/20240405-enable-streams-impro-v2-0-22bca967665d@ideasonboard.com Changes in v2: - New patches for privacy led - Use v4l2_subdev_has_op() - Use BITS_PER_BYTE instead of 8 - Fix 80+ line issues - Fix typos - Check for pad < 64 also in the non-routing .enable/disable_streams code path - Dropped "media: subdev: Support enable/disable_streams for non-streams subdevs", which is implemented in a different way in new patches in this series - Link to v1: https://lore.kernel.org/r/20240404-enable-streams-impro-v1-0-1017a35bbe07@ideasonboard.com --- Tomi Valkeinen (9): media: subdev: Add privacy led helpers media: subdev: Use v4l2_subdev_has_op() in v4l2_subdev_enable/disable_streams() media: subdev: Add checks for subdev features media: subdev: Fix use of sd->enabled_streams in call_s_stream() media: subdev: Improve v4l2_subdev_enable/disable_streams_fallback media: subdev: Add v4l2_subdev_is_streaming() media: subdev: Support privacy led in v4l2_subdev_enable/disable_streams() media: subdev: Refactor v4l2_subdev_enable/disable_streams() media: subdev: Support single-stream case in v4l2_subdev_enable/disable_streams() drivers/media/v4l2-core/v4l2-subdev.c | 355 ++++++++++++++++++++-------------- include/media/v4l2-subdev.h | 25 ++- 2 files changed, 229 insertions(+), 151 deletions(-) --- base-commit: 6547a87b1ffc9b3c3a17f20f71016de98c169bbb change-id: 20240404-enable-streams-impro-db8bcd898471 Best regards, -- Tomi Valkeinen